Skip to contentSkip to conversation

Move function declaration from C source to header file

PATCH In review Stefan Weil 2 participants 2 messages Jun 1, 2008 – Jun 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Move function declaration from C source to header file

This patch moves the declaration for function wav_start_capture from C source to the header file.

Please apply the patch to Qemu trunk.

Thanks,
Stefan

audio.h +3 -0
Index: audio/audio.h
===================================================================
@@ -87,6 +87,9 @@
     uint64_t old_ts;
 } QEMUAudioTimeStamp;
 
+int wav_start_capture (CaptureState *s, const char *path, int freq,
+                       int bits, int nchannels);
+
 void AUD_vlog (const char *cap, const char *fmt, va_list ap);
 void AUD_log (const char *cap, const char *fmt, ...)
 #ifdef __GNUC__
monitor.c +0 -3
Index: monitor.c
===================================================================
@@ -1264,9 +1264,6 @@
 }
 
 #ifdef HAS_AUDIO
-int wav_start_capture (CaptureState *s, const char *path, int freq,
-                       int bits, int nchannels);
-
 static void do_wav_capture (const char *path,
                             int has_freq, int freq,
                             int has_bits, int bits,
#1 lore raw
Quoted 2 lines · Stefan Weil

This patch moves the declaration for function wav_start_capture from C source to the header file.

It would be better to remove do_wav_capture() from monitor.c and then have a declaration of do_wav_capture in a header file.

Eventually, it would be good to make the monitor commands be registered by the various subsystems so it makes sense to move the monitor command implementations to their logical subsystems.

Regards,

Anthony Liguori

Quoted 5 lines

Please apply the patch to Qemu trunk.

Thanks,
Stefan