DM9000 fix status check fail 0x6d error for trizeps board
PATCH 1/1 DM9000 fix status check fail 0x6d error for trizeps board
An embedded and charset-unspecified text was scrubbed...
Name: dm9000-fix-loading-error-status-check-fail-0x6d.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20080605/38230522/attachment.txt
Ben Warren
AppliedPATCH 1/1 DM9000 fix status check fail 0x6d error for trizeps board
Quoted 14 lines · Remy Bohmer
According to the Application Notes of the DM9000, only the 2 bits 0:1 of the status byte need to be checked to identify a valid packet in the fifo
But, The several different Application Notes do not all speak the same language on these bits. They do not disagree, but only 1 Application Note noted explicitly that only these 2 bits need to be checked. Even the datasheets do not mention anything about these 2 bits.
Because the old code, and the kernel check the whole byte, I left this piece untouched.
However, I tested all board/DM9000[A|E|EP] devices with this 2 bit check, so it should work.
Quoted 10 lines
Notice, that the 2nd iteration through this receive loop (when a 2nd packet is in the fifo) is much shorter now, compared to the older U-boot driver code, so that we can maybe run into a hardware condition now that was never seen before, or maybe was seen very unfrequently.
Additionaly added a cleanup of a stack variable.
Signed-off-by Remy Bohmer <[email protected]>
Applied to net repo. Thanks!
Stefano, please test from the net repo if you can on your Trizeps board.
regards,
Ben
PATCH 1/1 DM9000 fix status check fail 0x6d error for trizeps board
Quoted 4 lines · Ben Warren
Applied to net repo. Thanks!
Stefano, please test from the net repo if you can on your Trizeps board.
Done, it works, thanks.
Kind regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 DM9000 fix status check fail 0x6d error for trizeps board
Quoted 12 lines · Stefano Babic
Quoted 5 lines · Ben Warren
Applied to net repo. Thanks!
Stefano, please test from the net repo if you can on your Trizeps board.
Done, it works, thanks.
Great! Thanks Stefano.
regards,
Ben