Skip to contentSkip to conversation

ext4: return error when calling ext4_ext_split failed

PATCH In review Shen Feng 3 participants 3 messages Jun 11, 2008 – Jun 12, 2008 ext4 file system

lore
Share & tools
lore

Shen Feng

author
#0 lore raw

PATCH 1/1 ext4: return error when calling ext4_ext_split failed

ext4_ext_create_new_leaf must return error when its calling to ext4_ext_split failed.

---
 fs/ext4/extents.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/ext4/extents.c +2 -0
index ff609df..177345d 100644
@@ -981,6 +981,8 @@ repeat:
 		/* if we found index with free entry, then use that
 		 * entry: create all needed subtree and add new leaf */
 		err = ext4_ext_split(handle, inode, path, newext, i);
+		if (err)
+			goto out;
 
 		/* refill path */
 		ext4_ext_drop_refs(path);
Signature · 1 line
1.5.4.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Shen Feng

ext4_ext_create_new_leaf must return error when its calling to ext4_ext_split failed.

Quoted 24 lines
---
 fs/ext4/extents.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/ext4/extents.c +2 -0
index ff609df..177345d 100644
@@ -981,6 +981,8 @@ repeat:
 		/* if we found index with free entry, then use that
 		 * entry: create all needed subtree and add new leaf */
 		err = ext4_ext_split(handle, inode, path, newext, i);
+		if (err)
+			goto out;
 
 		/* refill path */
 		ext4_ext_drop_refs(path);
Signature · 6 lines
1.5.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Shen Feng

I have added to ext4 patch queue

Mingming

Quoted 21 lines · Shen Feng

ext4_ext_create_new_leaf must return error when its calling to ext4_ext_split failed.

---
 fs/ext4/extents.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/ext4/extents.c +2 -0
index ff609df..177345d 100644
@@ -981,6 +981,8 @@ repeat:
 		/* if we found index with free entry, then use that
 		 * entry: create all needed subtree and add new leaf */
 		err = ext4_ext_split(handle, inode, path, newext, i);
+		if (err)
+			goto out;
 
 		/* refill path */
 		ext4_ext_drop_refs(path);