ext4: kill 2 useless magic numbers

PATCH In review Li Zefan 1 participant 1 message Jun 12, 2008 ext4 file system

Share & tools

Li Zefan

author

2008-06-12 01:20 UTC #0 lore raw

PATCH 2/2 ext4: kill 2 useless magic numbers

dx_root_limit() will never return 20, and I can't figure out what 20 stands for. This function has never changed since htree directory indexing was merged.

Similar for dx_node_limit() and the magic 22.

Signed-off-by Li Zefan <[email protected]>

---
 fs/ext4/namei.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

fs/ext4/namei.c +2 -2

index 4315fd7..82c9fe5 100644
@@ -241,13 +241,13 @@ static inline unsigned dx_root_limit (struct inode *dir, unsigned infosize)
 {
 	unsigned entry_space = dir->i_sb->s_blocksize - EXT4_DIR_REC_LEN(1) -
 		EXT4_DIR_REC_LEN(2) - infosize;
-	return 0? 20: entry_space / sizeof(struct dx_entry);
+	return entry_space / sizeof(struct dx_entry);
 }
 
 static inline unsigned dx_node_limit (struct inode *dir)
 {
 	unsigned entry_space = dir->i_sb->s_blocksize - EXT4_DIR_REC_LEN(0);
-	return 0? 22: entry_space / sizeof(struct dx_entry);
+	return entry_space / sizeof(struct dx_entry);
 }
 
 /*

Signature · 1 line

1.5.4.rc3