kobject: should use kobject_put() in kset-example
PATCH 1/1 kobject: should use kobject_put() in kset-example
We should call kobject_put() instead of kfree() if kobject_init_and_add() returns an error, shouldn't we? Don't set up a bad example ;)
Signed-off-by Li Zefan <[email protected]>
--- samples/kobject/kset-example.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
samples/kobject/kset-example.c +1 -1
@@ -211,7 +211,7 @@ static struct foo_obj *create_foo_obj(const char *name)*/ retval =kobject_init_and_add (&foo->kobj, &foo_ktype,NULL ,"%s" , name);if (retval) { -kfree (foo); +kobject_put (&foo->kobj);return NULL ; }
Signature · 1 line
1.5.4.rc3
Quoted 2 lines · Li Zefan
We should call
kobject_put()instead ofkfree()ifkobject_init_and_add()returns an error, shouldn't we? Don't set up a bad example ;)
Ah, good catch, you are right. I'll go add this to my queue, thanks for the patch.
greg k-h