Skip to contentSkip to conversation

sctp: fix error path in sctp_proc_init

PATCH In review Pavel Emelyanov 3 participants 4 messages Jun 17, 2008

Subsystems (3)
Networking Network drivers SCTP protocol
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 sctp: fix error path in sctp_proc_init

After the sctp_remaddr_proc_init failed, the proper rollback is not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/sctp/protocol.c +1 -1
index 23aaffb..98c6a88 100644
@@ -119,7 +119,7 @@ static __init int sctp_proc_init(void)
 	return 0;
 
 out_remaddr_proc_init:
-	sctp_remaddr_proc_exit();
+	sctp_assocs_proc_exit();
 out_assocs_proc_init:
 	sctp_eps_proc_exit();
 out_eps_proc_init:
author
#1 lore raw
Quoted 4 lines · Pavel Emelyanov

After the sctp_remaddr_proc_init failed, the proper rollback is not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.

Signed-off-by Pavel Emelyanov <[email protected]>

Oops, sorry - this is for net-next-2.6.

Acked-by on v1 1/1
#2 lore raw
In reply to Pavel Emelyanov
Quoted 4 lines · Pavel Emelyanov

After the sctp_remaddr_proc_init failed, the proper rollback is not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.

Signed-off-by Pavel Emelyanov <[email protected]>

Ack for net-next-2.6.

Acked-by Vlad Yasevich <[email protected]>

-vlad

Quoted 21 lines

---

net/sctp/protocol.c +1 -2
index 23aaffb..98c6a88 100644
@@ -119,7 +119,7 @@ static __init int sctp_proc_init(void)
 	return 0;
 
 out_remaddr_proc_init:
-	sctp_remaddr_proc_exit();
+	sctp_assocs_proc_exit();
 out_assocs_proc_init:
 	sctp_eps_proc_exit();
 out_eps_proc_init:
--

To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw

From: Vlad Yasevich <[email protected]>
Date: Tue, 17 Jun 2008 09:46:13 -0400

Quoted 9 lines
Quoted 4 lines · Pavel Emelyanov

After the sctp_remaddr_proc_init failed, the proper rollback is not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.

Signed-off-by Pavel Emelyanov <[email protected]>

Ack for net-next-2.6.

Acked-by Vlad Yasevich <[email protected]>

I added this bug during the net-2.6 --> net-next-2.6 merge, sorry :-)

I'll apply this, thanks everyone!