Skip to contentSkip to conversation

sata_uli: hardreset is broken

PATCH Applied Tejun Heo 2 participants 2 messages Jun 21, 2008 – Jun 27, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 sata_uli: hardreset is broken

sata_uli can't do hardresets reliably and lock up. This went unnoticed till now as softreset was the default and hardreset was only used after softreset failed.

Reported by Christian Casteyde in bz#10860.

Signed-off-by Tejun Heo <[email protected]>
Cc Christian Casteyde <[email protected]>
---
 drivers/ata/sata_uli.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ata/sata_uli.c +1 -0
index f277cea..db529b8 100644
@@ -83,6 +83,7 @@ static struct ata_port_operations uli_ops = {
 	.inherits		= &ata_bmdma_port_ops,
 	.scr_read		= uli_scr_read,
 	.scr_write		= uli_scr_write,
+	.hardreset		= ATA_OP_NULL,
 };
 
 static const struct ata_port_info uli_port_info = {
Applied
#1 lore raw
Quoted 11 lines · Tejun Heo

sata_uli can't do hardresets reliably and lock up. This went unnoticed till now as softreset was the default and hardreset was only used after softreset failed.

Reported by Christian Casteyde in bz#10860.

Signed-off-by Tejun Heo <[email protected]>
Cc Christian Casteyde <[email protected]>
---
 drivers/ata/sata_uli.c |    1 +
 1 file changed, 1 insertion(+)

applied