Skip to contentSkip to conversation

fdt: Fix typo in variable name.

PATCH New Detlev Zundel 3 participants 5 messages Jun 20, 2008 – Jul 5, 2008

lore
Share & tools
lore

Detlev Zundel

author
#0 lore raw

PATCH 1/1 fdt: Fix typo in variable name.

Signed-off-by Detlev Zundel <[email protected]>
---
 common/fdt_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
common/fdt_support.c +2 -2
index e58b294..3828228 100644
@@ -63,7 +63,7 @@ int fdt_find_and_setprop(void *fdt, const char *node, const char *prop,
 }
 
 #ifdef CONFIG_OF_STDOUT_VIA_ALIAS
-static int fdt_fixup_stdout(void *fdt, int choosenoff)
+static int fdt_fixup_stdout(void *fdt, int chosenoff)
 {
 	int err = 0;
 #ifdef CONFIG_CONS_INDEX

@@ -82,7 +82,7 @@ static int fdt_fixup_stdout(void *fdt, int choosenoff)
 			err = -FDT_ERR_NOSPACE;
 			if (p) {
 				memcpy(p, path, len);
-				err = fdt_setprop(fdt, choosenoff,
+				err = fdt_setprop(fdt, chosenoff,
 					"linux,stdout-path", p, len);
 				free(p);
 			}
Signature · 1 line
1.5.4.2
#1 lore raw

PATCH 1/1 fdt: Fix typo in variable name.

Quoted 19 lines · Detlev Zundel
Signed-off-by Detlev Zundel <[email protected]>
---
 common/fdt_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
common/fdt_support.c +1 -1
index e58b294..3828228 100644
@@ -63,7 +63,7 @@ int fdt_find_and_setprop(void *fdt, const char *node, const char *prop,
 }
 
 #ifdef CONFIG_OF_STDOUT_VIA_ALIAS
-static int fdt_fixup_stdout(void *fdt, int choosenoff)
+static int fdt_fixup_stdout(void *fdt, int chosenoff)
 {
 	int err = 0;
 #ifdef CONFIG_CONS_INDEX

common/fdt_support.c static int fdt_fixup_stdout(void *fdt, int choosenoff) · line 88

Quoted 8 lines
common/fdt_support.c +1 -1
@@ -82,7 +82,7 @@ static int fdt_fixup_stdout(void *fdt, int choosenoff)
 			err = -FDT_ERR_NOSPACE;
 			if (p) {
 				memcpy(p, path, len);
-				err = fdt_setprop(fdt, choosenoff,
+				err = fdt_setprop(fdt, chosenoff,
 					"linux,stdout-path", p, len);
 				free(p);
 			}

Dear Wolfgang,

Could you apply this directly? I'm on vacation this week and I would appreciate the help.

Thanks,
gvb

Currently at Tower Marine, Douglas, MI, USofA :-)
<http://maps.google.com/maps?f=q&hl=en&geocode=&q=tower+marine,+douglas+michigan&ie=UTF8&ll=42.650501,-86.198988&spn=0.028029,0.068579&t=h&z=14>

author
#2 lore raw

PATCH 1/1 fdt: Fix typo in variable name.

Hi Jerry,

Quoted 5 lines
Quoted 4 lines · Detlev Zundel
Signed-off-by Detlev Zundel <[email protected]>
---
 common/fdt_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[...]

Quoted 4 lines

Dear Wolfgang,

Could you apply this directly? I'm on vacation this week and I would appreciate the help.

I really didn't want to push this, as I do not deem it in any way important. So my original plan was to wait for Wolfgang to pull it in in his usual cycle.

Because of a high-priority bug-fix for 4xx, it now found its way into master anyway, so no need for you to pick it up.

Cheers
Detlev

Signature · 5 lines
0x2B | ~0x2B
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#3 lore raw

PATCH 1/1 fdt: Fix typo in variable name.

Quoted 19 lines · Detlev Zundel

Hi Jerry,

Quoted 5 lines
Quoted 4 lines · Detlev Zundel
Signed-off-by Detlev Zundel <[email protected]>
---
 common/fdt_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[...]

Quoted 4 lines

Dear Wolfgang,

Could you apply this directly? I'm on vacation this week and I would appreciate the help.

I really didn't want to push this, as I do not deem it in any way important. So my original plan was to wait for Wolfgang to pull it in in his usual cycle.

Quoted 5 lines

Because of a high-priority bug-fix for 4xx, it now found its way into master anyway, so no need for you to pick it up.

Cheers
Detlev

Thanks,
gvb

Applied
#4 lore raw

PATCH 1/1 fdt: Fix typo in variable name.

In reply to Detlev Zundel
Quoted 4 lines · In message <[email protected]> you wrote:
Signed-off-by Detlev Zundel <[email protected]>
---
 common/fdt_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Remember, Information is not knowledge;  Knowledge  is  not  Wisdom;
Wisdom is not truth; Truth is not beauty; Beauty is not love; Love is
not music; Music is the best."                          - Frank Zappa