Skip to contentSkip to conversation

drivers/block/pktcdvd.c : avoid useless memset

PATCH New JAILLET Christophe 1 participant 1 message Jun 22, 2008 Block layer

lore
Share & tools
lore

JAILLET Christophe

author
#0 lore raw

PATCH 1/1 drivers/block/pktcdvd.c : avoid useless memset

From: Christophe Jaillet <jaillet.[email protected]>

Hi, here is a patch against linux/drivers/block/pktcdvd.c which :

1) Avoid to 'memset(...,0, ...)' before calling 'init_cdrom_command' because this function already does it.

It is the same patch as the one I sent earlier but the formating should be OK this time.

Signed-off-by Christophe Jaillet <jaillet.[email protected]>

---

drivers/block/pktcdvd.c +0 -2
index 3ba1df9..8369ebc 100644
@@ -2079,7 +2079,6 @@ static noinline_for_stack int pkt_write_caching(struct pktcdvd_device *pd,
 	unsigned char buf[64];
 	int ret;
 
-	memset(buf, 0, sizeof(buf));
 	init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_READ);
 	cgc.sense = &sense;
 	cgc.buflen = pd->mode_offset + 12;

@@ -2126,7 +2125,6 @@ static noinline_for_stack int pkt_get_max_speed(struct pktcdvd_device *pd,
 	unsigned char *cap_buf;
 	int ret, offset;
 
-	memset(buf, 0, sizeof(buf));
 	cap_buf = &buf[sizeof(struct mode_page_header) + pd->mode_offset];
 	init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_UNKNOWN);
 	cgc.sense = &sense;