Skip to contentSkip to conversation

fix system config overwrite @ MPC834x and MPC8313

PATCH New Andre Schwarz 2 participants 2 messages Jun 23, 2008 – Jun 25, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix system config overwrite @ MPC834x and MPC8313

During 83xx setup the "System I/O configuration register high" gets overwritten with user defined value if CFG_SICRH is defined.

Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH must keep their reset value regardless of configuration.

On my board (using RGMII) those bits are set after reset - yet it's unclear where they come from.

The patch keeps both bits on MPC834x and MPC8313.

---

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_mpc834x_sicrh
Url: http://lists.denx.de/pipermail/u-boot/attachments/20080623/6863bc9e/attachment.txt

#1 lore raw

PATCH 1/1 fix system config overwrite @ MPC834x and MPC8313

Quoted 6 lines · On Mon, 23 Jun 2008 11:40:56 +0200 Andre Schwarz…

During 83xx setup the "System I/O configuration register high" gets overwritten with user defined value if CFG_SICRH is defined.

Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH must keep their reset value regardless of configuration.

Quoted 6 lines

On my board (using RGMII) those bits are set after reset - yet it's unclear where they come from.

The patch keeps both bits on MPC834x and MPC8313.

this has been applied after a slight rewrite to not cause the following:

cpu_init.c: In function ?cpu_init_f?:
cpu_init.c:62: warning: unused variable ?tmp_sicrh?

Thanks Andre,

Kim