tc regression?
Subsystems (2)
Hello all.
Ditrib: Gentoo (i hope its not gentoo bug...)
I try update package to "sys-apps/iproute2-2.6.25.20080417" and see that filter can't del filter...
# tc filter show dev eth1 | grep 4:29:d1 filter parent 1: protocol ip pref 5 u32 fh 4:29:d1 order 209 key ht 4 bkt 29 flowid 1:b7aa
# tc filter del dev eth1 parent 1: pref 5 handle 4:29:d1 u32 RTNETLINK answers: Invalid argument We have an error talking to the kernel
after rollback to package"sys-apps/iproute2-2.6.24.20080108" all deleted normal...
kernel 2.4.24
Thanks!
P.S. not any critical for me... only "for intresting" report =)
Quoted 6 lines · Badalian Vyacheslav
Hello all.
Ditrib: Gentoo (i hope its not gentoo bug...)
I try update package to "sys-apps/iproute2-2.6.25.20080417" and see that filter can't del filter...
Quoted 8 lines
# tc filter show dev eth1 | grep 4:29:d1 filter parent 1: protocol ip pref 5 u32 fh 4:29:d1 order 209 key ht 4 bkt 29 flowid 1:b7aa# tc filter del dev eth1 parent 1: pref 5 handle 4:29:d1 u32 RTNETLINK answers: Invalid argument We have an error talking to the kernelafter rollback to package"sys-apps/iproute2-2.6.24.20080108" all deleted normal...
The current iproute version uses "protocol all" by default if its not specified. This is actually only useful for creating new filters, on deletion an unset protocol is treated as wildcard.
Does this patch fix it?
tc/tc_filter.c +4 -1
@@ -54,7 +54,7 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv) } req;struct filter_util *q =NULL ;__u32 prio =0 ; -__u32 protocol =ETH_P_ALL ; +__u32 protocol =0 ;int protocol_set =0 ;char *fhandle =NULL ;char d[16 ];
@@ -72,6 +72,9 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv) req.n.nlmsg_type = cmd; req.t.tcm_family =AF_UNSPEC ; +if (flags ==RTM_NEWTFILTER && flags &NLM_F_CREATE ) + protocol =ETH_P_ALL ; +while (argc >0 ) {if (strcmp (*argv,"dev" ) ==0 ) {NEXT_ARG ();
Quoted 14 lines · Patrick McHardy
Quoted 13 lines · Badalian Vyacheslav
Hello all.
Ditrib: Gentoo (i hope its not gentoo bug...)
I try update package to "sys-apps/iproute2-2.6.25.20080417" and see that filter can't del filter...
# tc filter show dev eth1 | grep 4:29:d1 filter parent 1: protocol ip pref 5 u32 fh 4:29:d1 order 209 key ht 4 bkt 29 flowid 1:b7aa# tc filter del dev eth1 parent 1: pref 5 handle 4:29:d1 u32 RTNETLINK answers: Invalid argument We have an error talking to the kernel
Quoted 7 lines
Quoted 1 line
after rollback to package"sys-apps/iproute2-2.6.24.20080108" all deleted normal...
The current iproute version uses "protocol all" by default if its not specified. This is actually only useful for creating new filters, on deletion an unset protocol is treated as wildcard.
Does this patch fix it?
Oops, buggy patch. This one should work.
tc/tc_filter.c +4 -1
@@ -54,7 +54,7 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv) } req;struct filter_util *q =NULL ;__u32 prio =0 ; -__u32 protocol =ETH_P_ALL ; +__u32 protocol =0 ;int protocol_set =0 ;char *fhandle =NULL ;char d[16 ];
@@ -72,6 +72,9 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv) req.n.nlmsg_type = cmd; req.t.tcm_family =AF_UNSPEC ; +if (cmd ==RTM_NEWTFILTER && flags &NLM_F_CREATE ) + protocol =ETH_P_ALL ; +while (argc >0 ) {if (strcmp (*argv,"dev" ) ==0 ) {NEXT_ARG ();
sorry for long answer.... I will try it tomorrow!...
Quoted 25 lines
Quoted 14 lines · Patrick McHardy
Quoted 13 lines · Badalian Vyacheslav
Hello all.
Ditrib: Gentoo (i hope its not gentoo bug...)
I try update package to "sys-apps/iproute2-2.6.25.20080417" and see that filter can't del filter...
# tc filter show dev eth1 | grep 4:29:d1 filter parent 1: protocol ip pref 5 u32 fh 4:29:d1 order 209 key ht 4 bkt 29 flowid 1:b7aa# tc filter del dev eth1 parent 1: pref 5 handle 4:29:d1 u32 RTNETLINK answers: Invalid argument We have an error talking to the kernelQuoted 7 lines
Quoted 1 line
after rollback to package"sys-apps/iproute2-2.6.24.20080108" all deleted normal...
The current iproute version uses "protocol all" by default if its not specified. This is actually only useful for creating new filters, on deletion an unset protocol is treated as wildcard.
Does this patch fix it?
Oops, buggy patch. This one should work.