Skip to contentSkip to conversation

configure: remove configure warning against not using gcc3

PATCH In review Carlo Marcelo Arenas Belon 2 participants 4 messages Jun 18, 2008 – Jun 29, 2008 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: remove configure warning against not using gcc3

complement ff5396cfeacf74ad9611a35e882ff100b10126aci, removing the warning printed by ./configure --help which recommended at configure time against using gcc4 as it wasn't supported by dyngen.

---
 configure |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
configure +0 -2
index 902e769..72337c9 100755
@@ -28,8 +28,6 @@ usage() {
 
 	Any additional option is given to qemu's configure verbatim; including:
 
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without kvm
 EOF
     cd qemu
     ./configure --help | egrep "enable-|disable-" \
Signature · 1 line
1.5.4.5
#1 lore raw

configure usage() { · line 31

Quoted 12 lines · Carlo Marcelo Arenas Belon

complement ff5396cfeacf74ad9611a35e882ff100b10126aci, removing the warning printed by ./configure --help which recommended at configure time against using gcc4 as it wasn't supported by dyngen.

configure +0 -2
@@ -28,8 +28,6 @@ usage() {
 
 	Any additional option is given to qemu's configure verbatim; including:
 
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without kvm
 

You've orphaned the "including:" above!

Signature · 1 line
error compiling committee.c: too many arguments to function
#2 lore raw
Quoted 7 lines · Avi Kivity
Quoted 6 lines · Carlo Marcelo Arenas Belon
(quoted diff) +0 -0
@@ -28,8 +28,6 @@ usage() {
 
 	Any additional option is given to qemu's configure verbatim; 
 	including:
 
Quoted 6 lines
Quoted 4 lines
(quoted diff) +0 -2
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without 

kvm

You've orphaned the "including:" above!

not sure what you mean by that.

if you think I forgot to remove it, I did not, as my intention was for the "including;" to be part of the message that clearly explained (or so I though) that all options below it were coming from qemu's configure instead as shown by the following snippet of the relevant output from ./configure --help after the patch has been applied to kvm-70:

...
--qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration

Any additional option is given to qemu's configure verbatim; including:

--disable-werror disable compilation abort on warning
--disable-sdl disable SDL
...

if you think that it should had been removed with the message about the additional options, so that all options are now shown together and the fact that they are really from qemu is transparent (which I think might be indeed a better idea) then use instead the attached patch.

Carlo

Quoted 1 line

From 4258e622913a63d6f766374bf17a59524529eae5 Mon Sep 17 00:00:00 2001

From: Carlo Marcelo Arenas Belon <[email protected]>
Date: Thu, 26 Jun 2008 01:03:20 -0700
Subject: [PATCH] configure: remove configure warning against not using gcc3

complement ff5396cfeacf74ad9611a35e882ff100b10126aci, removing the warning printed by ./configure --help which recommended against using gcc4 as it wasn't supported by dyngen.

make all qemu inherited options that could be detected completely transparent as the only one that needed special handling is now the default.

---
 configure |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
configure +0 -5
index 902e769..a158051 100755
@@ -25,11 +25,6 @@ usage() {
 	    --kerneldir=DIR        kernel build directory ($kerneldir)
 	    --qemu-cflags=CFLAGS   CFLAGS to add to qemu configuration
 	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
-
-	Any additional option is given to qemu's configure verbatim; including:
-
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without kvm
 EOF
     cd qemu
     ./configure --help | egrep "enable-|disable-" \
Signature · 1 line
1.5.4.5
#3 lore raw
Quoted 17 lines · Carlo Marcelo Arenas Belon
Quoted 7 lines · Avi Kivity
Quoted 5 lines · Carlo Marcelo Arenas Belon
(quoted diff) +0 -0
@@ -28,8 +28,6 @@ usage() {
 
 	Any additional option is given to qemu's configure verbatim; 
 	including:
 
Quoted 7 lines
Quoted 5 lines
(quoted diff) +0 -2
-	    --disable-gcc-check    don't insist on gcc-3.x
-	                           CAUTION: this will break running without 

kvm

You've orphaned the "including:" above!

Quoted 8 lines

not sure what you mean by that.

if you think I forgot to remove it, I did not, as my intention was for the "including;" to be part of the message that clearly explained (or so I though) that all options below it were coming from qemu's configure instead as shown
by the following snippet of the relevant output from ./configure --help
after the patch has been applied to kvm-70:

You're right, will apply the first patch.

Signature · 1 line
error compiling committee.c: too many arguments to function