Skip to contentSkip to conversation

res_counter: fix building failure

PATCH In review Li Zefan 5 participants 6 messages Jul 2, 2008 – Jul 3, 2008 1 message not in the archive

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 res_counter: fix building failure

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>

---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

kernel/res_counter.c renamed from kernel/res_counter.c.bak +1 -0
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 4 lines · Li Zefan

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>

Thanks - what architecture did it break on?

Paul

Quoted 15 lines

---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 renamed from kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 +1 -0
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {
Acked-by on v1 1/1
#3 lore raw
In reply to Li Zefan
Quoted 4 lines · Li Zefan

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>

Thanks - what architecture did it break on?

Paul

Quoted 15 lines

---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 renamed from kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 +1 -0
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {
author
#4 lore raw
Quoted 10 lines · Paul Menage
Quoted 4 lines · Li Zefan

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>

Thanks - what architecture did it break on?

On my x86_32.

I guess this break has something to do with:

http://marc.info/?l=linux-mm&m=121389282702302&w=2
([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit)

You tested the patch before that patch was accepted by Andrew.

Quoted 19 lines

Paul

Quoted 15 lines

---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 renamed from kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 +1 -0
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {
Acked-by
#5 lore raw
Quoted 9 lines · Li Zefan
Quoted 8 lines · Paul Menage
Quoted 4 lines · Li Zefan

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>

Thanks - what architecture did it break on?

Acked-by Balbir Singh <[email protected]>

CC'ing Andre as well

Signature · 4 lines
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
#6 lore raw
In reply to Li Zefan
Quoted 11 lines · Li Zefan
Quoted 9 lines · Paul Menage
Quoted 4 lines · Li Zefan

kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'

Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>

Thanks - what architecture did it break on?

Quoted 6 lines

On my x86_32.

I guess this break has something to do with:

http://marc.info/?l=linux-mm&m=121389282702302&w=2
([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit)

Exactly, your fix sounds good to me. Thanks.

-Andrea

Quoted 20 lines

You tested the patch before that patch was accepted by Andrew.

Quoted 17 lines

Paul

Quoted 15 lines

---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 renamed from kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 +1 -0
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {