52xx: add missing MSCAN FDT nodes for TQM52xx
Subsystems (2)
PATCH 1/1 52xx: add missing MSCAN FDT nodes for TQM52xx
This patch adds the still missing FDT nodes for the MSCAN devices for the TQM52xx modules.
---arch/powerpc/boot/dts/tqm5200.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
arch/powerpc/boot/dts/tqm5200.dts +0 -0
@@ -70,6 +70,22 @@
fsl,has-wdt; };
+ can@900 {
+ compatible = "fsl,mpc5200-mscan";
+ cell-index = <0>;
+ interrupts = <2 17 0>;
+ interrupt-parent = <&mpc5200_pic>;
+ reg = <0x900 0x80>;
+ };
+
+ can@980 {
+ compatible = "fsl,mpc5200-mscan";
+ cell-index = <1>;
+ interrupts = <2 18 0>;
+ interrupt-parent = <&mpc5200_pic>;
+ reg = <0x980 0x80>;
+ };
+
gpio@b00 {
compatible = "fsl,mpc5200-gpio";
reg = <0xb00 0x40>;Quoted 13 lines · Wolfgang Grandegger
This patch adds the still missing FDT nodes for the MSCAN devices for the TQM52xx modules.
Signed-off-by Wolfgang Grandegger <[email protected]>---
arch/powerpc/boot/dts/tqm5200.dts| 16 ++++++++++++++++1 file changed, 16 insertions(+)Index:
linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
===================================================================
arch/powerpc/boot/dts/tqm5200.dts line 75
Quoted 6 lines
arch/powerpc/boot/dts/tqm5200.dts +3
-0@@ -70,6 +70,22 @@ fsl,has-wdt; }; + can@900 { + compatible = "fsl,mpc5200-mscan"; + cell-index = <0>;
What shared resource are these cell-index values used to index into? Because cell-index is so freqeuntly misunderstood, I strongly recommend putting a comment describing this.
Quoted 21 lines
arch/powerpc/boot/dts/tqm5200.dts +13
-0+ interrupts = <2 17 0>; + interrupt-parent = <&mpc5200_pic>; + reg = <0x900 0x80>; + }; + + can@980 { + compatible = "fsl,mpc5200-mscan"; + cell-index = <1>; + interrupts = <2 18 0>; + interrupt-parent = <&mpc5200_pic>; + reg = <0x980 0x80>; + }; + gpio@b00 { compatible = "fsl,mpc5200-gpio"; reg = <0xb00 0x40>;_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Quoted 17 lines · David Gibson
Quoted 16 lines · Wolfgang Grandegger
This patch adds the still missing FDT nodes for the MSCAN devices for the TQM52xx modules.
Signed-off-by Wolfgang Grandegger <[email protected]>---
arch/powerpc/boot/dts/tqm5200.dts| 16 ++++++++++++++++1 file changed, 16 insertions(+)Index:
linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
===================================================================arch/powerpc/boot/dts/tqm5200.dts +0
-0@@ -70,6 +70,22 @@ fsl,has-wdt; };
Quoted 7 lines
arch/powerpc/boot/dts/tqm5200.dts line 75
Quoted 3 lines
arch/powerpc/boot/dts/tqm5200.dts +3
-0+ can@900 { + compatible = "fsl,mpc5200-mscan"; + cell-index = <0>;What shared resource are these cell-index values used to index into? Because cell-index is so freqeuntly misunderstood, I strongly recommend putting a comment describing this.
This is still my fault. The lite5200.dts which everyone uses as the example to go by for 5200 board ports still has it, so everyone just copies it. I'll look at fixing all of them up.
g.
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.