Skip to contentSkip to conversation

make section names compatible with -ffunction-sections -fdata-sections: v850

PATCH In review Denys Vlasenko 5 participants 7 messages Jul 1, 2008 – Jul 3, 2008 Generic include/asm header files

lore
Share & tools
lore

Denys Vlasenko

author
#0 lore raw

PATCH 21/23 make section names compatible with -ffunction-sections -fdata-sections: v850

The purpose of this patch is to make kernel buildable with "gcc -ffunction-sections -fdata-sections". This patch fixes v850 architecture.

Signed-off-by Denys Vlasenko <[email protected]>

--
vda

arch/v850/kernel/init_task.c +1 -1
@@ -44,5 +44,5 @@
  * "init_task" linker map entry.
  */
 union thread_union init_thread_union 
-	__attribute__((__section__(".data.init_task"))) =
+	__attribute__((__section__(".init_task.data"))) =
 		{ INIT_THREAD_INFO(init_task) };
arch/v850/kernel/vmlinux.lds.S +9 -9
@@ -95,8 +95,8 @@
 		TEXT_TEXT						      \
 		SCHED_TEXT						      \
 			*(.exit.text)	/* 2.5 convention */		      \
-			*(.text.exit)	/* 2.4 convention */		      \
-			*(.text.lock)					      \
+			*(.exit.text)	/* 2.4 convention */		      \
+			*(.lock.text)					      \
 			*(.exitcall.exit)				      \
 		__real_etext = . ;	/* There may be data after here.  */  \
 		RODATA_CONTENTS						      \

@@ -115,11 +115,11 @@
 		__sdata = . ;						      \
 		DATA_DATA						      \
 			EXIT_DATA	/* 2.5 convention */		      \
-			*(.data.exit)	/* 2.4 convention */		      \
+			*(.exit.data)	/* 2.4 convention */		      \
 		. = ALIGN (16) ;					      \
-		*(.data.cacheline_aligned)				      \
+		*(.cacheline_aligned.data)				      \
 		. = ALIGN (0x2000) ;					      \
-        	*(.data.init_task)					      \
+        	*(.init_task.data)					      \
 		. = ALIGN (0x2000) ;					      \
 		__edata = . ;
 

@@ -160,8 +160,8 @@
 			INIT_TEXT	/* 2.5 convention */		      \
 			__einittext = .;				      \
 			INIT_DATA					      \
-			*(.text.init)	/* 2.4 convention */		      \
-			*(.data.init)					      \
+			*(.init.text)	/* 2.4 convention */		      \
+			*(.init.data)					      \
 		INITCALL_CONTENTS					      \
 		INITRAMFS_CONTENTS
 

@@ -171,7 +171,7 @@
 		. = ALIGN (4096) ;					      \
 		__init_start = . ;					      \
 			INIT_DATA	/* 2.5 convention */		      \
-			*(.data.init)	/* 2.4 convention */		      \
+			*(.init.data)	/* 2.4 convention */		      \
 		__init_end = . ;					      \
 		. = ALIGN (4096) ;
 

@@ -181,7 +181,7 @@
 			_sinittext = .;					      \
 			INIT_TEXT	/* 2.5 convention */		      \
 			_einittext = .;					      \
-			*(.text.init)	/* 2.4 convention */		      \
+			*(.init.text)	/* 2.4 convention */		      \
 		INITCALL_CONTENTS					      \
 		INITRAMFS_CONTENTS
maintainer
#1 lore raw
Quoted 1 line · Denys Vlasenko

This patch fixes v850 architecture.

For all I know, v850 has been broken and unmaintained for a few years now, didn't someone have a patch to remove it entirely?

	Arnd <><
#2 lore raw
Quoted 6 lines · On Wed, 2 Jul 2008 23:45:38 +0200 Arnd Bergmann <[email protected]> wrote:
Quoted 1 line · Denys Vlasenko

This patch fixes v850 architecture.

For all I know, v850 has been broken and unmaintained for a few years now, didn't someone have a patch to remove it entirely?

yup, it's queued for 2.6.27-rc1.

#3 lore raw
Quoted 10 lines · Andrew Morton
Quoted 5 lines · On Wed, 2 Jul 2008 23:45:38 +0200 Arnd Bergmann <[email protected]> wrote:
Quoted 1 line · Denys Vlasenko

This patch fixes v850 architecture.

For all I know, v850 has been broken and unmaintained for a few years now, didn't someone have a patch to remove it entirely?

yup, it's queued for 2.6.27-rc1.

Same seems to be true for cris btw.

-Andi

maintainer
#4 lore raw
Quoted 1 line · Andi Kleen

Same seems to be true for cris btw.

Cris has seen significant updates in 2.6.25 by its maintainer. It's not a very active port, but skipping updates for one kernel version is on a completely different scale from doing nothing at all for over three years as in the v850 case.

I don't currently see any architecture (other than v850) in a state that justifies removing it entirely.

	Arnd <><
#5 lore raw
Quoted 8 lines · On Thu, 3 Jul 2008 00:17:52 +0200 Arnd Bergmann <[email protected]> wrote:
Quoted 1 line · Andi Kleen

Same seems to be true for cris btw.

Cris has seen significant updates in 2.6.25 by its maintainer. It's not a very active port, but skipping updates for one kernel version is on a completely different scale from doing nothing at all for over three years as in the v850 case.

Also, cris has a tree in linux-next now, so there will be updates in 2.6.27.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#6 lore raw
In reply to Arnd Bergmann
Quoted 4 lines · Arnd Bergmann
Quoted 1 line · Andi Kleen

Same seems to be true for cris btw.

Cris has seen significant updates in 2.6.25 by its maintainer.

Hmm missed that, sorry. It was just last time I looked cris didn't seem to have any updates for a long time.

Quoted 2 lines

It's not a very active port, but skipping updates for one kernel version

It was far longer than that.

-Andi