Skip to contentSkip to conversation

media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

PATCH In review Mylena Angelica 3 participants 3 messages Apr 24 – Apr 28

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

Adjust the formatting of the function call so the line no longer ends with '(', fixing the checkpatch warning in vmem.c

---

Hello!! This is is my first patch,I appreciate any feedback, thanks!

---
 .../media/atomisp/pci/hive_isp_css_common/host/vmem.c     | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem.c +2 -6
index 722b684fbc37..3831092154d1 100644
@@ -38,12 +38,8 @@ inv_subword(hive_uedge w, unsigned int start, unsigned int end)
 #define move_word(target, target_bit, src) move_subword(target, target_bit, src, 0, uedge_bits)
 
 static void
-move_subword(
-    hive_uedge *target,
-    unsigned int target_bit,
-    hive_uedge src,
-    unsigned int src_start,
-    unsigned int src_end)
+move_subword(hive_uedge *target, unsigned int target_bit, hive_uedge src, unsigned int src_start,
+	     unsigned int src_end)
 {
 	unsigned int start_elem = target_bit / uedge_bits;
 	unsigned int start_bit  = target_bit % uedge_bits;
Signature · 1 line
2.39.5
#1 lore raw

On Thu, Apr 23, 2026 at 10:00:08PM -0300, Mylena Angelica wrote:

...

Quoted 1 line

Hello!! This is is my first patch,I appreciate any feedback, thanks!

Please, start reviewing others' patches for the same driver and read other reviews and learn from them first.

I'm not going to repeat what I said already several times on a patches like this over the very same driver (atomisp).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi Mylena,

Thanks for your patch, please see my comments below.

Quoted 8 lines · Andy Shevchenko

On Thu, Apr 23, 2026 at 10:00:08PM -0300, Mylena Angelica wrote:

...

Quoted 1 line

Hello!! This is is my first patch,I appreciate any feedback, thanks!

Please, start reviewing others' patches for the same driver and read other reviews and learn from them first.

fyi, you can check previous reviews on this driver on lore.kernel.org, for instance: https://lore.kernel.org/all/?q=atomisp

Quoted 4 lines

I'm not going to repeat what I said already several times on a patches like this over the very same driver (atomisp).

You can see in the previous reviews a few comments to not fix just a single occurrence of the issue on the driver, but to fix in a set of files or in the entire driver.

This same error occurs multiple times on the same file, and also in the entire driver.

My suggestion is for you to fix all this sort of errors under the folder
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/
otherwise it might become a big commit for a first contribution (unless others think otherwise).

i.e.:

./scripts/checkpatch.pl
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/* | \
grep -a3 "CHECK: Lines should not end with a '('"

I hope this helps.

Regards,
Helen