Skip to contentSkip to conversation

mach-k3: am62*: Fix backup from eMMC boot mode

PATCH In review Judith Mendez 4 participants 4 messages Aug 20, 2025 – Sep 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mach-k3: am62*: Fix backup from eMMC boot mode

Currently logic in spl_mmc_boot_mode only lookes at main devstat to determine the bootmode to return. Thus, when using: 'eMMC boot' as primary boot mode and 'MMCSD boot from eMMC UDA' as backup boot mode, 'eMMC boot' is always selected. Add check for bootindex to determine if ROM boot via backup boot mode and return MMCSD_MODE_FS which is the only supported backup bootmode with eMMC device.

---
 arch/arm/mach-k3/am62ax/am62a7_init.c | 5 +++++
 arch/arm/mach-k3/am62px/am62p5_init.c | 5 +++++
 arch/arm/mach-k3/am62x/am625_init.c   | 5 +++++
 3 files changed, 15 insertions(+)
arch/arm/mach-k3/am62ax/am62a7_init.c +5 -0
index 00173e6836b..48d578e7d6f 100644
@@ -218,6 +218,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
 	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
 			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
 	switch (bootmode) {
 	case BOOT_DEVICE_EMMC:
 		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))
arch/arm/mach-k3/am62px/am62p5_init.c +5 -0
index 44a2d445d24..aebd5200b0d 100644
@@ -264,6 +264,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
 	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
 			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
 	switch (bootmode) {
 	case BOOT_DEVICE_EMMC:
 		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))
arch/arm/mach-k3/am62x/am625_init.c +5 -0
index 8f4ddf59753..14f93ac998f 100644
@@ -305,6 +305,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
 	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
 			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
 	switch (bootmode) {
 	case BOOT_DEVICE_EMMC:
 		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))
Signature · 1 line
2.49.0
Reviewed-by on v2 1/1
#1 lore raw

Hi Judith,

Quoted 9 lines · Judith Mendez

Currently logic in spl_mmc_boot_mode only lookes at main devstat to determine the bootmode to return. Thus, when using: 'eMMC boot' as primary boot mode and 'MMCSD boot from eMMC UDA' as backup boot mode, 'eMMC boot' is always selected. Add check for bootindex to determine if ROM boot via backup boot mode and return MMCSD_MODE_FS which is the only supported backup bootmode with eMMC device.

---

[snip]

Thanks for the patch!

Regards,
Anshul

Reviewed-by on v2 1/1
#2 lore raw
In reply to Judith Mendez
Quoted 52 lines · Judith Mendez

Currently logic in spl_mmc_boot_mode only lookes at main devstat to determine the bootmode to return. Thus, when using: 'eMMC boot' as primary boot mode and 'MMCSD boot from eMMC UDA' as backup boot mode, 'eMMC boot' is always selected. Add check for bootindex to determine if ROM boot via backup boot mode and return MMCSD_MODE_FS which is the only supported backup bootmode with eMMC device.

---
  arch/arm/mach-k3/am62ax/am62a7_init.c | 5 +++++
  arch/arm/mach-k3/am62px/am62p5_init.c | 5 +++++
  arch/arm/mach-k3/am62x/am625_init.c   | 5 +++++
  3 files changed, 15 insertions(+)
arch/arm/mach-k3/am62ax/am62a7_init.c +5 -0
index 00173e6836b..48d578e7d6f 100644
@@ -218,6 +218,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
  	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
  			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
  	switch (bootmode) {
  	case BOOT_DEVICE_EMMC:
  		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))
arch/arm/mach-k3/am62px/am62p5_init.c +5 -0
index 44a2d445d24..aebd5200b0d 100644
@@ -264,6 +264,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
  	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
  			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
  	switch (bootmode) {
  	case BOOT_DEVICE_EMMC:
  		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))
arch/arm/mach-k3/am62x/am625_init.c +0 -0
index 8f4ddf59753..14f93ac998f 100644
@@ -305,6 +305,11 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
  	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>

arch/arm/mach-k3/am62x/am625_init.c u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device) · line 315

Quoted 10 lines
arch/arm/mach-k3/am62x/am625_init.c +5 -0
  			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
+	if (bootindex != K3_PRIMARY_BOOTMODE) {
+		pr_alert("Fallback to backup bootmode MMCSD_MODE_FS\n");
+		return MMCSD_MODE_FS;
+	}
+
  	switch (bootmode) {
  	case BOOT_DEVICE_EMMC:
  		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT))

Regards,
Moteen

#3 lore raw
In reply to Judith Mendez
Quoted 8 lines · Judith Mendez

Currently logic in spl_mmc_boot_mode only lookes at main devstat to determine the bootmode to return. Thus, when using: 'eMMC boot' as primary boot mode and 'MMCSD boot from eMMC UDA' as backup boot mode, 'eMMC boot' is always selected. Add check for bootindex to determine if ROM boot via backup boot mode and return MMCSD_MODE_FS which is the only supported backup bootmode with eMMC device.

[...]

Applied to u-boot/next, thanks!

[1/1] mach-k3: am62*: Fix backup from eMMC boot mode

      commit: 6fd45dd488f9605e2f634c7e5da4ac2925c118c8
Signature · 1 line
Tom