TQMA31: add new board with i.MX31 processor
A message that is not in the archive (sent off-list or not yet received): mailman.707077.1215511129.5026.u-boot-users@lists.sourceforge.net
PATCH v2 4/10 TQMA31: add new board with i.MX31 processor
Hello Jens,
one comment to your patch:
Quoted 7 lines · Jens Gehrlein
Signed-off-by Jens Gehrlein <[email protected]>---
Fixed two bugs:
a) added NFS mount option "rw" to default environment
b) added prefix $(obj) in front of .depend inMakefile. Thank you Magnus for catching that.
[...]
Review
Quoted 12 lines
(quoted diff) +11
-0+ +/******************************************************************************* + * Environment + ******************************************************************************/ + +#define CONFIG_BOOTDELAY 4 + +/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121
Please delete this block. We do not accept such settings in default config files.
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v2 4/10 TQMA31: add new board with i.MX31 processor
Hi Heiko,
Quoted 14 lines · Heiko Schocher
Hello Jens,
one comment to your patch:
Quoted 7 lines · Jens Gehrlein
Signed-off-by Jens Gehrlein <[email protected]>---
Fixed two bugs:
a) added NFS mount option "rw" to default environment
b) added prefix $(obj) in front of .depend inMakefile. Thank you Magnus for catching that.[...]
Quoted 14 lines
Review
Quoted 12 lines
(quoted diff) +11
-0+ +/******************************************************************************* + * Environment + ******************************************************************************/ + +#define CONFIG_BOOTDELAY 4 + +/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121Please delete this block. We do not accept such settings in default config files.
To understand you properly: do you mean the defines for netmask, ipaddr and serverip, i.e. bootdelay and headerline are okay? I ask, because you quoted the upper lines, too.
Kind regards,
Jens
PATCH v2 4/10 TQMA31: add new board with i.MX31 processor
Hello Jens,
Quoted 34 lines · Jens Gehrlein
Quoted 22 lines · Heiko Schocher
Hello Jens,
one comment to your patch:
Quoted 8 lines · Jens Gehrlein
Signed-off-by Jens Gehrlein <[email protected]>---
Fixed two bugs:
a) added NFS mount option "rw" to default environment
b) added prefix $(obj) in front of .depend inMakefile. Thank you Magnus for catching that.[...]
Quoted 7 lines
(quoted diff) +4
-0+ +/******************************************************************************* + * Environment +******************************************************************************/
Quoted 10 lines
Review
Quoted 8 lines
(quoted diff) +7
-0+ +#define CONFIG_BOOTDELAY 4 + +/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR 172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121Please delete this block. We do not accept such settings in default config files.
Quoted 3 lines
To understand you properly: do you mean the defines for netmask, ipaddr and serverip, i.e. bootdelay and headerline are okay? I ask, because you quoted the upper lines, too.
Yes, I only meant netmask, ipaddr and serverip.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany