Skip to contentSkip to conversation

scsi_dh patchset fixes

PATCH In review Hannes Reinecke 2 participants 3 messages Jul 4, 2008 – Jul 9, 2008 SCSI

lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

cover scsi_dh patchset fixes

Hi James,

these patches just fix the suggestions made by you and Mike C.
- Check the return code from try_module_get()
- Use GFP_ATOMIC in the IO path

Patches apply on top of my previous patchset for the scsi_dh fixes.

Please apply.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 5 lines · Hannes Reinecke

Hi James,

these patches just fix the suggestions made by you and Mike C.
- Check the return code from try_module_get()
- Use GFP_ATOMIC in the IO path

I thought the final agreement was that these should be GFP_NOIO?

Quoted 1 line

Patches apply on top of my previous patchset for the scsi_dh fixes.

Could you not do this? The GFP_KERNEL will spit might sleep warnings on certain configs and the try_module_get could cause an oops on removal. Either of these might confuse a bisection search if it accidentally landed in them. In general, for unapplied patches with identified bugs, the patches should be fixed before applying.

Thanks,

James

author
#2 lore raw

Hi James,

Quoted 9 lines · James Bottomley
Quoted 5 lines · Hannes Reinecke

Hi James,

these patches just fix the suggestions made by you and Mike C.
- Check the return code from try_module_get()
- Use GFP_ATOMIC in the IO path

I thought the final agreement was that these should be GFP_NOIO?

Ok, will do so.

Quoted 8 lines
Quoted 1 line

Patches apply on top of my previous patchset for the scsi_dh fixes.

Could you not do this? The GFP_KERNEL will spit might sleep warnings on certain configs and the try_module_get could cause an oops on removal. Either of these might confuse a bisection search if it accidentally landed in them. In general, for unapplied patches with identified bugs, the patches should be fixed before applying.

Whatever you say :-)
I'll redo the patchset.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html