Skip to contentSkip to conversation

Fix copper/fiber auto-selection for 88e1111

PATCH In review Wang Jian 2 participants 2 messages Jul 10, 2008 – Jul 14, 2008

Subsystems (2)
lore
Share & tools
lore

Wang Jian

author
#0 lore raw

PATCH 1/2 Fix copper/fiber auto-selection for 88e1111

The 27.15 bit (MII_M1111_HWCFG_FIBER_COPPER_AUTO) is disable bit. When set to 1, copper/fiber auto selection is disabled. The current code to enable but actually disable auto selection.

---
 drivers/net/phy/marvell.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/phy/marvell.c +0 -0
index 32a8503..737512c 100644
@@ -162,7 +162,7 @@ static int m88e1111_config_init(struct phy_device

*phydev)

/* Enable Fiber/Copper auto selection */ temp = phy_read(phydev, MII_M1111_PHY_EXT_SR);
- temp |= MII_M1111_HWCFG_FIBER_COPPER_AUTO;
+ temp &= ~MII_M1111_HWCFG_FIBER_COPPER_AUTO;
phy_write(phydev, MII_M1111_PHY_EXT_SR, temp);

temp = phy_read(phydev, MII_BMCR);

Signature · 1 line
1.5.5.4
#1 lore raw
Quoted 8 lines · Wang Jian

The 27.15 bit (MII_M1111_HWCFG_FIBER_COPPER_AUTO) is disable bit. When set to 1, copper/fiber auto selection is disabled. The current code to enable but actually disable auto selection.

---
drivers/net/phy/marvell.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

These should really get cc'd to the netdev list.

- k