Skip to contentSkip to conversation

Fix 88e1111 copper/fiber selection in RGMII mode

PATCH In review Wang Jian 1 participant 1 message Jul 10, 2008

Subsystems (2)
lore
Share & tools
lore

Wang Jian

author
#0 lore raw

PATCH 2/2 Fix 88e1111 copper/fiber selection in RGMII mode

MII_M1111_HWCFG_FIBER_COPPER_RES is a bit of MII_M1111_PHY_EXT_SR, not MII_M1111_PHY_EXT_CR.

---
 drivers/net/phy/marvell.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/net/phy/marvell.c +0 -0
index 737512c..4aa5479 100644
@@ -158,7 +158,6 @@ static int m88e1111_config_init(struct phy_device

*phydev)
{
int err;
int temp;
- int mode;

/* Enable Fiber/Copper auto selection */
temp = phy_read(phydev, MII_M1111_PHY_EXT_SR);
@@ -198,9 +197,7 @@ static int m88e1111_config_init(struct phy_device *phydev)

temp &= ~(MII_M1111_HWCFG_MODE_MASK);

- mode = phy_read(phydev, MII_M1111_PHY_EXT_CR);
-
- if (mode & MII_M1111_HWCFG_FIBER_COPPER_RES)
+ if (temp & MII_M1111_HWCFG_FIBER_COPPER_RES)
temp |= MII_M1111_HWCFG_MODE_FIBER_RGMII;
else
temp |= MII_M1111_HWCFG_MODE_COPPER_RGMII;

Signature · 1 line
1.5.5.4