Skip to contentSkip to conversation

ASoC: codec registers with more than 16 bits.

DISCUSSION Daniel Ribeiro 2 participants 2 messages Jul 17, 2008

lore
Share & tools
lore
#0 lore raw

Hello alsa experts,

I am working on a ASoC codec driver for the Motorola PCAP2
ASIC for the OpenEZX project, and i am having some trouble...

PCAP2 has 25 bits registers, I access these registers via
32 bits SPI writes/reads, but soc-core/soc-dapm expects codec registers values to fit on 'unsigned short' vars.

Is there any reason to this limit? I am currently faking
the registers to always fit 16 bits, but this looks ugly.

Would a patch to soc-core/dapm to extend this limit to
32 bits registers be accepted?

Thanks!

Signature · 1 line
Daniel Ribeiro
#1 lore raw
Quoted 2 lines · Daniel Ribeiro

Is there any reason to this limit? I am currently faking
the registers to always fit 16 bits, but this looks ugly.

No reason other than nobody needed it before.

Quoted 2 lines

Would a patch to soc-core/dapm to extend this limit to
32 bits registers be accepted?

Of course - that'd be great, but note that all the codec drivers will need updating to match the API change.