Change 'act_mask' to 'cat_mask'

PATCH In review Alan D. Brunelle 1 participant 2 messages Jul 21, 2008 Block layer

lore

Share & tools

lore

Alan D. Brunelle

author

2008-07-21 13:49 UTC #0 lore raw

PATCH 1/1 Change 'act_mask' to 'cat_mask'

Hi Jens -

It turns out the 'action mask' isn't quite right: in these usages its really a category mask. I'm looking into adding real action masks - so that one can reduce traces to specific actions (in the particular near-term need it's sleeprq & getrq really - I'm sure there are other usages as well).

Here's the kernel side patch, next will be the application side patch.

From 0f57f620c490f9bbd3372e1a80829edc70929c44 Mon Sep 17 00:00:00 2001
From: Alan D. Brunelle <[email protected]>
Date: Mon, 21 Jul 2008 09:38:37 -0400
Subject: [PATCH] Changed act_mask to cat_mask - Categories, not actions

The mask actually pertains to /categories/ of actions - multiple actions are encompassed w/in one category. This leads to confusion at the user application level: one would /like/ to discriminate based upon individual actions, we only support categories (for the moment).

This is preparatory to building a true action mask.

Signed-off-by Alan D. Brunelle <[email protected]>

---
 block/blktrace.c             |    8 ++++----
 block/compat_ioctl.c         |    2 +-
 include/linux/blktrace_api.h |    4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

block/blktrace.c +4 -4

index eb9651c..d2d639a 100644
@@ -96,7 +96,7 @@ EXPORT_SYMBOL_GPL(__trace_note_message);
 static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
 			 pid_t pid)
 {
-	if (((bt->act_mask << BLK_TC_SHIFT) & what) == 0)
+	if (((bt->cat_mask << BLK_TC_SHIFT) & what) == 0)
 		return 1;
 	if (sector < bt->start_lba || sector > bt->end_lba)
 		return 1;

@@ -428,9 +428,9 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
 	if (!bt->rchan)
 		goto err;
 
-	bt->act_mask = buts->act_mask;
-	if (!bt->act_mask)
-		bt->act_mask = (u16) -1;
+	bt->cat_mask = buts->cat_mask;
+	if (!bt->cat_mask)
+		bt->cat_mask = (u16) -1;
 
 	bt->start_lba = buts->start_lba;
 	bt->end_lba = buts->end_lba;

block/compat_ioctl.c +1 -1

index c23177e..a67ba50 100644
@@ -558,7 +558,7 @@ static int compat_blk_trace_setup(struct block_device *bdev, char __user *arg)
 	bdevname(bdev, b);
 
 	buts = (struct blk_user_trace_setup) {
-		.act_mask = cbuts.act_mask,
+		.cat_mask = cbuts.cat_mask,
 		.buf_size = cbuts.buf_size,
 		.buf_nr = cbuts.buf_nr,
 		.start_lba = cbuts.start_lba,

include/linux/blktrace_api.h +2 -2

index d084b8d..f4c2e12 100644
@@ -122,7 +122,7 @@ struct blk_trace {
 	struct rchan *rchan;
 	unsigned long *sequence;
 	unsigned char *msg_data;
-	u16 act_mask;
+	u16 cat_mask;
 	u64 start_lba;
 	u64 end_lba;
 	u32 pid;

@@ -138,7 +138,7 @@ struct blk_trace {
  */
 struct blk_user_trace_setup {
 	char name[BDEVNAME_SIZE];	/* output */
-	u16 act_mask;			/* input */
+	u16 cat_mask;			/* input */
 	u32 buf_size;			/* input */
 	u32 buf_nr;			/* input */
 	u64 start_lba;

Signature · 1 line

1.5.4.3

Alan D. Brunelle

author

2008-07-21 14:13 UTC #1 lore raw

<sigh> patch missed compat_ioctl structure fix...

From bbc85dabee6ed5e7af53bacdf2d5e7910d1e512a Mon Sep 17 00:00:00 2001
From: Alan D. Brunelle <[email protected]>
Date: Mon, 21 Jul 2008 10:11:34 -0400
Subject: [PATCH] Changed act_mask to cat_mask - Categories, not actions

This is preparatory to building a true action mask.

Signed-off-by Alan D. Brunelle <[email protected]>

---
 block/blktrace.c             |    8 ++++----
 block/compat_ioctl.c         |    4 ++--
 include/linux/blktrace_api.h |    4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

block/blktrace.c +4 -4

index eb9651c..d2d639a 100644
@@ -96,7 +96,7 @@ EXPORT_SYMBOL_GPL(__trace_note_message);
 static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
 			 pid_t pid)
 {
-	if (((bt->act_mask << BLK_TC_SHIFT) & what) == 0)
+	if (((bt->cat_mask << BLK_TC_SHIFT) & what) == 0)
 		return 1;
 	if (sector < bt->start_lba || sector > bt->end_lba)
 		return 1;

@@ -428,9 +428,9 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
 	if (!bt->rchan)
 		goto err;
 
-	bt->act_mask = buts->act_mask;
-	if (!bt->act_mask)
-		bt->act_mask = (u16) -1;
+	bt->cat_mask = buts->cat_mask;
+	if (!bt->cat_mask)
+		bt->cat_mask = (u16) -1;
 
 	bt->start_lba = buts->start_lba;
 	bt->end_lba = buts->end_lba;

block/compat_ioctl.c +2 -2

index c23177e..ef0cc68 100644
@@ -531,7 +531,7 @@ out:
 
 struct compat_blk_user_trace_setup {
 	char name[32];
-	u16 act_mask;
+	u16 cat_mask;
 	u32 buf_size;
 	u32 buf_nr;
 	compat_u64 start_lba;

@@ -558,7 +558,7 @@ static int compat_blk_trace_setup(struct block_device *bdev, char __user *arg)
 	bdevname(bdev, b);
 
 	buts = (struct blk_user_trace_setup) {
-		.act_mask = cbuts.act_mask,
+		.cat_mask = cbuts.cat_mask,
 		.buf_size = cbuts.buf_size,
 		.buf_nr = cbuts.buf_nr,
 		.start_lba = cbuts.start_lba,

include/linux/blktrace_api.h +2 -2

index d084b8d..f4c2e12 100644
@@ -122,7 +122,7 @@ struct blk_trace {
 	struct rchan *rchan;
 	unsigned long *sequence;
 	unsigned char *msg_data;
-	u16 act_mask;
+	u16 cat_mask;
 	u64 start_lba;
 	u64 end_lba;
 	u32 pid;

@@ -138,7 +138,7 @@ struct blk_trace {
  */
 struct blk_user_trace_setup {
 	char name[BDEVNAME_SIZE];	/* output */
-	u16 act_mask;			/* input */
+	u16 cat_mask;			/* input */
 	u32 buf_size;			/* input */
 	u32 buf_nr;			/* input */
 	u64 start_lba;

Signature · 1 line

1.5.4.3