Skip to contentSkip to conversation

platform/x86: alienware-wmi: Fix zone attribute declaration

PATCH In review Kurt Borja 2 participants 2 messages Jan 14, 2025 – Jan 15, 2025

Subsystems (3)
lore
Share & tools
lore

Kurt Borja

author maintainer
#0 lore raw

PATCH 1/1 platform/x86: alienware-wmi: Fix zone attribute declaration

Statically declare zone* attributes.

Fixes 7c605f6460e8 ("platform/x86: alienware-wmi: Improve rgb-zones group creation")
---
 drivers/platform/x86/dell/alienware-wmi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/platform/x86/dell/alienware-wmi.c +4 -4
index b4b43f3e3fd9..d7f577e0d146 100644
@@ -518,7 +518,7 @@ static ssize_t zone00_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 0);
 }
 
-DEVICE_ATTR_RW(zone00);
+static DEVICE_ATTR_RW(zone00);
 
 static ssize_t zone01_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -532,7 +532,7 @@ static ssize_t zone01_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 1);
 }
 
-DEVICE_ATTR_RW(zone01);
+static DEVICE_ATTR_RW(zone01);
 
 static ssize_t zone02_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -546,7 +546,7 @@ static ssize_t zone02_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 2);
 }
 
-DEVICE_ATTR_RW(zone02);
+static DEVICE_ATTR_RW(zone02);
 
 static ssize_t zone03_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -560,7 +560,7 @@ static ssize_t zone03_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 3);
 }
 
-DEVICE_ATTR_RW(zone03);
+static DEVICE_ATTR_RW(zone03);
 
 /*
  * Lighting control state device attribute (Global)

base-commit: 58126788aa7726c0e91de6b25e6e332fa06089ab

Signature · 1 line
2.48.0
maintainer
#1 lore raw
Quoted 51 lines · Kurt Borja

Statically declare zone* attributes.

Fixes 7c605f6460e8 ("platform/x86: alienware-wmi: Improve rgb-zones group creation")
---
 drivers/platform/x86/dell/alienware-wmi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/platform/x86/dell/alienware-wmi.c +4 -4
index b4b43f3e3fd9..d7f577e0d146 100644
@@ -518,7 +518,7 @@ static ssize_t zone00_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 0);
 }
 
-DEVICE_ATTR_RW(zone00);
+static DEVICE_ATTR_RW(zone00);
 
 static ssize_t zone01_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -532,7 +532,7 @@ static ssize_t zone01_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 1);
 }
 
-DEVICE_ATTR_RW(zone01);
+static DEVICE_ATTR_RW(zone01);
 
 static ssize_t zone02_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -546,7 +546,7 @@ static ssize_t zone02_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 2);
 }
 
-DEVICE_ATTR_RW(zone02);
+static DEVICE_ATTR_RW(zone02);
 
 static ssize_t zone03_show(struct device *dev, struct device_attribute *attr,
 			   char *buf)
@@ -560,7 +560,7 @@ static ssize_t zone03_store(struct device *dev, struct device_attribute *attr,
 	return zone_store(dev, attr, buf, count, 3);
 }
 
-DEVICE_ATTR_RW(zone03);
+static DEVICE_ATTR_RW(zone03);
 
 /*
  * Lighting control state device attribute (Global)
Quoted 2 lines

base-commit: 58126788aa7726c0e91de6b25e6e332fa06089ab

Thanks. I've folded this into the original commit in the review-ilpo-next branch.

Signature · 1 line
 i.