Skip to contentSkip to conversation

Patches used to add platform specific data for Intel Stratix10 platform

PATCH In review Meng Li 2 participants 12 messages Jul 19, 2023

Subsystems (4)
lore
Share & tools
lore

Meng Li

author
#0 lore raw

cover Patches used to add platform specific data for Intel Stratix10 platform

*** BLURB HERE ***

Meng Li (3):
usb: dwc2: Add platform specific data for Intel Stratix10 platform
arm64: dts: agilex: use the compatible "intel,socfpga-agilex-hsotg"
dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

 Documentation/devicetree/bindings/usb/dwc2.yaml   | 1 +
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
 drivers/usb/dwc2/params.c                         | 2 ++
 3 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 1/3 usb: dwc2: Add platform specific data for Intel Stratix10 platform

Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on the Stratix platform also does not support clock-gating. So, refer to commit 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's Agilex"), add platform specific data for Intel Stratix10 platform.

---
 drivers/usb/dwc2/params.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc2/params.c +2 -0
index 8eab5f38b110..3d085ae1ecd8 100644
@@ -267,6 +267,8 @@ const struct of_device_id dwc2_of_match_table[] = {
 	  .data = dwc2_set_stm32mp15_hsotg_params },
 	{ .compatible = "intel,socfpga-agilex-hsotg",
 	  .data = dwc2_set_socfpga_agilex_params },
+	{ .compatible = "intel,socfpga-stratix10-hsotg",
+	  .data = dwc2_set_socfpga_agilex_params },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform

Quoted 15 lines · Meng Li

Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on the Stratix platform also does not support clock-gating. So, refer to commit 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's Agilex"), add platform specific data for Intel Stratix10 platform.

---
 drivers/usb/dwc2/params.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc2/params.c +0 -0
index 8eab5f38b110..3d085ae1ecd8 100644

drivers/usb/dwc2/params.c const struct of_device_id dwc2_of_match_table[] = { · line 271

Quoted 5 lines
drivers/usb/dwc2/params.c +2 -0
@@ -267,6 +267,8 @@ const struct of_device_id dwc2_of_match_table[] = {
 	  .data = dwc2_set_stm32mp15_hsotg_params },
 	{ .compatible = "intel,socfpga-agilex-hsotg",
 	  .data = dwc2_set_socfpga_agilex_params },
+	{ .compatible = "intel,socfpga-stratix10-hsotg",
+	  .data = dwc2_set_socfpga_agilex_params },

NAK. I already wrote why.

Best regards,
Krzysztof

author
#3 lore raw

RE: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform

Quoted 28 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:40 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 10 lines · Meng Li

Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on the Stratix platform also does not support clock-gating. So, refer to commit 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's Agilex"), add platform specific data for Intel Stratix10 platform.

---
 drivers/usb/dwc2/params.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

drivers/usb/dwc2/params.c const struct of_device_id dwc2_of_match_table[] = { · line 271

Quoted 10 lines
drivers/usb/dwc2/params.c +2 -0
index 8eab5f38b110..3d085ae1ecd8 100644
@@ -267,6 +267,8 @@ const struct of_device_id dwc2_of_match_table[] = {
        .data = dwc2_set_stm32mp15_hsotg_params },
      { .compatible = "intel,socfpga-agilex-hsotg",
        .data = dwc2_set_socfpga_agilex_params },
+     { .compatible = "intel,socfpga-stratix10-hsotg",
+       .data = dwc2_set_socfpga_agilex_params },

NAK. I already wrote why.

If I don't add the SoC specific compatible entry, how I use to the specific data on Stratix10 platform. If you think the new SoC specific compatible entry is not necessary, the patch2 also has issue.

Thanks,
Limeng

Quoted 3 lines

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform

Quoted 41 lines · Meng
Quoted 28 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:40 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 10 lines · Meng Li

Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on the Stratix platform also does not support clock-gating. So, refer to commit 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's Agilex"), add platform specific data for Intel Stratix10 platform.

---
 drivers/usb/dwc2/params.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

drivers/usb/dwc2/params.c const struct of_device_id dwc2_of_match_table[] = { · line 271

Quoted 10 lines
drivers/usb/dwc2/params.c +2 -0
index 8eab5f38b110..3d085ae1ecd8 100644
@@ -267,6 +267,8 @@ const struct of_device_id dwc2_of_match_table[] = {
        .data = dwc2_set_stm32mp15_hsotg_params },
      { .compatible = "intel,socfpga-agilex-hsotg",
        .data = dwc2_set_socfpga_agilex_params },
+     { .compatible = "intel,socfpga-stratix10-hsotg",
+       .data = dwc2_set_socfpga_agilex_params },

NAK. I already wrote why.

Quoted 1 line

If I don't add the SoC specific compatible entry, how I use to the specific data on Stratix10 platform.

You do not have match data specific to Stratix10. I explained already that I expect them to be compatible. I gave you example how it is done. What is unclear in that example?

Quoted 1 line

If you think the new SoC specific compatible entry is not necessary, the patch2 also has issue.

Best regards,
Krzysztof

author
#5 lore raw

PATCH 2/3 arm64: dts: agilex: use the compatible "intel,socfpga-agilex-hsotg"

In reply to Meng Li

The DWC2 USB controller on the Stratix10 platform does not support clock gating, so use the chip specific "intel,socfpga-stratix10-hsotg" compatible.

---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +2 -2
index ea788a920eab..435f1cc52af3 100644
@@ -490,7 +490,7 @@ usbphy0: usbphy@0 {
 		};
 
 		usb0: usb@ffb00000 {
-			compatible = "snps,dwc2";
+			compatible = "intel,socfpga-stratix10-hsotg", "snps,dwc2";
 			reg = <0xffb00000 0x40000>;
 			interrupts = <0 93 4>;
 			phys = <&usbphy0>;
@@ -504,7 +504,7 @@ usb0: usb@ffb00000 {
 		};
 
 		usb1: usb@ffb40000 {
-			compatible = "snps,dwc2";
+			compatible = "intel,socfpga-stratix10-hsotg", "snps,dwc2";
 			reg = <0xffb40000 0x40000>;
 			interrupts = <0 94 4>;
 			phys = <&usbphy0>;
Signature · 1 line
2.34.1
author
#6 lore raw

PATCH 3/3 dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

In reply to Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg
           - const: snps,dwc2
       - const: amcc,dwc-otg
       - const: apm,apm82181-dwc-otg
Signature · 1 line
2.34.1
#7 lore raw

Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

Quoted 6 lines · Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

Missing changelog, missing versioning. This is v3 or v4.

Documentation/devicetree/bindings/usb/dwc2.yaml properties: · line 54

Quoted 13 lines
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper solution with compatibility.

Best regards,
Krzysztof

author
#8 lore raw

RE: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

Quoted 30 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:39 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 5 lines · Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

Missing changelog, missing versioning. This is v3 or v4.

Quoted 4 lines
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

Documentation/devicetree/bindings/usb/dwc2.yaml properties: · line 54

Quoted 10 lines
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper solution with compatibility.

No. not the same.
I don't understand why SoC specific compatible "intel,socfpga-agilex-hsotg" is able to be added, but the SoC specific compatible "intel,socfpga-stratix10-hsotg" is not allowed.

You said "Where is SoC specific compatible?"
Now, I add the SoC specific compatible "intel,socfpga-stratix10-hsotg", but why it is still not reasonable.

Thanks,
Limeng

Quoted 4 lines

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

Quoted 45 lines · Meng
Quoted 30 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:39 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 5 lines · Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

Missing changelog, missing versioning. This is v3 or v4.

Quoted 4 lines
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

Documentation/devicetree/bindings/usb/dwc2.yaml properties: · line 54

Quoted 10 lines
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper solution with compatibility.

Quoted 5 lines

No. not the same.
I don't understand why SoC specific compatible "intel,socfpga-agilex-hsotg" is able to be added, but the SoC specific compatible "intel,socfpga-stratix10-hsotg" is not allowed.

You said "Where is SoC specific compatible?"
Now, I add the SoC specific compatible "intel,socfpga-stratix10-hsotg", but why it is still not reasonable.

The compatible should be added, but I said they are compatible, so express it. I also gave you example of file which expresses it.

Why that compatible is not allowed alone? Because what we said here many, many times and because the doc I gave you which explains this.

Best regards,
Krzysztof

author
#10 lore raw

RE: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

Quoted 71 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 4:59 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 46 lines · Meng
Quoted 31 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:39 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 5 lines · Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

Missing changelog, missing versioning. This is v3 or v4.

Quoted 4 lines
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

Documentation/devicetree/bindings/usb/dwc2.yaml properties: · line 54

Quoted 10 lines
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper solution with compatibility.

Quoted 2 lines

No. not the same.
I don't understand why SoC specific compatible "intel,socfpga-agilex-hsotg" is

able to be added, but the SoC specific compatible "intel,socfpga-stratix10-hsotg" is not allowed.

Quoted 3 lines

You said "Where is SoC specific compatible?"
Now, I add the SoC specific compatible "intel,socfpga-stratix10-hsotg", but

Quoted 8 lines

why it is still not reasonable.

The compatible should be added, but I said they are compatible, so express it. I also gave you example of file which expresses it.

Why that compatible is not allowed alone? Because what we said here many, many times and because the doc I gave you which explains this.

I had a look the doc ,and refer to rk3128.dtsi and commit 5032b269203287c17064d33c72be1ebf30c04a95. So I think it needs to add " intel,socfpga-stratix10-hsotg" Documentation/devicetree/bindings/usb/dwc2.yaml. But if you think it is not reasonable, could you please show what is your modification for the dwc2.yaml.

Thanks,
Limeng

Quoted 2 lines

Best regards,
Krzysztof

#11 lore raw

Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"

Quoted 76 lines · Meng
Quoted 76 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 4:59 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 46 lines · Meng
Quoted 31 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, July 19, 2023 2:39 PM
To: Li, Meng <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected];
[email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- stratix10-hsotg"

CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.

Quoted 5 lines · Meng Li

Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 implementation, because the Stratix DWC2 implementation does not support clock gating. This compatible is used with generic snps,dwc2.

Missing changelog, missing versioning. This is v3 or v4.

Quoted 4 lines
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

Documentation/devicetree/bindings/usb/dwc2.yaml properties: · line 54

Quoted 10 lines
Documentation/devicetree/bindings/usb/dwc2.yaml +1 -0
index dc4988c0009c..f90094320914 100644
@@ -51,6 +51,7 @@ properties:
               - amlogic,meson-g12a-usb
               - amlogic,meson-a1-usb
               - intel,socfpga-agilex-hsotg
+              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper solution with compatibility.

Quoted 2 lines

No. not the same.
I don't understand why SoC specific compatible "intel,socfpga-agilex-hsotg" is

able to be added, but the SoC specific compatible "intel,socfpga-stratix10-hsotg" is not allowed.

Quoted 3 lines

You said "Where is SoC specific compatible?"
Now, I add the SoC specific compatible "intel,socfpga-stratix10-hsotg", but

why it is still not reasonable.

The compatible should be added, but I said they are compatible, so express it. I also gave you example of file which expresses it.

Quoted 6 lines
Quoted 3 lines

Why that compatible is not allowed alone? Because what we said here many, many times and because the doc I gave you which explains this.

I had a look the doc ,and refer to rk3128.dtsi and commit 5032b269203287c17064d33c72be1ebf30c04a95. So I think it needs to add " intel,socfpga-stratix10-hsotg" Documentation/devicetree/bindings/usb/dwc2.yaml.

Open the DTSI and look at compatibles. Now open the driver and look at the compatibles - surprise, there is no rockchip,rk3128-usb! Now open the binding and look how it is done.

Quoted 1 line

But if you think it is not reasonable, could you please show what is your modification for the dwc2.yaml.

Open the binding - it is already there.

I bet there is someone in Windriver who does Linux and can help here as well, none of existing code is working for you as an example?

Best regards,
Krzysztof