DCCP: Fix to check the sequence number in ICMP message

PATCH Superseded Wei Yongjun 1 participant 1 message Jul 24, 2008 Networking

Share & tools

Wei Yongjun

author

2008-07-24 08:45 UTC #0 lore raw

PATCH 1/4 DCCP: Fix to check the sequence number in ICMP message

The payload of ICMP message is a part of the packet which send by ourself, so check the sequence number must used AWL and AWH, not SWL and SWH.

For example:

     Endpoint A                  Endpoint B

     DATA-ACK       -------->
     (SEQ=X)
                    <--------    ICMP (Fragmentation Needed)
                                 (SEQ=X)

Signed-off-by Wei Yongjun <[email protected]>

net/dccp/ipv4.c +1 -1

diff -Nurp a/net/dccp/ipv4.c b/net/dccp/ipv4.c
@@ -237,7 +237,7 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info)
 	dp = dccp_sk(sk);
 	seq = dccp_hdr_seq(dh);
 	if ((1 << sk->sk_state) & ~(DCCPF_REQUESTING | DCCPF_LISTEN) &&
-	    !between48(seq, dp->dccps_swl, dp->dccps_swh)) {
+	    !between48(seq, dp->dccps_awl, dp->dccps_awh)) {
 		NET_INC_STATS_BH(LINUX_MIB_OUTOFWINDOWICMPS);
 		goto out;
 	}