Skip to contentSkip to conversation

Allow negative offset in command loads

PATCH New Ricardo Ribalda Delgado 3 participants 7 messages Jul 23, 2008 – Aug 18, 2008

Subsystems (2)
Hardware monitoring I2C
lore
Share & tools
lore

Ricardo Ribalda Delgado

author
#0 lore raw

PATCH 1/1 Allow negative offset in command loads

Comand loads only allows positive offset for relocating the .srec files, this patch allows negative offsets

Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 common/cmd_load.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
common/cmd_load.c +4 -4
index 89f6403..ae56543 100644
@@ -53,7 +53,7 @@ static int do_echo = 1;
 #if defined(CONFIG_CMD_LOADS)
 int do_load_serial (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 {
-	ulong offset = 0;
+	long offset = 0;
 	ulong addr;
 	int i;
 	char *env_echo;

@@ -72,7 +72,7 @@ int do_load_serial (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 #ifdef	CFG_LOADS_BAUD_CHANGE
 	if (argc >= 2) {
-		offset = simple_strtoul(argv[1], NULL, 16);
+		offset = simple_strtol(argv[1], NULL, 16);
 	}
 	if (argc == 3) {
 		load_baudrate = (int)simple_strtoul(argv[2], NULL, 10);

@@ -95,7 +95,7 @@ int do_load_serial (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	}
 #else	/* ! CFG_LOADS_BAUD_CHANGE */
 	if (argc == 2) {
-		offset = simple_strtoul(argv[1], NULL, 16);
+		offset = simple_strtol(argv[1], NULL, 16);
 	}
 #endif	/* CFG_LOADS_BAUD_CHANGE */
 

@@ -141,7 +141,7 @@ int do_load_serial (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 }
 
 static ulong
-load_serial (ulong offset)
+load_serial (long offset)
 {
 	char	record[SREC_MAXRECLEN + 1];	/* buffer for one S-Record	*/
 	char	binbuf[SREC_MAXBINLEN];		/* buffer for binary data	*/
Signature · 1 line
1.5.6.3
author
#1 lore raw

PATCH 1/1 I2C EEPROM simulator (Resubmit)

This driver provides access to a simulated i2c eeprom. This simulated eeprom could be very useful in boards with ddr2 memories and no i2c interfaces.

Using this driver the user can simulate a spd eeprom of a ddr2 memory and use the ddr2 auto config.

User can use the macros CONFIG_EEPROM_SIMUL_LEN and CONFIG_EEPROM_SIMUL_DATA to define the content of the simulated eeprom

Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 drivers/i2c/Makefile       |    1 +
 drivers/i2c/eeprom_simul.c |   68 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/eeprom_simul.c
drivers/i2c/Makefile +1 -0
index 534c015..2aeabe5 100644
@@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
 COBJS-y += omap24xx_i2c.o
 COBJS-y += tsi108_i2c.o
 COBJS-y += mxc_i2c.o
+COBJS-$(CONFIG_EEPROM_SIMUL) += eeprom_simul.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/i2c/eeprom_simul.c new file +68 -0

68 lines not on this page · raw message

Signature · 1 line
1.5.6.3
author
#2 lore raw

PATCH 1/1 I2C Monitor chip ADT7460 support (Resubmit)

Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 drivers/hwmon/Makefile  |    1 +
 drivers/hwmon/adt7460.c |   83 +++++++++++++++++++++++++++++++++++++++++++++++
 include/dtt.h           |    3 +-
 3 files changed, 86 insertions(+), 1 deletions(-)
 create mode 100644 drivers/hwmon/adt7460.c
drivers/hwmon/Makefile +1 -0
index f09f145..7342b91 100644
@@ -37,6 +37,7 @@ COBJS-$(CONFIG_DTT_DS1775) += ds1775.o
 COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-$(CONFIG_DTT_LM75) += lm75.o
 COBJS-$(CONFIG_DTT_LM81) += lm81.o
+COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/hwmon/adt7460.c new file +83 -0

83 lines not on this page · raw message

include/dtt.h +2 -1
index 34053d1..ce0fdfa 100644
@@ -32,7 +32,8 @@
     defined(CONFIG_DTT_DS1775) || \
     defined(CONFIG_DTT_LM81) || \
     defined(CONFIG_DTT_ADM1021) || \
-    defined(CONFIG_DTT_LM73)
+    defined(CONFIG_DTT_LM73) || \
+    defined(CONFIG_DTT_ADT7460)
 
 #define CONFIG_DTT				/* We have a DTT */
Signature · 1 line
1.5.6.3
#3 lore raw

PATCH 1/1 I2C Monitor chip ADT7460 support (Resubmit)

Dear Ricardo Ribalda Delgado,

Quoted 7 lines · In message <[email protected]> you wrote:
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 drivers/hwmon/Makefile  |    1 +
 drivers/hwmon/adt7460.c |   83 +++++++++++++++++++++++++++++++++++++++++++++++
 include/dtt.h           |    3 +-
 3 files changed, 86 insertions(+), 1 deletions(-)
 create mode 100644 drivers/hwmon/adt7460.c

Applies, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you spell "onomatopoeia"?
A: The way it sounds.
#4 lore raw

PATCH 1/1 I2C EEPROM simulator (Resubmit)

In reply to Ricardo Ribalda Delgado

still coding style issues.

M

Quoted 104 lines

This driver provides access to a simulated i2c eeprom. This simulated eeprom could be very useful in boards with ddr2 memories and no i2c interfaces.

Using this driver the user can simulate a spd eeprom of a ddr2 memory and use the ddr2 auto config.

User can use the macros CONFIG_EEPROM_SIMUL_LEN and CONFIG_EEPROM_SIMUL_DATA to define the content of the simulated eeprom

Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 drivers/i2c/Makefile       |    1 +
 drivers/i2c/eeprom_simul.c |   68 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/eeprom_simul.c
drivers/i2c/Makefile +1 -0
index 534c015..2aeabe5 100644
@@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
 COBJS-y += omap24xx_i2c.o
 COBJS-y += tsi108_i2c.o
 COBJS-y += mxc_i2c.o
+COBJS-$(CONFIG_EEPROM_SIMUL) += eeprom_simul.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/i2c/eeprom_simul.c new file +68 -0
new file mode 100644
index 0000000..d8dbb3b
@@ -0,0 +1,68 @@
+/*
+    (C) Copyright 2008
+    Ricado Ribalda-Universidad Autonoma de Madrid-ricardo.ribalda at uam.es
+    This work has been supported by: QTechnology  http://qtec.com/
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation, either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <common.h>
+#include <i2c.h>
+
+#ifndef CONFIG_EEPROM_SIMUL_LEN
+#define CONFIG_EEPROM_SIMUL_LEN 256
+#endif
+
+u8 eeprom_simul_buffer[CONFIG_EEPROM_SIMUL_LEN]
+#ifdef CONFIG_EEPROM_SIMUL_DATA
+       = CONFIG_EEPROM_SIMUL_DATA
+#endif
+;
+
+void i2c_init(int speed, int slaveaddr){
+       return ;
+}
+
+int i2c_read(uchar chip, uint addr, int alen, uchar * buffer, int len)
+{
+       int i;
+
+       if (addr+len>CONFIG_EEPROM_SIMUL_LEN)
+               return -1;
+
+       for(i=0;i<len;i++){
+               buffer[i]=eeprom_simul_buffer[i+addr];
+       }
+
+       return 0;
+}
+int i2c_write(uchar chip, uint addr, int alen, uchar * buffer, int len)
+{
+       int i;
+
+       if (addr+len>CONFIG_EEPROM_SIMUL_LEN)
+               return -1;
+
+       for(i=0;i<len;i++){
+               eeprom_simul_buffer[i+addr]=buffer[i];
+       }
+
+       return 0;
+}
+
+int i2c_probe(uchar chip)
+{
+       return 0;
+}
+
author
#5 lore raw

PATCH 1/1 I2C EEPROM simulator (Resubmit)

Hello Michal

No hints about where are this codyng style issues?

Best regards

Signature · 2 lines
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
#6 lore raw

PATCH 1/1 I2C EEPROM simulator (Resubmit)

for, if

M

Quoted 9 lines

Hello Michal

No hints about where are this codyng style issues?

Best regards