Skip to contentSkip to conversation

linux/fs.h should include linux/path.h

PATCH RESEND In review Niels de Vos 3 participants 4 messages Jul 27, 2008 VFS

lore
Share & tools
lore

Niels de Vos

author
#0 lore raw

PATCH RESEND 1/1 linux/fs.h should include linux/path.h

<linux/fs.h> defines 'struct file' which uses 'struct path'. However <linux/path.h> is not being included.

Signed-off-by Niels de Vos <[email protected]>

---

include/linux/fs.h +1 -0
index d8e2762..a14f1c4 100644
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
 #include <linux/mutex.h>
 #include <linux/capability.h>
 #include <linux/semaphore.h>
+#include <linux/path.h>
 
 #include <asm/atomic.h>
 #include <asm/byteorder.h>
#1 lore raw

include/linux/fs.h extern int dir_notify_enable; · line 292

Quoted 10 lines · Niels de Vos

<linux/fs.h> defines 'struct file' which uses 'struct path'. However <linux/path.h> is not being included.

include/linux/fs.h +1 -0
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
 #include <linux/mutex.h>
 #include <linux/capability.h>
 #include <linux/semaphore.h>
+#include <linux/path.h>

You see compilation breakage?

#2 lore raw
In reply to Niels de Vos
Quoted 11 lines · Niels de Vos

<linux/fs.h> defines 'struct file' which uses 'struct path'. However <linux/path.h> is not being included.

Signed-off-by Niels de Vos <[email protected]>

---

include/linux/fs.h +0 -0
index d8e2762..a14f1c4 100644

include/linux/fs.h extern int dir_notify_enable; · line 292

Quoted 5 lines
include/linux/fs.h +1 -0
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
 #include <linux/mutex.h>
 #include <linux/capability.h>
 #include <linux/semaphore.h>
+#include <linux/path.h>
...

This #include was recently added a few lines above.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#3 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 5 lines · Niels de Vos

<linux/fs.h> defines 'struct file' which uses 'struct path'. However <linux/path.h> is not being included.

Signed-off-by Niels de Vos <[email protected]>
Quoted 13 lines

include/linux/fs.h extern int dir_notify_enable; · line 292

Quoted 11 lines

---

include/linux/fs.h +1 -0
index d8e2762..a14f1c4 100644
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
 #include <linux/mutex.h>
 #include <linux/capability.h>
 #include <linux/semaphore.h>
+#include <linux/path.h>
...

This #include was recently added a few lines above.

Okay, looks like I've missed that commit.

Thanks, Niels