Skip to contentSkip to conversation

unify arch/x86/kernel/tlb.c

PATCH New Jeremy Fitzhardinge 1 participant 1 message Jul 29, 2008

lore
Share & tools
lore
#0 lore raw

cover unify arch/x86/kernel/tlb.c

This series converts tlb_32.c and _64.c to use smp_call_function_mask. Having done that, their underlying similarity is plainly revealed, and they can be easily unified.

The result is the removal of ~270 lines of code, most of which was a pair of open-coded versions of what smp_call_function_mask does anyway. The remaining code is much clearer as a result.

I've given these patches some mild testing, and nothing exploded. I'm actually fairly confident in them, since all the complex subtle stuff is now in smp_call_function_mask, so if anything breaks, it's probably going to be in there.

And though I dare not touch it, Voyager could probably be converted to use this code fairly simply as well.

J

--

arch/x86/kernel/Makefile      |    2 arch/x86/kernel/entry_64.S    |   15 --
arch/x86/kernel/irqinit_64.c  |   10 -
arch/x86/kernel/tlb.c         |  229 ++++++++++++++++++++++++++++++++++
arch/x86/kernel/tlb_32.c      |  191 ----------------------------
arch/x86/kernel/tlb_64.c      |  279 ------------------------------------------
arch/x86/kernel/tlb_uv.c      |    5 include/asm-x86/irq_vectors.h |    4 include/asm-x86/uv/uv_bau.h   |    2 9 files changed, 234 insertions(+), 503 deletions(-)