Skip to contentSkip to conversation

mips: fix erros on registers macros of pll-ddr-config1-nfrac for QCA956X

PATCH New rosysong at rosinson.com 2 participants 2 messages Mar 16, 2019 – Mar 29, 2019 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/3 mips: fix erros on registers macros of pll-ddr-config1-nfrac for QCA956X

From: Rosy Song <[email protected]>

See details in chapter 8.6.2 and 8.6.4 (page 140-141) of qca9563 datasheet,

NFRAC[17:0]

So the mask of [17:5] is 0x1fff not 0x3fff.

Changes for v2-v3:
- add more information for this commit

Changes for v4-v5:
- coding style cleanup

---
 arch/mips/mach-ath79/include/mach/ar71xx_regs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/mach-ath79/include/mach/ar71xx_regs.h +2 -2
index 5d371bb582..3506ed1da4 100644
@@ -528,7 +528,7 @@
 #define QCA956X_PLL_CPU_CONFIG1_NFRAC_L_SHIFT		0
 #define QCA956X_PLL_CPU_CONFIG1_NFRAC_L_MASK		0x1f
 #define QCA956X_PLL_CPU_CONFIG1_NFRAC_H_SHIFT		5
-#define QCA956X_PLL_CPU_CONFIG1_NFRAC_H_MASK		0x3fff
+#define QCA956X_PLL_CPU_CONFIG1_NFRAC_H_MASK		0x1fff
 #define QCA956X_PLL_CPU_CONFIG1_NINT_SHIFT		18
 #define QCA956X_PLL_CPU_CONFIG1_NINT_MASK		0x1ff
 
@@ -540,7 +540,7 @@
 #define QCA956X_PLL_DDR_CONFIG1_NFRAC_L_SHIFT		0
 #define QCA956X_PLL_DDR_CONFIG1_NFRAC_L_MASK		0x1f
 #define QCA956X_PLL_DDR_CONFIG1_NFRAC_H_SHIFT		5
-#define QCA956X_PLL_DDR_CONFIG1_NFRAC_H_MASK		0x3fff
+#define QCA956X_PLL_DDR_CONFIG1_NFRAC_H_MASK		0x1fff
 #define QCA956X_PLL_DDR_CONFIG1_NINT_SHIFT		18
 #define QCA956X_PLL_DDR_CONFIG1_NINT_MASK		0x1ff
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH v5 1/3 mips: fix erros on registers macros of pll-ddr-config1-nfrac for QCA956X

Am 16.03.19 um 02:24 schrieb rosysong at rosinson.com:

Quoted 10 lines

From: Rosy Song <[email protected]>

See details in chapter 8.6.2 and 8.6.4 (page 140-141) of qca9563 datasheet,

   NFRAC[17:0]

So the mask of [17:5] is 0x1fff not 0x3fff.

Quoted 8 lines

Changes for v2-v3:
- add more information for this commit

Changes for v4-v5:
- coding style cleanup

---
 arch/mips/mach-ath79/include/mach/ar71xx_regs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

series applied to u-boot-mips/next, thanks.

Signature · 1 line
- Daniel