Skip to contentSkip to conversation

Add (struct sock*) sk parameter for send_ack()

PATCH In review Gui Jianfeng 2 participants 3 messages Aug 5, 2008 – Aug 7, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Add (struct sock*) sk parameter for send_ack()

Add (struct sock*) sk parameter for send_ack.

---
 include/net/request_sock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/net/request_sock.h +1 -1
index 8d6e991..cac811e 100644
@@ -33,7 +33,7 @@ struct request_sock_ops {
 	struct kmem_cache	*slab;
 	int		(*rtx_syn_ack)(struct sock *sk,
 				       struct request_sock *req);
-	void		(*send_ack)(struct sk_buff *skb,
+	void		(*send_ack)(struct sock *sk, struct sk_buff *skb,
 				    struct request_sock *req);
 	void		(*send_reset)(struct sock *sk,
 				      struct sk_buff *skb);
Signature · 1 line
1.5.3
maintainer
#1 lore raw

From: Gui Jianfeng <[email protected]>
Date: Tue, 05 Aug 2008 17:22:38 +0800

Quoted 3 lines

Add (struct sock*) sk parameter for send_ack.

This patch by itself breaks the build.

Don't submit patches this way. Every patch applied should still leave the tree building.

Also, since your OOPS and detailed description only exists in the "0/3" email, it won't make it into the commit log history where it belongs.

Considering all of this, I'd say you should fix this as one big patch with a really nice commit log message.

Thanks.

#2 lore raw
Quoted 3 lines · David Miller

Considering all of this, I'd say you should fix this as one big patch with a really nice commit log message.

OK, I'll repost it later.

Signature · 2 lines
Regards
Gui Jianfeng