Skip to contentSkip to conversation

fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

PATCH Applied Samuel Thibault 5 participants 5 messages Aug 12, 2008

lore
Share & tools
lore

Samuel Thibault

author
#0 lore raw

PATCH 1/1 fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

Quoted 4 lines · Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :

qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu -no-reboot -no-acpi

It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Samuel

serial: Always update iir, even when ier is empty.

Signed-off-by Samuel Thibault <[email protected]>
serial.c +0 -5
Index: hw/serial.c
===================================================================
@@ -189,11 +189,6 @@
 {
     uint8_t tmp_iir = UART_IIR_NO_INT;
 
-    if (!s->ier) {
-        qemu_irq_lower(s->irq);
-        return;
-    }
-
     if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
         tmp_iir = UART_IIR_RLSI;
     } else if (s->timeout_ipending) {
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Samuel Thibault
Quoted 4 lines · Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :

qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu -no-reboot -no-acpi

It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Quoted 7 lines

Samuel

serial: Always update iir, even when ier is empty.

Signed-off-by Samuel Thibault <[email protected]>
Acked-by Stefano Stabellini <[email protected]>
#2 lore raw
Quoted 16 lines · Stefano Stabellini
Quoted 13 lines · Samuel Thibault
Quoted 5 lines · Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :

qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu -no-reboot -no-acpi

It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Samuel

Quoted 10 lines
Quoted 4 lines

serial: Always update iir, even when ier is empty.

Signed-off-by Samuel Thibault <[email protected]>
Acked-by Stefano Stabellini <[email protected]>

I confirmed that the OS level polling mode drivers still work properly as well.

Jason.

#3 lore raw
In reply to Samuel Thibault
Quoted 7 lines · Samuel Thibault
Quoted 4 lines · Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :

qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu -no-reboot -no-acpi

It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Confirmed here. Thanks :)

Brad

Signature · 3 lines
Dolphins are so intelligent that within a few weeks they can
train Americans to stand at the edge of the pool and throw them
fish.
Applied
#4 lore raw
In reply to Samuel Thibault
Quoted 10 lines · Samuel Thibault
Quoted 5 lines · Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :

qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu -no-reboot -no-acpi

It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Applied. Thanks for fixing this so quickly.

Regards,

Anthony Liguori

Quoted 2 lines

Samuel