Skip to contentSkip to conversation

don't leave loop prematurely

PATCH In review Ryan Hope 2 participants 2 messages Aug 11, 2008 – Aug 12, 2008

lore
Share & tools
lore

Ryan Hope

author
#0 lore raw

PATCH 2/3 don't leave loop prematurely

This was item #9 on the todo list for reiser4 inclusion in mainline:

7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c renamed from 52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c +1 -2
index edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d 100644
@@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t from, pgoff_t count)
 				unhash_unformatted_jnode(node);
 				truncated_jnodes++;
 				jput(node);
-			} else
-				break;
+			}
 		}
 		if (i != taken || taken == 0)
 			break;

-Ryan

#1 lore raw
Quoted 11 lines · Ryan Hope

This was item #9 on the todo list for reiser4 inclusion in mainline:

diff --git a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c index edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d 100644

7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c truncate_jnodes_range(struct inode *inode, pgoff_t · line 662

Quoted 7 lines
7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c renamed from 52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c +1 -2
@@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t
 from, pgoff_t count)
                 unhash_unformatted_jnode(node);
                 truncated_jnodes++;
                 jput(node);
-            } else
-                break;
+            }

No, this is wrong:
if (node == NULL), then there is nothing to do in this loop.

Edward.

Quoted 7 lines
7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c renamed from 52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c +0 -0
         }
         if (i != taken || taken == 0)

             break;

-Ryan