Skip to contentSkip to conversation

netns: fix for NULL-dereference in ipv6 code

PATCH In review Brian Haley 2 participants 2 messages Aug 14, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover netns: fix for NULL-dereference in ipv6 code

Hi,

When fixing the NULL-dereference of the idev in rt6_fill_node(), I noticed that dev_net() doesn't handle a NULL argument either. These two patches fix that, as well as add a network namespace argument to rt6_fill_node() and ipv6_dev_get_saddr().

-Brian

#1 lore raw
Quoted 6 lines · Brian Haley

Hi,

When fixing the NULL-dereference of the idev in rt6_fill_node(), I noticed that dev_net() doesn't handle a NULL argument either. These two patches fix that, as well as add a network namespace argument to rt6_fill_node() and ipv6_dev_get_saddr().

Brian

What is the reason that dev_net() would need to handle a NULL arg?

I think a NULL pointer in dev_net is a bug if Network Namespaces are used.

-vlad