Skip to contentSkip to conversation

audit: Moved variable declaration to beginning of function

PATCH In review Cordelia 2 participants 2 messages Aug 18, 2008 Audit

lore
Share & tools
lore

Cordelia

author
#0 lore raw

PATCH 1/1 audit: Moved variable declaration to beginning of function

got rid of compilation warning:
ISO C90 forbids mixed declarations and code

Signed-off-by Cordelia Sam <[email protected]>
---
 kernel/auditsc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/auditsc.c +2 -1
index 972f8e6..59cedfb 100644
@@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
 
 static int audit_match_perm(struct audit_context *ctx, int mask)
 {
+	unsigned n;
 	if (unlikely(!ctx))
 		return 0;
 
-	unsigned n = ctx->major;
+	n = ctx->major;
 	switch (audit_classify_syscall(ctx->arch, n)) {
 	case 0:	/* native */
 		if ((mask & AUDIT_PERM_WRITE) &&
Signature · 1 line
1.5.4.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Cordelia

got rid of compilation warning:
ISO C90 forbids mixed declarations and code

Signed-off-by Cordelia Sam <[email protected]>
---
 kernel/auditsc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/auditsc.c +0 -0
index 972f8e6..59cedfb 100644
@@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
 
 static int audit_match_perm(struct audit_context *ctx, int mask)

kernel/auditsc.c static inline int open_arg(int flags, int mask) · line 253

Quoted 10 lines
kernel/auditsc.c +2 -1
 {
+	unsigned n;
 	if (unlikely(!ctx))
 		return 0;
 
-	unsigned n = ctx->major;
+	n = ctx->major;
 	switch (audit_classify_syscall(ctx->arch, n)) {
 	case 0:	/* native */
 		if ((mask & AUDIT_PERM_WRITE) &&
Reviewed-by James Morris <[email protected]>
Signature · 2 lines
James Morris
<[email protected]>