Skip to contentSkip to conversation

Xen: Fix memory access violation bug when CONFIG_HAVE_SPARSE_IRQ is enabled

PATCH Jeremy Fitzhardinge 1 participant 1 message Aug 18, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jeremy Fitzhardinge

author Acked-by
#1 lore raw
Quoted 8 lines · Alex Nixon

From: Alex Nixon <[email protected]>
Date: Mon, 18 Aug 2008 14:15:11 +0100
Subject: [PATCH] Xen: Fix memory access violation bug when CONFIG_HAVE_SPARSE_IRQ is enabled

When sparse IRQs are enabled, it is not safe to assume an IRQ descriptor exists for every possible IRQ. This patch causes init_evtchn_cpu_bindings to skip initialisation of IRQ descriptors which don't exist.

Thanks again, Alex.

Ingo, please apply.

Quoted 18 lines
---
 drivers/xen/events.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/xen/events.c +2 -0
index 74dca12..6e7e765 100644
@@ -141,6 +141,8 @@ static void init_evtchn_cpu_bindings(void)
 	/* By default all event channels notify CPU#0. */
 	for (i = 0; i < nr_irqs; i++) {
 		struct irq_desc *desc = to_irq_desc(i);
+		if (!desc)
+			continue;
 		desc->affinity = cpumask_of_cpu(0);
 	}
 #endif