Skip to contentSkip to conversation

powerpc, scc: duplicate SCC_UHC_USBCEN

PATCH Superseded roel kluin 2 participants 3 messages Aug 18, 2008 – Aug 19, 2008

Subsystems (2)
PowerPC Cell broadband engine architecture
lore
Share & tools
lore

roel kluin

author
#0 lore raw

PATCH 1/1 powerpc, scc: duplicate SCC_UHC_USBCEN

untested, is it correct?
---
arch/powerpc/platforms/cell/celleb_scc.h:224:
#define SCC_UHC_USBEN 0x00010000
#define SCC_UHC_USBCEN 0x00020000

---

arch/powerpc/platforms/cell/celleb_scc_uhc.c +1 -1
index d63b720..b086f33 100644
@@ -31,7 +31,7 @@
 
 static inline int uhc_clkctrl_ready(u32 val)
 {
-	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
+	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
 	return((val & mask) == mask);
 }
#1 lore raw

Roel,

Quoted 1 line

untested, is it correct?

Your patch is correct.

Thanks for your pointing it out and sending the patch. I tested your patch and it works good.

Fortunately, this bug is not fatal because it seems that the SCC-UHC sets SCC_UHC_USBEN and SCC_UHC_USBCEN at once.

Your patch does not contain 'Signed-off-by' line. Could you re-post it with your sign?

Quoted 19 lines

---
arch/powerpc/platforms/cell/celleb_scc.h:224:
#define SCC_UHC_USBEN 0x00010000
#define SCC_UHC_USBCEN 0x00020000

---

arch/powerpc/platforms/cell/celleb_scc_uhc.c +1 -1
index d63b720..b086f33 100644
@@ -31,7 +31,7 @@
 
 static inline int uhc_clkctrl_ready(u32 val)
 {
-	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
+	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
 	return((val & mask) == mask);
 }
Quoted 4 lines

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Best regards,
Kou Ishizaki

author
#2 lore raw

PATCH v2 1/1 powerpc, scc: duplicate SCC_UHC_USBCEN

Quoted 10 lines · Kou Ishizaki

Roel,

Quoted 1 line

untested, is it correct?

Your patch is correct.

Thanks for your pointing it out and sending the patch. I tested your patch and it works good.

Quoted 6 lines

Fortunately, this bug is not fatal because it seems that the SCC-UHC sets SCC_UHC_USBEN and SCC_UHC_USBCEN at once.

Your patch does not contain 'Signed-off-by' line. Could you re-post it with your sign?

Sorry for that and thanks for testing.
---
duplicate SCC_UHC_USBCEN

Signed-off-by Roel Kluin <[email protected]>

---

arch/powerpc/platforms/cell/celleb_scc_uhc.c +1 -1
index d63b720..b086f33 100644
@@ -31,7 +31,7 @@
 
 static inline int uhc_clkctrl_ready(u32 val)
 {
-	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
+	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
 	return((val & mask) == mask);
 }