Skip to contentSkip to conversation

KVM x86_emulate.c: duplicate SrcImm

PATCH In review roel kluin 2 participants 2 messages Aug 18, 2008 – Aug 21, 2008

Subsystems (2)
x86 KVM x86
lore
Share & tools
lore

roel kluin

author
#0 lore raw

PATCH 1/1 KVM x86_emulate.c: duplicate SrcImm

Hi avi,

you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1 any idea whether it should be replaced by something else?
---
duplicate SrcImm

Signed-off-by Roel Kluin <[email protected]>

---

arch/x86/kvm/x86_emulate.c +1 -1
index f2f9046..78b76c9 100644
@@ -268,7 +268,7 @@ static u16 group_table[] = {
 	ByteOp | DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
 	0, 0, 0, 0,
 	[Group3*8] =
-	DstMem | SrcImm | ModRM | SrcImm, 0,
+	DstMem | SrcImm | ModRM, 0,
 	DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
 	0, 0, 0, 0,
 	[Group4*8] =
#1 lore raw
Quoted 7 lines · roel kluin

Hi avi,

you added this in commit 7d858a19efe5844a98e060931570359b70dea6d1 any idea whether it should be replaced by something else?
---
duplicate SrcImm

Right. Applied.

I don't know if some other bit is missing a SrcImm. I'll review that code.

Signature · 1 line
error compiling committee.c: too many arguments to function