Skip to contentSkip to conversation

powerpc: Check rc of notifier chain for memory remove

PATCH New Nathan Fontenot 1 participant 1 message Aug 25, 2008 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Check rc of notifier chain for memory remove

The return code from invocation of the notifier for
pSeries_reconfig_chain during update of the device tree is not checked. This causes writes to /proc/ppc64/ofdt to update memory properties (i.e. ibm,dyamic-reconfiguration-memory) to always return success, instead of the result of the notifier chain.

This happens specifically when we remove/add memory from the device tree on machines using memory specified in the ibm,dynamic-reconfiguration-memory property of the device tree.

---

arch/powerpc/platforms/pseries/reconfig.c +0 -0
Index: linux-2.6-paulus/arch/powerpc/platforms/pseries/reconfig.c
===================================================================
@@ -466,11 +466,11 @@
		else
			action = PSERIES_DRCONF_MEM_REMOVE;

- blocking_notifier_call_chain(&pSeries_reconfig_chain,
- action, value);
+ rc = blocking_notifier_call_chain(&pSeries_reconfig_chain,

+						  action, value);
	}

- return 0;
+ return rc;
}

/**