Skip to contentSkip to conversation

Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

PATCH New Peter Tyser 2 participants 5 messages Aug 26, 2008 – Aug 27, 2008

lore
Share & tools
lore

Peter Tyser

author
#0 lore raw

PATCH 1/1 Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

cmd_net.c command descriptions were updated to describe the optional hostIPaddr argument. The dhcp command help message was also updated to more closely reflect the other commands in cmd_net.c

Signed-off-by Peter Tyser <[email protected]>

---

 common/cmd_net.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
common/cmd_net.c +5 -5
index 79e910c..af691a4 100644
@@ -39,8 +39,8 @@ int do_bootp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	bootp,	3,	1,	do_bootp,
-	"bootp\t- boot image via network using BootP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"bootp\t- boot image via network using BOOTP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 int do_tftpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])

@@ -62,7 +62,7 @@ int do_rarpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 U_BOOT_CMD(
 	rarpboot,	3,	1,	do_rarpb,
 	"rarpboot- boot image via network using RARP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 #if defined(CONFIG_CMD_DHCP)

@@ -73,8 +73,8 @@ int do_dhcp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	dhcp,	3,	1,	do_dhcp,
-	"dhcp\t- invoke DHCP client to obtain IP/boot params\n",
-	"\n"
+	"dhcp\t- boot image via network using DHCP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 #endif
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

Hi Peter,

Quoted 7 lines · Peter Tyser

cmd_net.c command descriptions were updated to describe the optional hostIPaddr argument. The dhcp command help message was also updated to more closely reflect the other commands in cmd_net.c

Signed-off-by Peter Tyser <[email protected]>

---

I'm too lazy to check if this is different from the patch that you sent previously (8/13 or so). I imagine you want this one applied and the other discarded?

regards,
Ben

author
#2 lore raw

PATCH 1/1 Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

Hi Ben,

Quoted 7 lines · Ben Warren

Hi Peter,

Quoted 4 lines · Peter Tyser

cmd_net.c command descriptions were updated to describe the optional hostIPaddr argument. The dhcp command help message was also updated to more closely reflect the other commands in cmd_net.c

Quoted 6 lines
Quoted 3 lines
Signed-off-by Peter Tyser <[email protected]>

---

I'm too lazy to check if this is different from the patch that you sent previously (8/13 or so). I imagine you want this one applied and the other discarded?

The content of this patch is identical to the previous patch sent on 8/13. However, the email on 8/13's title included "[RFC]" and in it I made the following comment:

"Not sure if "boot" is the proper word to use in the command definitions since the downloaded images are only booted if "autostart=yes", and the majority of board configs don't have autostart set to yes. I'd vote for changing the descriptions to "load image via...". If a new, more granular bootm command is in the works,
it seems like even less people will autoboot an image directly before doing some additional bootm commands to prep for booting an OS. Do others have an opinion?"

No one seemed to bite as far as changing the wording of the commands, so I re-sent the same patch without the [RFC] and cleaned up the commit message to make it a formal patch. So you're right, this patch should be applied and the previous one on 8/13 discarded.

Thanks,
Peter

#3 lore raw

PATCH 1/1 Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

Quoted 34 lines · Peter Tyser

Hi Ben,

Quoted 8 lines · Ben Warren

Hi Peter,

Quoted 4 lines · Peter Tyser

cmd_net.c command descriptions were updated to describe the optional hostIPaddr argument. The dhcp command help message was also updated to more closely reflect the other commands in cmd_net.c

Quoted 8 lines
Quoted 4 lines
Signed-off-by Peter Tyser <[email protected]>

---

I'm too lazy to check if this is different from the patch that you sent previously (8/13 or so). I imagine you want this one applied and the other discarded?

The content of this patch is identical to the previous patch sent on 8/13. However, the email on 8/13's title included "[RFC]" and in it I made the following comment:

"Not sure if "boot" is the proper word to use in the command definitions since the downloaded images are only booted if "autostart=yes", and the majority of board configs don't have autostart set to yes. I'd vote for changing the descriptions to "load image via...". If a new, more granular bootm command is in the works,
it seems like even less people will autoboot an image directly before doing some additional bootm commands to prep for booting an OS. Do others have an opinion?"

Quoted 5 lines

No one seemed to bite as far as changing the wording of the commands, so I re-sent the same patch without the [RFC] and cleaned up the commit message to make it a formal patch. So you're right, this patch should be applied and the previous one on 8/13 discarded.

Good deal. I'm hoping to get a few hours tonight to catch up.

regards,
Ben

Applied
#4 lore raw

PATCH 1/1 Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

In reply to Peter Tyser
Quoted 7 lines · Peter Tyser

cmd_net.c command descriptions were updated to describe the optional hostIPaddr argument. The dhcp command help message was also updated to more closely reflect the other commands in cmd_net.c

Signed-off-by Peter Tyser <[email protected]>

---

Applied to net repo.

Thanks for cleaning this up!
Ben