Update linux bootm to support ePAPR client interface
PATCH 1/15 Update linux bootm to support ePAPR client interface
the ePAPR spec has some subtle differences from the current device tree based boot interface to the powerpc linux kernel. The powerpc linux kernel currently ignores the differences that ePAPR specifies.
--- lib_ppc/bootm.c | 33 +++++++++++++++++++++++---------- 1 files changed, 23 insertions(+), 10 deletions(-)
lib_ppc/bootm.c +23 -10
@@ -80,7 +80,8 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],ulong cmd_start, cmd_end, bootmap_base;bd_t *kbd;ulong ep =0 ; -void (*kernel)(bd_t *,ulong ,ulong ,ulong ,ulong ); +void (*kernel)(bd_t *,ulong r4,ulong r5,ulong r6, +ulong r7,ulong r8,ulong r9);int ret;ulong of_size =0 ;struct lmb *lmb = images->lmb;
@@ -166,8 +167,8 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],puts ("Could not find kernel entry point!\n" ); goto error; } - kernel = (void (*)(bd_t *,ulong ,ulong ,ulong ,ulong ))ep; - + kernel = (void (*)(bd_t *,ulong ,ulong ,ulong , +ulong ,ulong ,ulong ))ep;/* find ramdisk */ ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_PPC , &rd_data_start, &rd_data_end);
@@ -282,14 +283,23 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],if (of_flat_tree) {/* device tree; boot new style */ /* * Linux Kernel Parameters (passing device tree): -* r3: pointer to the fdt, followed by the board info data -* r4: physical pointer to the kernel itself -* r5: NULL -* r6: NULL -* r7: NULL +* r3: pointer to the fdt +* r4: 0 +* r5: 0 +* r6: epapr magic +* r7: size of IMA in bytes +* r8: 0 +* r9: 0 */ +#if defined(CONFIG_85xx) || defined(CONFIG_440 ) +#define EPAPR_MAGIC (0x45504150) +#else +#define EPAPR_MAGIC (0x65504150) +#endif +debug (" Booting using OF flat tree...\n" ); - (*kernel) ((bd_t *)of_flat_tree, (ulong )kernel,0 ,0 ,0 ); + (*kernel) ((bd_t *)of_flat_tree,0 ,0 ,EPAPR_MAGIC , +CFG_BOOTMAPSZ ,0 ,0 );/* does not return */ } else#endif
@@ -301,9 +311,12 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],* r5: initrd_end - unused if r4 is 0 * r6: Start of command line string * r7: End of command line string +* r8: 0 +* r9: 0 */ debug (" Booting using board info...\n" ); - (*kernel) (kbd, initrd_start, initrd_end, cmd_start, cmd_end); + (*kernel) (kbd, initrd_start, initrd_end, + cmd_start, cmd_end,0 ,0 );/* does not return */ }return ;
Signature · 1 line
1.5.5.1
PATCH 2/15 Clean up usage of icache_disable/dcache_disable
There is no point in disabling the icache on 7xx/74xx/86xx parts and not also flushing the icache. All callers of invalidate_l1_instruction_cache() call icache_disable() right after. Make it so icache_disable() calls invalidate_l1_instruction_cache() for us.
Also, dcache_disable() already calls dcache_flush() so there is no point in the explicit calls of dcache_flush().
--- board/Marvell/db64360/db64360.c | 5 ----- board/Marvell/db64460/db64460.c | 5 ----- board/esd/cpci750/cpci750.c | 4 ---- board/freescale/mpc7448hpc2/mpc7448hpc2.c | 2 -- board/prodrive/p3mx/p3mx.c | 2 -- common/cmd_bootm.c | 2 -- cpu/74xx_7xx/cache.S | 4 ++++ cpu/mpc86xx/cache.S | 4 ++++ 8 files changed, 8 insertions(+), 20 deletions(-)
board/Marvell/db64360/db64360.c +0 -5
@@ -51,9 +51,6 @@#define DP (x)#endif -extern void flush_data_cache (void ); -extern void invalidate_l1_instruction_cache (void ); -/* ------------------------------------------------------------------------- */ /* this is the current GT register space location */
@@ -930,7 +927,5 @@ void board_prebootm_init ()my_remap_gt_regs_bootm (CFG_GT_REGS ,BRIDGE_REG_BASE_BOOTM );icache_disable (); -invalidate_l1_instruction_cache (); -flush_data_cache ();dcache_disable (); }
board/Marvell/db64460/db64460.c +0 -5
@@ -51,9 +51,6 @@#define DP (x)#endif -extern void flush_data_cache (void ); -extern void invalidate_l1_instruction_cache (void ); -/* ------------------------------------------------------------------------- */ /* this is the current GT register space location */
@@ -930,7 +927,5 @@ void board_prebootm_init ()my_remap_gt_regs_bootm (CFG_GT_REGS ,BRIDGE_REG_BASE_BOOTM );icache_disable (); -invalidate_l1_instruction_cache (); -flush_data_cache ();dcache_disable (); }
board/esd/cpci750/cpci750.c +0 -4
@@ -120,8 +120,6 @@ static char show_config_tab[][15] = {{"PCI0DLL_2 "}, /* 31 */ {"DRAMPLL_NDiv_1"}, /* 01 */ {"DRAMPLL_NDiv_0"}}; /* 00 */ -extern void flush_data_cache (void ); -extern void invalidate_l1_instruction_cache (void );extern flash_info_t flash_info[];/* ------------------------------------------------------------------------- */
@@ -961,8 +959,6 @@ void board_prebootm_init ()my_remap_gt_regs_bootm (CFG_GT_REGS ,CFG_DFL_GT_REGS );icache_disable (); -invalidate_l1_instruction_cache (); -flush_data_cache ();dcache_disable (); }
board/freescale/mpc7448hpc2/mpc7448hpc2.c +0 -2
@@ -37,8 +37,6 @@DECLARE_GLOBAL_DATA_PTR ; -extern void flush_data_cache (void ); -extern void invalidate_l1_instruction_cache (void );extern void tsi108_init_f (void );int display_mem_map (void );
board/prodrive/p3mx/p3mx.c +0 -2
@@ -62,8 +62,6 @@ DECLARE_GLOBAL_DATA_PTR;#define DP (x)#endif -extern void flush_data_cache (void ); -extern void invalidate_l1_instruction_cache (void );extern flash_info_t flash_info[];/* ------------------------------------------------------------------------- */
common/cmd_bootm.c +0 -2
@@ -236,8 +236,6 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])* bios emulation, so turn them off again */ icache_disable (); -invalidate_l1_instruction_cache (); -flush_data_cache ();dcache_disable ();#endif
cpu/74xx_7xx/cache.S +4 -0
@@ -245,6 +245,10 @@ _GLOBAL(icache_enable) * Disable L1 Instruction cache */ _GLOBAL(icache_disable) + mflr r4 + bl invalidate_l1_instruction_cache /* uses r3 */ + sync + mtlr r4 mfspr r3, HID0 li r5, 0 ori r5, r5, HID0_ICE
cpu/mpc86xx/cache.S +4 -0
@@ -232,6 +232,10 @@ _GLOBAL(icache_enable) * Disable L1 Instruction cache */ _GLOBAL(icache_disable) + mflr r4 + bl invalidate_l1_instruction_cache /* uses r3 */ + sync + mtlr r4 mfspr r3, HID0 li r5, 0 ori r5, r5, HID0_ICE
Signature · 1 line
1.5.5.1
PATCH 3/15 Add command to enable/disable interrupts
--- common/Makefile | 1 + common/cmd_irq.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 common/cmd_irq.c
common/Makefile +1 -0
@@ -78,6 +78,7 @@ endif COBJS-$(CONFIG_CMD_I2C) += cmd_i2c.o COBJS-$(CONFIG_CMD_IDE) += cmd_ide.o COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o +COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o COBJS-y += cmd_load.o
common/cmd_irq.c new file +50 -0
50 lines not on this page · raw message
Signature · 1 line
1.5.5.1
PATCH 4/15 fdt: added the ability to set initrd start/end via chosen command
--- common/cmd_fdt.c | 21 +++++++++++++++++---- 1 files changed, 17 insertions(+), 4 deletions(-)
common/cmd_fdt.c +17 -4
@@ -417,9 +417,21 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])ft_board_setup (working_fdt, gd->bd);#endif /* Create a chosen node */ - else if (argv[1][0] == 'c') - fdt_chosen(working_fdt, 0, 0, 1); - else { + else if (argv[1][0] == 'c') { +unsigned long initrd_start =0 , initrd_end =0 ; + +if ((argc !=2 ) && (argc !=4 )) { +printf ("Usage:\n%s\n" , cmdtp->usage); +return 1 ; + } + +if (argc ==4 ) { + initrd_start =simple_strtoul (argv[2 ],NULL ,16 ); + initrd_end =simple_strtoul (argv[3 ],NULL ,16 ); + } + +fdt_chosen (working_fdt, initrd_start, initrd_end,1 ); + } else {/* Unrecognized command */ printf ("Usage:\n%s\n" , cmdtp->usage);return 1 ;
@@ -798,7 +810,8 @@ U_BOOT_CMD("fdt rsvmem print - Show current mem reserves\n" "fdt rsvmem add <addr> <size> - Add a mem reserve\n" "fdt rsvmem delete <index> - Delete a mem reserves\n" -"fdt chosen - Add/update the /chosen branch in the tree\n" +"fdt chosen [<start> <end>] - Add/update the /chosen branch in the tree\n" +" <start>/<end> - initrd start/end addr\n" "NOTE: If the path or property you are setting/printing has a '#' character\n" " or spaces, you MUST escape it with a \\ character or quote it with \".\n" );
Signature · 1 line
1.5.5.1
PATCH 5/15 fdt: fdt addr w/o any args reports back the current working address
--- common/cmd_fdt.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
common/cmd_fdt.c +8 -0
@@ -67,6 +67,14 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])/* * Set the address [and length] of the fdt. */ +if (argc ==2 ) { +if (!fdt_valid ()) { +return 1 ; + } +printf ("The address of the fdt is %p\n" , working_fdt); +return 0 ; + } + working_fdt = (struct fdt_header *)simple_strtoul (argv[2 ],NULL ,16 );if (!fdt_valid ()) {
Signature · 1 line
1.5.5.1
PATCH 6/15 bootm: refactor entry point code
Move entry point code out of each arch and into common code. Keep the entry point in the bootm_headers_t images struct.
--- common/cmd_bootm.c | 31 ++++++++++++++++++++++--------- include/image.h | 2 ++ lib_arm/bootm.c | 19 +------------------ lib_avr32/bootm.c | 19 +------------------ lib_blackfin/bootm.c | 19 +------------------ lib_m68k/bootm.c | 19 +------------------ lib_microblaze/bootm.c | 19 +------------------ lib_mips/bootm.c | 18 +----------------- lib_nios2/bootm.c | 20 +------------------- lib_ppc/bootm.c | 22 +++------------------- lib_sh/bootm.c | 19 +------------------ lib_sparc/bootm.c | 12 ++---------- 12 files changed, 37 insertions(+), 182 deletions(-)
common/cmd_bootm.c +22 -9
@@ -205,6 +205,23 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])return 1 ; } +/* find kernel entry point */ +if (images.legacy_hdr_valid) { + images.ep =image_get_ep (&images.legacy_hdr_os_copy); +#if defined(CONFIG_FIT ) + } else if (images.fit_uname_os) { + ret =fit_image_get_entry (images.fit_hdr_os, + images.fit_noffset_os, &images.ep); +if (ret) { +puts ("Can't get entry point property!\n" ); +return 1 ; + } +#endif + }else { +puts ("Could not find kernel entry point!\n" ); +return 1 ; + } + image_start = (ulong )os_hdr; load_end =0 ; type_name =genimg_get_type_name (type);
@@ -942,7 +959,7 @@ static void do_bootm_netbsd (cmd_tbl_t *cmdtp, int flag, cmdline ="" ; } - loader = (void (*)(bd_t *,image_header_t *,char *,char *))image_get_ep (hdr); + loader = (void (*)(bd_t *,image_header_t *,char *,char *))images->ep;printf ("## Transferring control to NetBSD stage-2 loader (at address %08lx) ...\n" , (ulong )loader);
@@ -981,7 +998,6 @@ static void do_bootm_rtems (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], bootm_headers_t *images) { - image_header_t *hdr = &images->legacy_hdr_os_copy; void (*entry_point)(bd_t *);#if defined(CONFIG_FIT )
@@ -991,7 +1007,7 @@ static void do_bootm_rtems (cmd_tbl_t *cmdtp, int flag, }#endif - entry_point = (void (*)(bd_t *))image_get_ep (hdr); + entry_point = (void (*)(bd_t *))images->ep;printf ("## Transferring control to RTEMS (at address %08lx) ...\n" , (ulong )entry_point);
@@ -1011,7 +1027,6 @@ static void do_bootm_vxworks (cmd_tbl_t *cmdtp, int flag, bootm_headers_t *images) {char str[80 ]; -image_header_t *hdr = &images->legacy_hdr_os_copy;#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {
@@ -1020,7 +1035,7 @@ static void do_bootm_vxworks (cmd_tbl_t *cmdtp, int flag, }#endif -sprintf (str,"%x" ,image_get_ep (hdr));/* write entry-point into string */ +sprintf (str,"%lx" , images->ep);/* write entry-point into string */ setenv ("loadaddr" , str);do_bootvx (cmdtp,0 ,0 ,NULL ); }
@@ -1031,7 +1046,6 @@ static void do_bootm_qnxelf(cmd_tbl_t *cmdtp, int flag, {char *local_args[2 ];char str[16 ]; -image_header_t *hdr = &images->legacy_hdr_os_copy;#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {
@@ -1040,7 +1054,7 @@ static void do_bootm_qnxelf(cmd_tbl_t *cmdtp, int flag, }#endif -sprintf (str,"%x" ,image_get_ep (hdr));/* write entry-point into string */ +sprintf (str,"%lx" , images->ep);/* write entry-point into string */ local_args[0 ] = argv[0 ]; local_args[1 ] = str;/* and provide it via the arguments */ do_bootelf (cmdtp,0 ,2 , local_args);
@@ -1058,7 +1072,6 @@ static void do_bootm_artos (cmd_tbl_t *cmdtp, int flag,int i, j, nxt, len, envno, envsz;bd_t *kbd;void (*entry)(bd_t *bd,char *cmdline,char **fwenv,ulong top); -image_header_t *hdr = &images->legacy_hdr_os_copy;#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {
@@ -1133,7 +1146,7 @@ static void do_bootm_artos (cmd_tbl_t *cmdtp, int flag, } *ss++ =NULL ;/* terminate */ - entry = (void (*)(bd_t *,char *,char **,ulong ))image_get_ep (hdr); + entry = (void (*)(bd_t *,char *,char **,ulong ))images->ep; (*entry) (kbd, cmdline, fwenv, top); }#endif
include/image.h +2 -0
@@ -219,6 +219,8 @@ typedef struct bootm_headers {#endif #endif +ulong ep;/* entry point of OS */ +int verify;/* getenv("verify")[0] != 'n' */ struct lmb *lmb;/* for memory mgmt */ } bootm_headers_t;
lib_arm/bootm.c +1 -18
@@ -62,7 +62,6 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], bootm_headers_t *images) {ulong initrd_start, initrd_end; -ulong ep =0 ;bd_t *bd = gd->bd;char *s;int machid = bd->bi_arch_number;
@@ -73,23 +72,7 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],char *commandline =getenv ("bootargs" );#endif -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - theKernel = (void (*)(int ,int ,uint ))ep; + theKernel = (void (*)(int ,int ,uint ))images->ep; s =getenv ("machid" );if (s) {
lib_avr32/bootm.c +1 -18
@@ -177,29 +177,12 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], bootm_headers_t *images) {ulong initrd_start, initrd_end; -ulong ep =0 ;void (*theKernel)(int magic,void *tagtable);struct tag *params, *params_start;char *commandline =getenv ("bootargs" );int ret; -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - theKernel = (void *)ep; + theKernel = (void *)images->ep; ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_AVR32 , &initrd_start, &initrd_end);
lib_blackfin/bootm.c +1 -18
@@ -38,29 +38,12 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], {int (*appl) (char *cmdline);char *cmdline; -ulong ep =0 ;#ifdef SHARED_RESOURCES swap_to (FLASH );#endif -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { -int ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - appl = (int (*)(char *))ep; + appl = (int (*)(char *))images->ep;printf ("Starting Kernel at = %x\n" , appl); cmdline =make_command_line ();
lib_m68k/bootm.c +1 -18
@@ -57,7 +57,6 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag,ulong cmd_start, cmd_end;ulong bootmap_base;bd_t *kbd; -ulong ep =0 ;void (*kernel) (bd_t *,ulong ,ulong ,ulong ,ulong );struct lmb *lmb = images->lmb;
@@ -94,23 +93,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, }set_clocks_in_mhz (kbd); -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - kernel = (void (*)(bd_t *,ulong ,ulong ,ulong ,ulong ))ep; + kernel = (void (*)(bd_t *,ulong ,ulong ,ulong ,ulong ))images->ep;/* find ramdisk */ ret = boot_get_ramdisk (argc, argv, images, IH_ARCH_M68K,
lib_microblaze/bootm.c +1 -18
@@ -40,25 +40,8 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],/* First parameter is mapped to $r5 for kernel boot args */ void (*theKernel) (char *);char *commandline =getenv ("bootargs" ); -ulong ep =0 ; -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { -int ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - theKernel = (void (*)(char *))ep; + theKernel = (void (*)(char *))images->ep;show_boot_progress (15 );
lib_mips/bootm.c +1 -17
@@ -49,7 +49,6 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[], bootm_headers_t *images) {ulong initrd_start, initrd_end; -ulong ep =0 ;void (*theKernel) (int ,char **,char **,int *);char *commandline =getenv ("bootargs" );char env_buf[12 ];
@@ -57,22 +56,7 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],char *cp;/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - theKernel = (void (*)(int ,char **,char **,int *))ep; + theKernel = (void (*)(int ,char **,char **,int *))images->ep; ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_MIPS , &initrd_start, &initrd_end);
lib_nios2/bootm.c +1 -19
@@ -30,25 +30,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[],bootm_headers_t *images) { -ulong ep =0 ; - -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { -int ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } -void (*kernel)(void ) = (void (*)(void ))ep; +void (*kernel)(void ) = (void (*)(void ))images->ep;/* For now we assume the Microtronix linux ... which only * needs to be called ;-)
lib_ppc/bootm.c +3 -19
@@ -79,7 +79,6 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],ulong cmd_start, cmd_end, bootmap_base;bd_t *kbd; -ulong ep =0 ;void (*kernel)(bd_t *,ulong r4,ulong r5,ulong r6,ulong r7,ulong r8,ulong r9);int ret;
@@ -90,6 +89,9 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],char *of_flat_tree =NULL ;#endif + kernel = (void (*)(bd_t *,ulong ,ulong ,ulong , +ulong ,ulong ,ulong ))images->ep; + bootmap_base =getenv_bootm_low (); bootm_size =getenv_bootm_size ();
@@ -151,24 +153,6 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],set_clocks_in_mhz (kbd); } -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } - kernel = (void (*)(bd_t *,ulong ,ulong ,ulong , -ulong ,ulong ,ulong ))ep;/* find ramdisk */ ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_PPC , &rd_data_start, &rd_data_end);
lib_sh/bootm.c +1 -18
@@ -62,26 +62,9 @@ static void hexdump (unsigned char *buf, int len)void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[],bootm_headers_t *images) { -ulong ep =0 ;char *bootargs =getenv ("bootargs" ); -/* find kernel entry point */ -if (images->legacy_hdr_valid) { - ep =image_get_ep (&images->legacy_hdr_os_copy); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { -int ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } -void (*kernel) (void ) = (void (*)(void ))ep; +void (*kernel) (void ) = (void (*)(void ))images->ep;/* Setup parameters */ memset (PARAM ,0 ,0x1000 );/* Clear zero page */
lib_sparc/bootm.c +2 -10
@@ -87,7 +87,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[], bootm_headers_t * images) {char *bootargs; -ulong ep, load; +ulong load;ulong initrd_start, initrd_end;ulong rd_data_start, rd_data_end, rd_len;unsigned int data, len, checksum;
@@ -97,17 +97,9 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],int ret;if (images->legacy_hdr_valid) { - ep =image_get_ep (images->legacy_hdr_os); load =image_get_load (images->legacy_hdr_os);#if defined(CONFIG_FIT ) } else if (images->fit_uname_os) { -int ret =fit_image_get_entry (images->fit_hdr_os, - images->fit_noffset_os, &ep); -if (ret) { -puts ("Can't get entry point property!\n" ); - goto error; - } - ret =fit_image_get_load (images->fit_hdr_os, images->fit_noffset_os, &load);if (ret) {
@@ -124,7 +116,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[], linux_hdr = (void *)load;/* */ - kernel = (void (*)(struct linux_romvec *,void *))ep; + kernel = (void (*)(struct linux_romvec *,void *))images->ep;/* check for a SPARC kernel */ if ((linux_hdr->hdr[0] != 'H') ||
Signature · 1 line
1.5.5.1
PATCH 6/15 bootm: refactor entry point code
Quoted 5 lines · Kumar Gala
Move entry point code out of each arch and into common code. Keep the entry point in the
bootm_headers_timages struct.Signed-off-by Kumar Gala <[email protected]>---
Quoted 13 lines
common/cmd_bootm.c | 31 ++++++++++++++++++++++--------- include/image.h | 2 ++ lib_arm/bootm.c | 19 +------------------ lib_avr32/bootm.c | 19 +------------------ lib_blackfin/bootm.c | 19 +------------------ lib_m68k/bootm.c | 19 +------------------ lib_microblaze/bootm.c | 19 +------------------ lib_mips/bootm.c | 18 +----------------- lib_nios2/bootm.c | 20 +------------------- lib_ppc/bootm.c | 22 +++------------------- lib_sh/bootm.c | 19 +------------------ lib_sparc/bootm.c | 12 ++---------- 12 files changed, 37 insertions(+), 182 deletions(-)
Wolfgang,
I'm hoping the bootm rework patches 06..15 are still in your queue for review?
- k
PATCH 6/15 bootm: refactor entry point code
Dear Kumar Gala,
Quoted 3 lines · In message <[email protected]> you wrote:
I'm hoping the bootm rework patches 06..15 are still in your queue for review?
Of course. I never forget anything. Never.
I... I mean... Hm. Forgot what I wanted to add...
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Use C++ to confuse your enemies; use C to produce stable code.
PATCH 6/15 bootm: refactor entry point code
Quoted 6 lines · Wolfgang Denk
Dear Kumar Gala,
Quoted 2 lines · In message <[email protected]> you wrote:
I'm hoping the bootm rework patches 06..15 are still in your queue for review?
Quoted 7 lines
Of course. I never forget anything. Never.
I... I mean... Hm. Forgot what I wanted to add...
Best regards,
Wolfgang Denk
Awww, and I was planning to horn in with an "Acked-by" to get my name in the lights. Too late now.
Seriously, I reviewed and applied the patches last night, did a smoke test (all passed), and planned to ack the changesets. Thanks for doing this work, Kumar.
Best regards,
gvb
PATCH 6/15 bootm: refactor entry point code
Dear Jerry Van Baren,
Quoted 3 lines · In message <[email protected]> you wrote:
Awww, and I was planning to horn in with an "Acked-by" to get my name in the lights. Too late now.
You will have plenty of opportunity to get your name on other patches :-)
Quoted 3 lines
Seriously, I reviewed and applied the patches last night, did a smoke test (all passed), and planned to ack the changesets. Thanks for doing this work, Kumar.
Thanks for the ACK.
Indeed I too think that this was a very important step forward, last but not least when we want to push using the device tree on more architectures. Thanks, Kumar, from me, too.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Ahead warp factor 1" - Captain Kirk
PATCH 6/15 bootm: refactor entry point code
Quoted 16 lines · Wolfgang Denk
Dear Jerry Van Baren,
Quoted 4 lines · In message <[email protected]> you wrote:
Awww, and I was planning to horn in with an "Acked-by" to get my name in
the lights. Too late now.You will have plenty of opportunity to get your name on other patches :-)
Quoted 4 lines
Seriously, I reviewed and applied the patches last night, did a smoke test (all passed), and planned to ack the changesets. Thanks for doing
this work, Kumar.
Quoted 5 lines
Thanks for the ACK.
Indeed I too think that this was a very important step forward, last but not least when we want to push using the device tree on more architectures. Thanks, Kumar, from me, too.
Now we can talk about the subcommand support for bootm, which the real functionality I want :)
- k
PATCH 7/15 bootm: refactor ramdisk locating code
In reply to Kumar GalaMove determing if we have a ramdisk and where its located into the common code. Keep track of the ramdisk start and end in the bootm_headers_t image struct.
--- common/cmd_bootm.c | 38 ++++++++++++++++++++++++++++++++++++++ include/image.h | 2 ++ lib_arm/bootm.c | 10 ++-------- lib_avr32/bootm.c | 12 +++--------- lib_i386/bootm.c | 8 +------- lib_m68k/bootm.c | 12 +++--------- lib_mips/bootm.c | 12 +++--------- lib_ppc/bootm.c | 16 +++++----------- lib_sparc/bootm.c | 17 +++-------------- 9 files changed, 60 insertions(+), 67 deletions(-)
common/cmd_bootm.c +38 -0
@@ -116,6 +116,33 @@ void __board_lmb_reserve(struct lmb *lmb) }void board_lmb_reserve (struct lmb *lmb) __attribute__((weak,alias ("__board_lmb_reserve" ))); +#if defined(__ARM__) +#define IH_INITRD_ARCH IH_ARCH_ARM +#elif defined(__avr32__) +#define IH_INITRD_ARCH IH_ARCH_AVR32 +#elif defined(__bfin__) +#define IH_INITRD_ARCH IH_ARCH_BLACKFIN +#elif defined(__I386__) +#define IH_INITRD_ARCH IH_ARCH_I386 +#elif defined(__M68K__) +#define IH_INITRD_ARCH IH_ARCH_M68K +#elif defined(__microblaze__) +#define IH_INITRD_ARCH IH_ARCH_MICROBLAZE +#elif defined(__mips__) +#define IH_INITRD_ARCH IH_ARCH_MIPS +#elif defined(__nios__) +#define IH_INITRD_ARCH IH_ARCH_NIOS +#elif defined(__nios2__) +#define IH_INITRD_ARCH IH_ARCH_NIOS2 +#elif defined(__PPC__) +#define IH_INITRD_ARCH IH_ARCH_PPC +#elif defined(__sh__) +#define IH_INITRD_ARCH IH_ARCH_SH +#elif defined(__sparc__) +#define IH_INITRD_ARCH IH_ARCH_SPARC +#else +# error Unknown CPU type +#endif /*******************************************************************/ /* bootm - boot application image from image in memory */
@@ -133,6 +160,7 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])ulong load_start, load_end;ulong mem_start;phys_size_t mem_size; +int ret;struct lmb lmb;
@@ -222,6 +250,16 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])return 1 ; } +if (os ==IH_OS_LINUX ) { +/* find ramdisk */ + ret =boot_get_ramdisk (argc, argv, &images,IH_INITRD_ARCH , + &images.rd_start, &images.rd_end); +if (ret) { +puts ("Ramdisk image is corrupt\n" ); +return 1 ; + } + } + image_start = (ulong )os_hdr; load_end =0 ; type_name =genimg_get_type_name (type);
include/image.h +2 -0
@@ -221,6 +221,8 @@ typedef struct bootm_headers {ulong ep;/* entry point of OS */ +ulong rd_start, rd_end;/* ramdisk start/end */ +int verify;/* getenv("verify")[0] != 'n' */ struct lmb *lmb;/* for memory mgmt */ } bootm_headers_t;
lib_arm/bootm.c +2 -8
@@ -61,7 +61,6 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[],bootm_headers_t *images) { -ulong initrd_start, initrd_end;bd_t *bd = gd->bd;char *s;int machid = bd->bi_arch_number;
@@ -80,11 +79,6 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],printf ("Using machid 0x%x from environment\n" , machid); } - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_ARM , - &initrd_start, &initrd_end); -if (ret) - goto error; -show_boot_progress (15 ); debug ("## Transferring control to Linux (at address %08lx) ...\n",
@@ -111,8 +105,8 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],setup_commandline_tag (bd, commandline);#endif #ifdef CONFIG_INITRD_TAG -if (initrd_start && initrd_end) -setup_initrd_tag (bd, initrd_start, initrd_end); +if (images->rd_start && images->rd_end) +setup_initrd_tag (bd, images->rd_start, images->rd_end);#endif #if defined (CONFIG_VFD ) || defined (CONFIG_LCD )setup_videolfb_tag ((gd_t *) gd);
lib_avr32/bootm.c +3 -9
@@ -176,7 +176,6 @@ static void setup_end_tag(struct tag *params)void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[],bootm_headers_t *images) { -ulong initrd_start, initrd_end;void (*theKernel)(int magic,void *tagtable);struct tag *params, *params_start;char *commandline =getenv ("bootargs" );
@@ -184,20 +183,15 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], theKernel = (void *)images->ep; - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_AVR32 , - &initrd_start, &initrd_end); -if (ret) - goto error; -show_boot_progress (15 ); params = params_start = (struct tag *)gd->bd->bi_boot_params; params =setup_start_tag (params); params =setup_memory_tags (params); -if (initrd_start) { +if (images->rd_start) { params =setup_ramdisk_tag (params, -PHYSADDR (initrd_start), -PHYSADDR (initrd_end)); +PHYSADDR (images->rd_start), +PHYSADDR (images->rd_end)); } params =setup_commandline_tag (params, commandline); params =setup_clock_tags (params);
lib_i386/bootm.c +1 -7
@@ -36,7 +36,6 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], {void *base_ptr;ulong os_data, os_len; -ulong initrd_start, initrd_end;image_header_t *hdr;int ret;#if defined(CONFIG_FIT )
@@ -44,11 +43,6 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],size_t len;#endif - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_I386 , - &initrd_start, &initrd_end); -if (ret) - goto error; -if (images->legacy_hdr_valid) { hdr = images->legacy_hdr_os;if (image_check_type (hdr,IH_TYPE_MULTI )) {
@@ -76,7 +70,7 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], } base_ptr =load_zimage ((void *)os_data, os_len, - initrd_start, initrd_end - initrd_start,0 ); + images->rd_start, images->rd_end - images->rd_start,0 );if (NULL == base_ptr) {printf ("## Kernel loading failed ...\n" );
lib_m68k/bootm.c +3 -9
@@ -50,7 +50,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, {ulong sp; -ulong rd_data_start, rd_data_end, rd_len; +ulong rd_len;ulong initrd_start, initrd_end;int ret;
@@ -95,14 +95,8 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, kernel = (void (*)(bd_t *,ulong ,ulong ,ulong ,ulong ))images->ep; -/* find ramdisk */ - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_M68K , - &rd_data_start, &rd_data_end); -if (ret) - goto error; - - rd_len = rd_data_end - rd_data_start; - ret =boot_ramdisk_high (lmb, rd_data_start, rd_len, + rd_len = images->rd_end - images->rd_start; + ret =boot_ramdisk_high (lmb, images->rd_start, rd_len, &initrd_start, &initrd_end);if (ret) goto error;
lib_mips/bootm.c +3 -9
@@ -48,7 +48,6 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);void do_bootm_linux (cmd_tbl_t * cmdtp,int flag,int argc,char *argv[],bootm_headers_t *images) { -ulong initrd_start, initrd_end;void (*theKernel) (int ,char **,char **,int *);char *commandline =getenv ("bootargs" );char env_buf[12 ];
@@ -58,11 +57,6 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],/* find kernel entry point */ theKernel = (void (*)(int ,char **,char **,int *))images->ep; - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_MIPS , - &initrd_start, &initrd_end); -if (ret) - goto error; -show_boot_progress (15 );#ifdef DEBUG
@@ -82,10 +76,10 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],linux_env_set ("memsize" , env_buf); -sprintf (env_buf,"0x%08X" , (uint )UNCACHED_SDRAM (initrd_start)); -linux_env_set ("initrd_start" , env_buf); +sprintf (env_buf,"0x%08X" , (uint )UNCACHED_SDRAM (images->rd_start)); +linux_env_set ("images->rd_start" , env_buf); -sprintf (env_buf,"0x%X" , (uint) (initrd_end - initrd_start)); +sprintf (env_buf,"0x%X" , (uint) (images->rd_end - images->rd_start));linux_env_set ("initrd_size" , env_buf);sprintf (env_buf,"0x%08X" , (uint) (gd->bd->bi_flashstart));
lib_ppc/bootm.c +5 -11
@@ -73,7 +73,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],ulong sp;ulong initrd_start, initrd_end; -ulong rd_data_start, rd_data_end, rd_len; +ulong rd_len;ulong size;phys_size_t bootm_size;
@@ -153,13 +153,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],set_clocks_in_mhz (kbd); } -/* find ramdisk */ - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_PPC , - &rd_data_start, &rd_data_end); -if (ret) - goto error; - - rd_len = rd_data_end - rd_data_start; + rd_len = images->rd_end - images->rd_start;#if defined(CONFIG_OF_LIBFDT ) ret = boot_relocate_fdt (lmb, bootmap_base,
@@ -171,7 +165,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],*/ if (of_size) {/* pass in dummy initrd info, we'll fix up later */ -if (fdt_chosen (of_flat_tree, rd_data_start, rd_data_end,0 ) <0 ) { +if (fdt_chosen (of_flat_tree, images->rd_start, images->rd_end,0 ) <0 ) {fdt_error ("/chosen node create failed" ); goto error; }
@@ -221,7 +215,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], }#endif /* CONFIG_OF_LIBFDT */ - ret =boot_ramdisk_high (lmb, rd_data_start, rd_len, &initrd_start, &initrd_end); + ret =boot_ramdisk_high (lmb, images->rd_start, rd_len, &initrd_start, &initrd_end);if (ret) goto error;
@@ -235,7 +229,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],/* Look for the dummy entry and delete it */ for (j =0 ; j < total; j++) {fdt_get_mem_rsv (of_flat_tree, j, &addr, &size); -if (addr == rd_data_start) { +if (addr == images->rd_start) {fdt_del_mem_rsv (of_flat_tree, j);break ; }
lib_sparc/bootm.c +3 -14
@@ -89,7 +89,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],char *bootargs;ulong load;ulong initrd_start, initrd_end; -ulong rd_data_start, rd_data_end, rd_len; +ulong rd_len;unsigned int data, len, checksum;unsigned int initrd_addr, kernend;void (*kernel) (struct linux_romvec *,void *);
@@ -139,19 +139,8 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],* extracted and is writeable. */ -/* -* Are we going to use an initrd image? -*/ - ret =boot_get_ramdisk (argc, argv, images,IH_ARCH_SPARC , - &rd_data_start, &rd_data_end); -if (ret) { -/* RAM disk found but was corrupt */ -puts ("RAM Disk corrupt\n" ); - goto error; - } -/* Calc length of RAM disk, if zero no ramdisk available */ - rd_len = rd_data_end - rd_data_start; + rd_len = images->rd_end - images->rd_start;if (rd_len) {
@@ -161,7 +150,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],*/ lmb_reserve (lmb,CFG_RELOC_MONITOR_BASE ,CFG_RAM_END ); - ret =boot_ramdisk_high (lmb, rd_data_start, rd_len, + ret =boot_ramdisk_high (lmb, images->rd_start, rd_len, &initrd_start, &initrd_end);if (ret) {puts ("### Failed to relocate RAM disk\n" );
Signature · 1 line
1.5.5.1
PATCH 8/15 bootm: refactor fdt locating and relocation code
Move the code that handles finding a device tree blob and relocating it (if needed) into common code so all arch's have access to it.
--- common/cmd_bootm.c | 10 + common/image.c | 502 ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/image.h | 13 ++ lib_ppc/bootm.c | 492 +-------------------------------------------------- 4 files changed, 533 insertions(+), 484 deletions(-)
common/cmd_bootm.c +10 -0
@@ -258,6 +258,16 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])puts ("Ramdisk image is corrupt\n" );return 1 ; } + +#if defined(CONFIG_OF_LIBFDT ) +/* find flattened device tree */ + ret =boot_get_fdt (flag, argc, argv, &images, + &images.ft_addr, &images.ft_len); +if (ret) { +puts ("Could not find a valid device tree\n" ); +return 1 ; + } +#endif } image_start = (ulong )os_hdr;
common/image.c +502 -0
508 lines not on this page · raw message
include/image.h +13 -0
@@ -223,6 +223,11 @@ typedef struct bootm_headers {ulong rd_start, rd_end;/* ramdisk start/end */ +#ifdef CONFIG_OF_LIBFDT +char *ft_addr;/* flat dev tree address */ +#endif +ulong ft_len;/* length of flat device tree */ +int verify;/* getenv("verify")[0] != 'n' */ struct lmb *lmb;/* for memory mgmt */ } bootm_headers_t;
@@ -273,6 +278,14 @@ ulong genimg_get_image (ulong img_addr);int boot_get_ramdisk (int argc,char *argv[],bootm_headers_t *images,uint8_t arch,ulong *rd_start,ulong *rd_end); + +#ifdef CONFIG_OF_LIBFDT +int boot_get_fdt (int flag,int argc,char *argv[],bootm_headers_t *images, +char **of_flat_tree,ulong *of_size); +int boot_relocate_fdt (struct lmb *lmb,ulong bootmap_base, +char **of_flat_tree,ulong *of_size); +#endif +#if defined(CONFIG_PPC ) || defined(CONFIG_M68K )int boot_ramdisk_high (struct lmb *lmb,ulong rd_data,ulong rd_len,ulong *initrd_start,ulong *initrd_end);
lib_ppc/bootm.c +8 -484
534 lines not on this page · raw message
Signature · 1 line
1.5.5.1
PATCH 9/15 bootm: Set working fdt address as part of the bootm flow
Set the fdt working address so "fdt FOO" commands can be used as part of the bootm flow. Also set an the environment variable "fdtaddr" with the value.
--- common/cmd_bootm.c | 8 ++++++++ common/cmd_fdt.c | 14 +++++++++++++- common/image.c | 1 + include/fdt_support.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletions(-)
common/cmd_bootm.c +8 -0
@@ -44,6 +44,12 @@#include <hush.h> #endif +#if defined(CONFIG_OF_LIBFDT ) +#include <fdt.h> +#include <libfdt.h> +#include <fdt_support.h> +#endif +DECLARE_GLOBAL_DATA_PTR ;extern int gunzip (void *dst,int dstlen,unsigned char *src,unsigned long *lenp);
@@ -267,6 +273,8 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])puts ("Could not find a valid device tree\n" ); return 1; } + +set_working_fdt_addr (images.ft_addr);#endif }
common/cmd_fdt.c +13 -1
@@ -50,6 +50,16 @@ static int fdt_print(const char *pathp, char *prop, int depth);*/ struct fdt_header *working_fdt; +void set_working_fdt_addr (void *addr) +{ +char buf[17 ]; + + working_fdt = addr; + +sprintf (buf,"%lx" , (unsigned long )addr); +setenv ("fdtaddr" , buf); +} +/* * Flattened Device Tree command, see the help for parameter definitions. */
@@ -64,6 +74,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])* Set the address of the fdt ********************************************************************/ if (argv[1 ][0 ] =='a' ) { +unsigned long addr;/* * Set the address [and length] of the fdt. */
@@ -75,7 +86,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])return 0 ; } - working_fdt = (struct fdt_header *)simple_strtoul (argv[2 ],NULL ,16 ); + addr =simple_strtoul (argv[2 ],NULL ,16 ); +set_working_fdt_addr ((void *)addr);if (!fdt_valid ()) {return 1 ;
common/image.c +1 -0
@@ -1245,6 +1245,7 @@ int boot_relocate_fdt (struct lmb *lmb, ulong bootmap_base, *of_size = of_len; } +set_working_fdt_addr (*of_flat_tree);return 0 ; error:
include/fdt_support.h +2 -0
@@ -68,5 +68,7 @@ void ft_cpu_setup(void *blob, bd_t *bd);void ft_pci_setup (void *blob,bd_t *bd);#endif +void set_working_fdt_addr (void *addr); +#endif /* ifdef CONFIG_OF_LIBFDT */ #endif /* ifndef __FDT_SUPPORT_H */
Signature · 1 line
1.5.5.1
PATCH 10/15 bootm: move lmb into the bootm_headers_t structure
To allow for persistent state between future bootm subcommands we need the lmb to exist in a global state. Moving it into the bootm_headers_t allows us to do that.
--- common/cmd_bootm.c | 11 ++++------- include/image.h | 4 +++- lib_m68k/bootm.c | 2 +- lib_ppc/bootm.c | 2 +- lib_sparc/bootm.c | 2 +- 5 files changed, 10 insertions(+), 11 deletions(-)
common/cmd_bootm.c +4 -7
@@ -168,20 +168,17 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])phys_size_t mem_size;int ret; -struct lmb lmb; -memset ((void *)&images,0 ,sizeof (images)); images.verify =getenv_yesno ("verify" ); - images.lmb = &lmb; -lmb_init (&lmb); +lmb_init (&images.lmb); mem_start =getenv_bootm_low (); mem_size =getenv_bootm_size (); -lmb_add (&lmb, (phys_addr_t )mem_start, mem_size); +lmb_add (&images.lmb, (phys_addr_t )mem_start, mem_size); -board_lmb_reserve (&lmb); +board_lmb_reserve (&images.lmb);/* get kernel image header, start address and length */ os_hdr = boot_get_kernel (cmdtp, flag, argc, argv,
@@ -387,7 +384,7 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])show_boot_progress (8 ); -lmb_reserve (&lmb, load_start, (load_end - load_start)); +lmb_reserve (&images.lmb, load_start, (load_end - load_start));switch (os) {default :/* handled by (original) Linux case */
include/image.h +3 -1
@@ -229,7 +229,9 @@ typedef struct bootm_headers {ulong ft_len;/* length of flat device tree */ int verify;/* getenv("verify")[0] != 'n' */ -struct lmb *lmb;/* for memory mgmt */ +#ifndef USE_HOSTCC +struct lmb lmb;/* for memory mgmt */ +#endif } bootm_headers_t;/*
lib_m68k/bootm.c +1 -1
@@ -58,7 +58,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag,ulong bootmap_base;bd_t *kbd;void (*kernel) (bd_t *,ulong ,ulong ,ulong ,ulong ); -struct lmb *lmb = images->lmb; +struct lmb *lmb = &images->lmb; bootmap_base =getenv_bootm_low ();
lib_ppc/bootm.c +1 -1
@@ -73,7 +73,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], ulong r7, ulong r8, ulong r9);int ret;ulong of_size = images->ft_len; -struct lmb *lmb = images->lmb; +struct lmb *lmb = &images->lmb;#if defined(CONFIG_OF_LIBFDT )char *of_flat_tree = images->ft_addr;
lib_sparc/bootm.c +1 -1
@@ -93,7 +93,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],unsigned int data, len, checksum;unsigned int initrd_addr, kernend;void (*kernel) (struct linux_romvec *,void *); -struct lmb *lmb = images->lmb; +struct lmb *lmb = &images->lmb;int ret;if (images->legacy_hdr_valid) {
Signature · 1 line
1.5.5.1
PATCH 11/15 bootm: refactor image detection and os load steps
Created a bootm_start() that handles the parsing and detection of all the images that will be used by the bootm command (OS, ramdisk, fdt). As part of this we now tract all the relevant image offsets in the bootm_headers_t struct. This will allow us to have all the needed state for future sub-commands and lets us reduce a bit of arch specific code on SPARC.
Created a bootm_load_os() that deals with decompression and loading the OS image.
--- common/cmd_bootm.c | 216 ++++++++++++++++++++++++++++++---------------------- include/image.h | 9 ++ lib_sparc/bootm.c | 19 +----- 3 files changed, 136 insertions(+), 108 deletions(-)
common/cmd_bootm.c +126 -90
@@ -150,22 +150,11 @@ void board_lmb_reserve(struct lmb *lmb) __attribute__((weak, alias("__board_lmb_# error Unknown CPU type#endif -/*******************************************************************/ -/* bootm - boot application image from image in memory */ -/*******************************************************************/ -int do_bootm (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]) +static int bootm_start (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]) { -ulong iflag; -const char *type_name; -uint unc_len =CFG_BOOTM_LEN ; -uint8_t comp, type, os; - -void *os_hdr; -ulong os_data, os_len; -ulong image_start, image_end; -ulong load_start, load_end;ulong mem_start;phys_size_t mem_size; +void *os_hdr;int ret;memset ((void *)&images,0 ,sizeof (images));
@@ -182,8 +171,8 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])/* get kernel image header, start address and length */ os_hdr =boot_get_kernel (cmdtp, flag, argc, argv, - &images, &os_data, &os_len); -if (os_len ==0 ) { + &images, &images.os.image_start, &images.os.image_len); +if (images.os.image_len ==0 ) {puts ("ERROR: can't get kernel image!\n" );return 1 ; }
@@ -191,40 +180,40 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])/* get image parameters */ switch (genimg_get_format (os_hdr)) {case IMAGE_FORMAT_LEGACY : - type =image_get_type (os_hdr); - comp =image_get_comp (os_hdr); - os =image_get_os (os_hdr); + images.os.type =image_get_type (os_hdr); + images.os.comp =image_get_comp (os_hdr); + images.os.os =image_get_os (os_hdr); - image_end =image_get_image_end (os_hdr); - load_start =image_get_load (os_hdr); + images.os.end =image_get_image_end (os_hdr); + images.os.load =image_get_load (os_hdr);break ;#if defined(CONFIG_FIT )case IMAGE_FORMAT_FIT :if (fit_image_get_type (images.fit_hdr_os, - images.fit_noffset_os, &type)) { + images.fit_noffset_os, &images.os.type)) {puts ("Can't get image type!\n" );show_boot_progress (-109 );return 1 ; }if (fit_image_get_comp (images.fit_hdr_os, - images.fit_noffset_os, &comp)) { + images.fit_noffset_os, &images.os.comp)) {puts ("Can't get image compression!\n" );show_boot_progress (-110 );return 1 ; }if (fit_image_get_os (images.fit_hdr_os, - images.fit_noffset_os, &os)) { + images.fit_noffset_os, &images.os.os)) {puts ("Can't get image OS!\n" );show_boot_progress (-111 );return 1 ; } - image_end =fit_get_end (images.fit_hdr_os); + images.os.end =fit_get_end (images.fit_hdr_os);if (fit_image_get_load (images.fit_hdr_os, images.fit_noffset_os, - &load_start)) { + &images.os.load)) {puts ("Can't get image load address!\n" );show_boot_progress (-112 );return 1 ;
@@ -253,7 +242,7 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])return 1 ; } -if (os ==IH_OS_LINUX ) { +if (images.os.os ==IH_OS_LINUX ) {/* find ramdisk */ ret =boot_get_ramdisk (argc, argv, &images,IH_INITRD_ARCH , &images.rd_start, &images.rd_end);
@@ -275,64 +264,52 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])#endif } - image_start = (ulong )os_hdr; - load_end =0 ; - type_name =genimg_get_type_name (type); + images.os.start = (ulong )os_hdr; + images.valid =1 ; -/* -* We have reached the point of no return: we are going to -* overwrite all exception vector code, so we cannot easily -* recover from any failures any more... -*/ - iflag =disable_interrupts (); - -#if defined(CONFIG_CMD_USB ) -/* -* turn off USB to prevent the host controller from writing to the -* SDRAM while Linux is booting. This could happen (at least for OHCI -* controller), because the HCCA (Host Controller Communication Area) -* lies within the SDRAM and the host controller writes continously to -* this area (as busmaster!). The HccaFrameNumber is for example -* updated every 1 ms within the HCCA structure in SDRAM! For more -* details see the OpenHCI specification. -*/ -usb_stop (); -#endif +return 0 ; +} +#define BOOTM_ERR_RESET -1 +#define BOOTM_ERR_OVERLAP -2 +#define BOOTM_ERR_UNIMPLEMENTED -3 +static int bootm_load_os (image_info_t os,ulong *load_end,int boot_progress) +{ +uint8_t comp = os.comp; +ulong load = os.load; +ulong blob_start = os.start; +ulong blob_end = os.end; +ulong image_start = os.image_start; +ulong image_len = os.image_len; +uint unc_len =CFG_BOOTM_LEN ; -#ifdef CONFIG_AMIGAONEG3SE -/* -* We've possible left the caches enabled during -* bios emulation, so turn them off again -*/ -icache_disable (); -dcache_disable (); -#endif +const char *type_name =genimg_get_type_name (os.type);switch (comp) {case IH_COMP_NONE : -if (load_start == (ulong )os_hdr) { +if (load == blob_start) {printf (" XIP %s ... " , type_name); }else {printf (" Loading %s ... " , type_name); -memmove_wd ((void *)load_start, - (void *)os_data, os_len,CHUNKSZ ); +memmove_wd ((void *)load, + (void *)image_start, image_len,CHUNKSZ ); } - load_end = load_start + os_len; + *load_end = load + image_len;puts ("OK\n" );break ;case IH_COMP_GZIP :printf (" Uncompressing %s ... " , type_name); -if (gunzip ((void *)load_start, unc_len, - (uchar *)os_data, &os_len) !=0 ) { +if (gunzip ((void *)load, unc_len, + (uchar *)image_start, &image_len) !=0 ) {puts ("GUNZIP: uncompress or overwrite error " "- must RESET board to recover\n" ); -show_boot_progress (-6 ); -do_reset (cmdtp, flag, argc, argv); +if (boot_progress) +show_boot_progress (-6 ); +return BOOTM_ERR_RESET ; } - load_end = load_start + os_len; + *load_end = load + image_len;break ;#ifdef CONFIG_BZIP2 case IH_COMP_BZIP2 :
@@ -342,51 +319,110 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])* use slower decompression algorithm which requires * at most 2300 KB of memory. */ -int i =BZ2_bzBuffToBuffDecompress ((char *)load_start, - &unc_len, (char *)os_data, os_len, +int i =BZ2_bzBuffToBuffDecompress ((char *)load, + &unc_len, (char *)image_start, image_len,CFG_MALLOC_LEN < (4096 *1024 ),0 );if (i !=BZ_OK ) {printf ("BUNZIP2: uncompress or overwrite error %d " "- must RESET board to recover\n" , i); -show_boot_progress (-6 ); -do_reset (cmdtp, flag, argc, argv); +if (boot_progress) +show_boot_progress (-6 ); +return BOOTM_ERR_RESET ; } - load_end = load_start + unc_len; + *load_end = load + unc_len;break ;#endif /* CONFIG_BZIP2 */ default : -if (iflag) -enable_interrupts ();printf ("Unimplemented compression type %d\n" , comp); -show_boot_progress (-7 ); -return 1 ; +return BOOTM_ERR_UNIMPLEMENTED ; }puts ("OK\n" ); -debug (" kernel loaded at 0x%08lx, end = 0x%08lx\n" , load_start, load_end); -show_boot_progress (7 ); +debug (" kernel loaded@0x%08lx, end = 0x%08lx\n" , load, load_end); +if (boot_progress) +show_boot_progress (7 ); -if ((load_start < image_end) && (load_end > image_start)) { -debug ("image_start = 0x%lX, image_end = 0x%lx\n" , image_start, image_end); -debug ("load_start = 0x%lx, load_end = 0x%lx\n" , load_start, load_end); +if ((load < blob_end) && (*load_end > blob_start)) { +debug ("images.os.start = 0x%lX, images.os.end = 0x%lx\n" , blob_start, blob_end); +debug ("images.os.load = 0x%lx, load_end = 0x%lx\n" , load, load_end); -if (images.legacy_hdr_valid) { -if (image_get_type (&images.legacy_hdr_os_copy) ==IH_TYPE_MULTI ) -puts ("WARNING: legacy format multi component " -"image overwritten\n" ); - }else { -puts ("ERROR: new format image overwritten - " -"must RESET the board to recover\n" ); -show_boot_progress (-113 ); +return BOOTM_ERR_OVERLAP ; + } + +return 0 ; +} + +/*******************************************************************/ +/* bootm - boot application image from image in memory */ +/*******************************************************************/ +int do_bootm (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]) +{ + +ulong iflag; +ulong load_end =0 ; +int ret; + +bootm_start (cmdtp, flag, argc, argv); + +/* +* We have reached the point of no return: we are going to +* overwrite all exception vector code, so we cannot easily +* recover from any failures any more... +*/ + iflag =disable_interrupts (); + +#if defined(CONFIG_CMD_USB ) +/* +* turn off USB to prevent the host controller from writing to the +* SDRAM while Linux is booting. This could happen (at least for OHCI +* controller), because the HCCA (Host Controller Communication Area) +* lies within the SDRAM and the host controller writes continously to +* this area (as busmaster!). The HccaFrameNumber is for example +* updated every 1 ms within the HCCA structure in SDRAM! For more +* details see the OpenHCI specification. +*/ +usb_stop (); +#endif + +#ifdef CONFIG_AMIGAONEG3SE +/* +* We've possible left the caches enabled during +* bios emulation, so turn them off again +*/ +icache_disable (); +dcache_disable (); +#endif + + ret =bootm_load_os (images.os, &load_end,1 ); + +if (ret <0 ) { +if (ret ==BOOTM_ERR_RESET )do_reset (cmdtp, flag, argc, argv); +if (ret ==BOOTM_ERR_OVERLAP ) { +if (images.legacy_hdr_valid) { +if (image_get_type (&images.legacy_hdr_os_copy) ==IH_TYPE_MULTI ) +puts ("WARNING: legacy format multi component " +"image overwritten\n" ); + }else { +puts ("ERROR: new format image overwritten - " +"must RESET the board to recover\n" ); +show_boot_progress (-113 ); +do_reset (cmdtp, flag, argc, argv); + } + } +if (ret ==BOOTM_ERR_UNIMPLEMENTED ) { +if (iflag) +enable_interrupts (); +show_boot_progress (-7 ); +return 1 ; } } -show_boot_progress (8 ); +lmb_reserve (&images.lmb, images.os.load, (load_end - images.os.load)); -lmb_reserve (&images.lmb, load_start, (load_end - load_start)); +show_boot_progress (8 ); -switch (os) { +switch (images.os.os) {default :/* handled by (original) Linux case */ case IH_OS_LINUX :#ifdef CONFIG_SILENT_CONSOLE
include/image.h +9 -0
@@ -187,6 +187,13 @@ typedef struct image_header {uint8_t ih_name[IH_NMLEN ];/* Image Name */ } image_header_t; +typedef struct image_info { +ulong start, end;/* start/end of blob */ +ulong image_start, image_len;/* start of image within blob, len of image */ +ulong load;/* load addr for the image */ +uint8_t comp, type, os;/* compression, type of image, os type */ +}image_info_t ; +/* * Legacy and FIT format headers used by do_bootm() and do_bootm_<os>() * routines.
@@ -219,6 +226,7 @@ typedef struct bootm_headers {#endif #endif +image_info_t os;/* os image info */ ulong ep;/* entry point of OS */ ulong rd_start, rd_end;/* ramdisk start/end */
@@ -229,6 +237,7 @@ typedef struct bootm_headers {ulong ft_len;/* length of flat device tree */ int verify;/* getenv("verify")[0] != 'n' */ +int valid;/* set to 1 if we've set values in the header */ #ifndef USE_HOSTCC struct lmb lmb;/* for memory mgmt */ #endif
lib_sparc/bootm.c +1 -18
@@ -87,7 +87,6 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[], bootm_headers_t * images) {char *bootargs; -ulong load;ulong initrd_start, initrd_end;ulong rd_len;unsigned int data, len, checksum;
@@ -96,24 +95,8 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],struct lmb *lmb = &images->lmb;int ret; -if (images->legacy_hdr_valid) { - load =image_get_load (images->legacy_hdr_os); -#if defined(CONFIG_FIT ) - } else if (images->fit_uname_os) { - ret =fit_image_get_load (images->fit_hdr_os, - images->fit_noffset_os, &load); -if (ret) { -puts ("Can't get load address property!\n" ); - goto error; - } -#endif - }else { -puts ("Could not find kernel entry point!\n" ); - goto error; - } -/* Get virtual address of kernel start */ - linux_hdr = (void *)load; + linux_hdr = (void *)images->os.load;/* */ kernel = (void (*)(struct linux_romvec *,void *))images->ep;
Signature · 1 line
1.5.5.1
PATCH 12/15 fdt: refactor fdt resize code
Move the fdt resizing code out of ppc specific boot code and into common fdt support code.
--- common/fdt_support.c | 39 +++++++++++++++++++++++++++++++++++++++ include/fdt_support.h | 1 + lib_ppc/bootm.c | 32 ++++---------------------------- 3 files changed, 44 insertions(+), 28 deletions(-)
common/fdt_support.c +39 -0
@@ -529,3 +529,42 @@ void fdt_fixup_crypto_node(void *blob, int sec_rev) fdt_strerror(err)); }#endif /* defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) */ + +/* Resize the fdt to its actual size + a bit of padding */ +int fdt_resize (void *blob) +{ +int i; +uint64_t addr, size; +int total, ret; +uint actualsize; + +if (!blob) +return 0 ; + + total =fdt_num_mem_rsv (blob); +for (i =0 ; i < total; i++) { +fdt_get_mem_rsv (blob, i, &addr, &size); +if (addr == (uint64_t )(u32 )blob) { +fdt_del_mem_rsv (blob, i); +break ; + } + } + +/* Calculate the actual size of the fdt */ + actualsize =fdt_off_dt_strings (blob) + +fdt_size_dt_strings (blob); + +/* Make it so the fdt ends on a page boundary */ + actualsize =ALIGN (actualsize,0x1000 ); + actualsize = actualsize - ((uint )blob &0xfff ); + +/* Change the fdt header to reflect the correct size */ +fdt_set_totalsize (blob, actualsize); + +/* Add the new reservation */ + ret =fdt_add_mem_rsv (blob, (uint )blob, actualsize); +if (ret <0 ) +return ret; + +return actualsize; +}
include/fdt_support.h +1 -0
@@ -69,6 +69,7 @@ void ft_pci_setup(void *blob, bd_t *bd);#endif void set_working_fdt_addr (void *addr); +int fdt_resize (void *blob);#endif /* ifdef CONFIG_OF_LIBFDT */ #endif /* ifndef __FDT_SUPPORT_H */
lib_ppc/bootm.c +4 -28
@@ -162,38 +162,14 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],/* Fixup the fdt memreserve now that we know how big it is */ if (of_flat_tree) { -int j; -uint64_t addr, size; -int total =fdt_num_mem_rsv (of_flat_tree); -uint actualsize; - -for (j =0 ; j < total; j++) { -fdt_get_mem_rsv (of_flat_tree, j, &addr, &size); -if (addr == (uint64_t )(u32 )of_flat_tree) { -fdt_del_mem_rsv (of_flat_tree, j); -break ; - } - } -/* Delete the old LMB reservation */ lmb_free (lmb, (phys_addr_t )(u32 )of_flat_tree, (phys_size_t )fdt_totalsize (of_flat_tree)); -/* Calculate the actual size of the fdt */ - actualsize =fdt_off_dt_strings (of_flat_tree) + -fdt_size_dt_strings (of_flat_tree); - -/* Make it so the fdt ends on a page boundary */ - actualsize =ALIGN (actualsize,0x1000 ); - actualsize = actualsize - ((uint )of_flat_tree &0xfff ); - -/* Change the fdt header to reflect the correct size */ -fdt_set_totalsize (of_flat_tree, actualsize); - of_size = actualsize; - -/* Add the new reservation */ - ret =fdt_add_mem_rsv (of_flat_tree, (uint )of_flat_tree, - of_size); + ret =fdt_resize (of_flat_tree); +if (ret <0 ) + goto error; + of_size = ret;/* Create a new LMB reservation */ lmb_reserve (lmb, (ulong )of_flat_tree, of_size);
Signature · 1 line
1.5.5.1
PATCH 13/15 fdt: refactor initrd related code
Created a new fdt_initrd() to deal with setting the initrd properties in the device tree and fixing up the mem reserve. We can use this both in the choosen node handling and lets us remove some duplicated code when we fixup the initrd info in bootm on PPC.
--- common/fdt_support.c | 109 ++++++++++++++++++++++++++++++------------------- include/fdt_support.h | 1 + lib_ppc/bootm.c | 28 +------------ 3 files changed, 70 insertions(+), 68 deletions(-)
common/fdt_support.c +67 -42
@@ -99,44 +99,85 @@ static int fdt_fixup_stdout(void *fdt, int chosenoff) }#endif -int fdt_chosen (void *fdt,ulong initrd_start,ulong initrd_end,int force) +int fdt_initrd (void *fdt,ulong initrd_start,ulong initrd_end,int force) {int nodeoffset; -int err; -u32 tmp;/* used to set 32 bit integer properties */ -char *str;/* used to set string properties */ +int err, j, total; +u32 tmp;const char *path; +uint64_t addr, size; - err =fdt_check_header (fdt); -if (err <0 ) { -printf ("fdt_chosen: %s\n" ,fdt_strerror (err)); -return err; +/* Find the "chosen" node. */ + nodeoffset =fdt_path_offset (fdt,"/chosen" ); + +/* If there is no "chosen" node in the blob return */ +if (nodeoffset <0 ) { +printf ("fdt_initrd: %s\n" ,fdt_strerror (nodeoffset)); +return nodeoffset; } -if (initrd_start && initrd_end) { -uint64_t addr, size; -int total =fdt_num_mem_rsv (fdt); -int j; +/* just return if initrd_start/end aren't valid */ +if ((initrd_start ==0 ) || (initrd_end ==0 )) +return 0 ; -/* -* Look for an existing entry and update it. If we don't find -* the entry, we will j be the next available slot. -*/ -for (j =0 ; j < total; j++) { - err =fdt_get_mem_rsv (fdt, j, &addr, &size); -if (addr == initrd_start) { -fdt_del_mem_rsv (fdt, j); -break ; - } + total =fdt_num_mem_rsv (fdt); + +/* +* Look for an existing entry and update it. If we don't find +* the entry, we will j be the next available slot. +*/ +for (j =0 ; j < total; j++) { + err =fdt_get_mem_rsv (fdt, j, &addr, &size); +if (addr == initrd_start) { +fdt_del_mem_rsv (fdt, j); +break ; } + } - err =fdt_add_mem_rsv (fdt, initrd_start, initrd_end - initrd_start +1 ); + err =fdt_add_mem_rsv (fdt, initrd_start, initrd_end - initrd_start +1 ); +if (err <0 ) { +printf ("fdt_initrd: %s\n" ,fdt_strerror (err)); +return err; + } + + path =fdt_getprop (fdt, nodeoffset,"linux,initrd-start" ,NULL ); +if ((path ==NULL ) || force) { + tmp =__cpu_to_be32 (initrd_start); + err =fdt_setprop (fdt, nodeoffset, +"linux,initrd-start" , &tmp,sizeof (tmp)); +if (err <0 ) { +printf ("WARNING: " +"could not set linux,initrd-start %s.\n" , +fdt_strerror (err)); +return err; + } + tmp =__cpu_to_be32 (initrd_end); + err =fdt_setprop (fdt, nodeoffset, +"linux,initrd-end" , &tmp,sizeof (tmp));if (err <0 ) { -printf ("fdt_chosen: %s\n" ,fdt_strerror (err)); +printf ("WARNING: could not set linux,initrd-end %s.\n" , +fdt_strerror (err)); +return err; } } +return 0 ; +} + +int fdt_chosen (void *fdt,ulong initrd_start,ulong initrd_end,int force) +{ +int nodeoffset; +int err; +char *str;/* used to set string properties */ +const char *path; + + err =fdt_check_header (fdt); +if (err <0 ) { +printf ("fdt_chosen: %s\n" ,fdt_strerror (err)); +return err; + } +/* * Find the "chosen" node. */
@@ -173,24 +214,8 @@ int fdt_chosen(void *fdt, ulong initrd_start, ulong initrd_end, int force) fdt_strerror(err)); } } -if (initrd_start && initrd_end) { - path =fdt_getprop (fdt, nodeoffset,"linux,initrd-start" ,NULL ); -if ((path ==NULL ) || force) { - tmp =__cpu_to_be32 (initrd_start); - err =fdt_setprop (fdt, nodeoffset, -"linux,initrd-start" , &tmp,sizeof (tmp)); -if (err <0 ) -printf ("WARNING: " -"could not set linux,initrd-start %s.\n" , -fdt_strerror (err)); - tmp =__cpu_to_be32 (initrd_end); - err =fdt_setprop (fdt, nodeoffset, -"linux,initrd-end" , &tmp,sizeof (tmp)); -if (err <0 ) -printf ("WARNING: could not set linux,initrd-end %s.\n" , -fdt_strerror (err)); - } - } + +fdt_initrd (fdt, initrd_start, initrd_end, force);#ifdef CONFIG_OF_STDOUT_VIA_ALIAS path =fdt_getprop (fdt, nodeoffset,"linux,stdout-path" ,NULL );
include/fdt_support.h +1 -0
@@ -29,6 +29,7 @@#include <fdt.h> int fdt_chosen (void *fdt,ulong initrd_start,ulong initrd_end,int force); +int fdt_initrd (void *fdt,ulong initrd_start,ulong initrd_end,int force);void do_fixup_by_path (void *fdt,const char *path,const char *prop,const void *val,int len,int create); void do_fixup_by_path_u32(void *fdt, const char *path, const char *prop,
lib_ppc/bootm.c +2 -26
@@ -182,32 +182,8 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],#if defined(CONFIG_OF_LIBFDT )/* fixup the initrd now that we know where it should be */ -if ((of_flat_tree) && (initrd_start && initrd_end)) { -uint64_t addr, size; -int total =fdt_num_mem_rsv (of_flat_tree); -int j; - -/* Look for the dummy entry and delete it */ -for (j =0 ; j < total; j++) { -fdt_get_mem_rsv (of_flat_tree, j, &addr, &size); -if (addr == images->rd_start) { -fdt_del_mem_rsv (of_flat_tree, j); -break ; - } - } - - ret =fdt_add_mem_rsv (of_flat_tree, initrd_start, - initrd_end - initrd_start +1 ); -if (ret <0 ) { -printf ("fdt_chosen: %s\n" ,fdt_strerror (ret)); - goto error; - } - -do_fixup_by_path_u32 (of_flat_tree,"/chosen" , -"linux,initrd-start" , initrd_start,0 ); -do_fixup_by_path_u32 (of_flat_tree,"/chosen" , -"linux,initrd-end" , initrd_end,0 ); - } +if ((of_flat_tree) && (initrd_start && initrd_end)) +fdt_initrd (of_flat_tree, initrd_start, initrd_end,1 );#endif debug ("## Transferring control to Linux (at address %08lx) ...\n" , (ulong )kernel);
Signature · 1 line
1.5.5.1
PATCH 14/15 fdt: Added resize command
Resize the fdt to size + padding to 4k boundary
--- common/cmd_fdt.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
common/cmd_fdt.c +7 -1
@@ -451,7 +451,12 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) }fdt_chosen (working_fdt, initrd_start, initrd_end,1 ); - }else { + } +/* resize the fdt */ +else if (strncmp (argv[1 ],"re" ,2 ) ==0 ) { +fdt_resize (working_fdt); + } +else {/* Unrecognized command */ printf ("Usage:\n%s\n" , cmdtp->usage);return 1 ;
@@ -819,6 +824,7 @@ U_BOOT_CMD( "fdt boardsetup - Do board-specific set up\n"#endif "fdt move <fdt> <newaddr> <length> - Copy the fdt to <addr> and make it active\n" +"fdt resize - Resize fdt to size + padding to 4k addr\n" "fdt print <path> [<prop>] - Recursive print starting at <path>\n" "fdt list <path> [<prop>] - Print one level starting at <path>\n" "fdt set <path> <prop> [<val>] - Set <property> [to <val>]\n"
Signature · 1 line
1.5.5.1
PATCH 15/15 bootm: refactor do_reset and os boot function args
There is no need for each OS specific function to call do_reset() we can just do it once in bootm. This means its feasible on an error for the os boot function to return.
Also, remove passing in cmd_tbl_t as its not needed by the OS boot functions. flag isn't currently used but might be in the future so we left it alone.
--- common/cmd_bootm.c | 67 +++++++++++++++++++++++++----------------------- lib_arm/bootm.c | 10 +----- lib_avr32/bootm.c | 10 +----- lib_blackfin/bootm.c | 11 ++----- lib_i386/bootm.c | 9 +----- lib_m68k/bootm.c | 10 +----- lib_microblaze/bootm.c | 10 +----- lib_mips/bootm.c | 12 +------- lib_nios/bootm.c | 4 +- lib_nios2/bootm.c | 9 +----- lib_ppc/bootm.c | 11 +++----- lib_sh/bootm.c | 9 +----- lib_sparc/bootm.c | 7 +--- 13 files changed, 62 insertions(+), 117 deletions(-)
common/cmd_bootm.c +35 -32
@@ -92,8 +92,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);* - loaded (first part of) image to header load address, * - disabled interrupts. */ -typedef void boot_os_fn (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +typedef int boot_os_fn (int flag,int argc,char *argv[],bootm_headers_t *images);/* pointers to os/initrd/fdt */ extern boot_os_fn do_bootm_linux;
@@ -428,36 +427,36 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])#ifdef CONFIG_SILENT_CONSOLE fixup_silent_linux ();#endif -do_bootm_linux (cmdtp, flag, argc, argv, &images); +do_bootm_linux (0 , argc, argv, &images);break ;case IH_OS_NETBSD : -do_bootm_netbsd (cmdtp, flag, argc, argv, &images); +do_bootm_netbsd (0 , argc, argv, &images);break ;#ifdef CONFIG_LYNXKDI case IH_OS_LYNXOS : -do_bootm_lynxkdi (cmdtp, flag, argc, argv, &images); +do_bootm_lynxkdi (0 , argc, argv, &images);break ;#endif case IH_OS_RTEMS : -do_bootm_rtems (cmdtp, flag, argc, argv, &images); +do_bootm_rtems (0 , argc, argv, &images);break ;#if defined(CONFIG_CMD_ELF )case IH_OS_VXWORKS : -do_bootm_vxworks (cmdtp, flag, argc, argv, &images); +do_bootm_vxworks (0 , argc, argv, &images);break ;case IH_OS_QNX : -do_bootm_qnxelf (cmdtp, flag, argc, argv, &images); +do_bootm_qnxelf (0 , argc, argv, &images);break ;#endif #ifdef CONFIG_ARTOS case IH_OS_ARTOS : -do_bootm_artos (cmdtp, flag, argc, argv, &images); +do_bootm_artos (0 , argc, argv, &images);break ;#endif }
@@ -465,10 +464,8 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])show_boot_progress (-9 );#ifdef DEBUG puts ("\n## Control returned to monitor - resetting...\n" ); -do_reset (cmdtp, flag, argc, argv);#endif -if (iflag) -enable_interrupts (); +do_reset (cmdtp, flag, argc, argv);return 1 ; }
@@ -983,8 +980,7 @@ static void fixup_silent_linux ()/* OS booting routines */ /*******************************************************************/ -static void do_bootm_netbsd (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_netbsd (int flag,int argc,char *argv[],bootm_headers_t *images) {void (*loader)(bd_t *,image_header_t *,char *,char *);
@@ -996,7 +992,7 @@ static void do_bootm_netbsd (cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("NetBSD" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif hdr = images->legacy_hdr_os;
@@ -1063,11 +1059,12 @@ static void do_bootm_netbsd (cmd_tbl_t *cmdtp, int flag,* r6: boot args string */ (*loader) (gd->bd, os_hdr, consdev, cmdline); + +return 1 ; }#ifdef CONFIG_LYNXKDI -static void do_bootm_lynxkdi (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_lynxkdi (int flag,int argc,char *argv[],bootm_headers_t *images) {image_header_t *hdr = &images->legacy_hdr_os_copy;
@@ -1075,16 +1072,17 @@ static void do_bootm_lynxkdi (cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("Lynx" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif lynxkdi_boot ((image_header_t *)hdr); + + return 1; }#endif /* CONFIG_LYNXKDI */ -static void do_bootm_rtems (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_rtems (int flag,int argc,char *argv[],bootm_headers_t *images) {void (*entry_point)(bd_t *);
@@ -1092,7 +1090,7 @@ static void do_bootm_rtems (cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("RTEMS" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif
@@ -1108,11 +1106,12 @@ static void do_bootm_rtems (cmd_tbl_t *cmdtp, int flag,* r3: ptr to board info data */ (*entry_point)(gd->bd); + +return 1 ; }#if defined(CONFIG_CMD_ELF ) -static void do_bootm_vxworks (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_vxworks (int flag,int argc,char *argv[],bootm_headers_t *images) {char str[80 ];
@@ -1120,17 +1119,18 @@ static void do_bootm_vxworks (cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("VxWorks" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif sprintf (str,"%lx" , images->ep);/* write entry-point into string */ setenv ("loadaddr" , str); -do_bootvx (cmdtp,0 ,0 ,NULL ); +do_bootvx (NULL ,0 ,0 ,NULL ); + +return 1 ; } -static void do_bootm_qnxelf (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_qnxelf (int flag,int argc,char *argv[],bootm_headers_t *images) {char *local_args[2 ];
@@ -1139,20 +1139,21 @@ static void do_bootm_qnxelf(cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("QNX" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif sprintf (str,"%lx" , images->ep);/* write entry-point into string */ local_args[0 ] = argv[0 ]; local_args[1 ] = str;/* and provide it via the arguments */ -do_bootelf (cmdtp,0 ,2 , local_args); +do_bootelf (NULL ,0 ,2 , local_args); + +return 1 ; }#endif #if defined(CONFIG_ARTOS ) && defined(CONFIG_PPC ) -static void do_bootm_artos (cmd_tbl_t *cmdtp,int flag, -int argc,char *argv[], +static int do_bootm_artos (int flag,int argc,char *argv[],bootm_headers_t *images) {ulong top;
@@ -1165,7 +1166,7 @@ static void do_bootm_artos (cmd_tbl_t *cmdtp, int flag,#if defined(CONFIG_FIT )if (!images->legacy_hdr_valid) {fit_unsupported_reset ("ARTOS" ); -do_reset (cmdtp, flag, argc, argv); +return 1 ; }#endif
@@ -1237,5 +1238,7 @@ static void do_bootm_artos (cmd_tbl_t *cmdtp, int flag, entry = (void (*)(bd_t *,char *,char **,ulong ))images->ep; (*entry) (kbd, cmdline, fwenv, top); + + return 1; }#endif
lib_arm/bootm.c +2 -8
@@ -56,10 +56,7 @@ static void setup_videolfb_tag (gd_t *gd);static struct tag *params;#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); - -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {bd_t *bd = gd->bd;char *s;
@@ -128,11 +125,8 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],theKernel (0 , machid, bd->bi_boot_params);/* does not return */ -return ; - error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_avr32/bootm.c +2 -8
@@ -34,8 +34,6 @@ DECLARE_GLOBAL_DATA_PTR;/* CPU-specific hook to allow flushing of caches, etc. */ extern void prepare_to_boot (void ); -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); -static struct tag *setup_start_tag (struct tag *params) { params->hdr.tag =ATAG_CORE ;
@@ -173,8 +171,7 @@ static void setup_end_tag(struct tag *params) params->hdr.size =0 ; } -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {void (*theKernel)(int magic,void *tagtable);struct tag *params, *params_start;
@@ -205,9 +202,6 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],theKernel (ATAG_MAGIC , params_start);/* does not return */ -return ; - error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_blackfin/bootm.c +3 -8
@@ -14,8 +14,6 @@#include <image.h> #include <asm/blackfin.h> -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); -#ifdef SHARED_RESOURCES extern void swap_to (int device_id);#endif
@@ -33,8 +31,7 @@ static char *make_command_line(void)return dest; } -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {int (*appl) (char *cmdline);char *cmdline;
@@ -51,8 +48,6 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],dcache_disable (); (*appl) (cmdline);/* does not return */ -return ; - - error: -do_reset (cmdtp, flag, argc, argv); +error: +return 1 ; }
lib_i386/bootm.c +2 -7
@@ -29,10 +29,7 @@#include <asm/zimage.h> /*cmd_boot.c*/ -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); - -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {void *base_ptr;ulong os_data, os_len;
@@ -88,9 +85,7 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],boot_zimage (base_ptr);/* does not return */ -return ; error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_m68k/bootm.c +2 -8
@@ -42,11 +42,8 @@ DECLARE_GLOBAL_DATA_PTR;static ulong get_sp (void );static void set_clocks_in_mhz (bd_t *kbd); -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); -void do_bootm_linux (cmd_tbl_t * cmdtp,int flag, -int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {ulong sp;
@@ -116,11 +113,8 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag,*/ (*kernel) (kbd, initrd_start, initrd_end, cmd_start, cmd_end);/* does not return */ -return ; - error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }static ulong get_sp (void )
lib_microblaze/bootm.c +2 -8
@@ -32,10 +32,7 @@DECLARE_GLOBAL_DATA_PTR ; -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); - -void do_bootm_linux (cmd_tbl_t * cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {/* First parameter is mapped to $r5 for kernel boot args */ void (*theKernel) (char *);
@@ -52,9 +49,6 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],theKernel (commandline);/* does not return */ -return ; - error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_mips/bootm.c +2 -10
@@ -43,15 +43,11 @@ static int linux_env_idx;static void linux_params_init (ulong start,char * commandline);static void linux_env_set (char * env_name,char * env_val); -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); - -void do_bootm_linux (cmd_tbl_t * cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {void (*theKernel) (int ,char **,char **,int *);char *commandline =getenv ("bootargs" );char env_buf[12 ]; -int ret;char *cp;/* find kernel entry point */
@@ -103,11 +99,7 @@ void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],theKernel (linux_argc, linux_argv, linux_env,0 );/* does not return */ -return ; - -error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }static void linux_params_init (ulong start,char *line)
lib_nios/bootm.c +2 -2
@@ -28,7 +28,7 @@* we can get this working. ;-) * */ -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) { +return 1 ; }
lib_nios2/bootm.c +2 -7
@@ -25,10 +25,7 @@#include <command.h> #include <asm/byteorder.h> -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); - -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {void (*kernel)(void ) = (void (*)(void ))images->ep;
@@ -37,9 +34,7 @@ void do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],*/ kernel ();/* does not return */ -return ; error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_ppc/bootm.c +4 -7
@@ -47,7 +47,6 @@DECLARE_GLOBAL_DATA_PTR ; -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]);extern ulong get_effective_memsize (void );static ulong get_sp (void );static void set_clocks_in_mhz (bd_t *kbd);
@@ -56,9 +55,8 @@ static void set_clocks_in_mhz (bd_t *kbd);#define CFG_LINUX_LOWMEM_MAX_SIZE (768*1024*1024)#endif -void __attribute__((noinline)) -do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +__attribute__((noinline)) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {ulong sp;
@@ -234,11 +232,10 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[], cmd_start, cmd_end, 0, 0);/* does not return */ } -return ; +return 1 ; error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }static ulong get_sp (void )
lib_sh/bootm.c +2 -7
@@ -43,8 +43,6 @@#define RAMDISK_IMAGE_START_MASK 0x07FF -extern int do_reset (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]); -#ifdef CFG_DEBUG static void hexdump (unsigned char *buf,int len) {
@@ -59,8 +57,7 @@ static void hexdump (unsigned char *buf, int len) }#endif -void do_bootm_linux (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[], -bootm_headers_t *images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t *images) {char *bootargs =getenv ("bootargs" );
@@ -72,9 +69,7 @@ void do_bootm_linux (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],kernel ();/* does not return */ -return ; error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
lib_sparc/bootm.c +2 -5
@@ -33,7 +33,6 @@extern image_header_t header;extern void srmmu_init_cpu (unsigned int entry);extern void prepare_bootargs (char *bootargs); -extern int do_reset (cmd_tbl_t * cmdtp,int flag,int argc,char *argv[]);#ifdef CONFIG_USB_UHCI extern int usb_lowlevel_stop (void );
@@ -83,8 +82,7 @@ struct __attribute__ ((packed)) {image_header_t ihdr;/* boot the linux kernel */ -void do_bootm_linux (cmd_tbl_t * cmdtp,int flag,int argc,char *argv[], -bootm_headers_t * images) +int do_bootm_linux (int flag,int argc,char *argv[],bootm_headers_t * images) {char *bootargs;ulong initrd_start, initrd_end;
@@ -181,6 +179,5 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],while (1 ) ; error: -do_reset (cmdtp, flag, argc, argv); -return ; +return 1 ; }
Signature · 1 line
1.5.5.1
Wolfgang Denk
AppliedPATCH 15/15 bootm: refactor do_reset and os boot function args
Dear Kumar Gala,
Quoted 9 lines · In message <[email protected]> you…
There is no need for each OS specific function to call
do_reset()we can just do it once in bootm. This means its feasible on an error for the os boot function to return.Also, remove passing in
cmd_tbl_tas its not needed by the OS boot functions. flag isn't currently used but might be in the future so we left it alone.Signed-off-by Kumar Gala <[email protected]>
Quoted 15 lines
--- common/cmd_bootm.c | 67 +++++++++++++++++++++++++----------------------- lib_arm/bootm.c | 10 +----- lib_avr32/bootm.c | 10 +----- lib_blackfin/bootm.c | 11 ++----- lib_i386/bootm.c | 9 +----- lib_m68k/bootm.c | 10 +----- lib_microblaze/bootm.c | 10 +----- lib_mips/bootm.c | 12 +------- lib_nios/bootm.c | 4 +- lib_nios2/bootm.c | 9 +----- lib_ppc/bootm.c | 11 +++----- lib_sh/bootm.c | 9 +----- lib_sparc/bootm.c | 7 +--- 13 files changed, 62 insertions(+), 117 deletions(-)
Applied, thanks.
Wow. What a patch series...
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de In an organization, each person rises to the level of his own incom- petency - The Peter Principle
Wolfgang Denk
AppliedPATCH 14/15 fdt: Added resize command
In reply to Kumar GalaDear Kumar Gala,
Quoted 6 lines · In message <[email protected]> you…
Resize the fdt to size + padding to 4k boundary
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It may be that your whole purpose in life is simply to serve as a warning to others.
Wolfgang Denk
AppliedPATCH 13/15 fdt: refactor initrd related code
In reply to Kumar GalaDear Kumar Gala,
Quoted 11 lines · In message <[email protected]> you…
Created a new
fdt_initrd()to deal with setting the initrd properties in the device tree and fixing up the mem reserve. We can use this both in the choosen node handling and lets us remove some duplicated code when we fixup the initrd info in bootm on PPC.Signed-off-by Kumar Gala <[email protected]>--- common/fdt_support.c | 109 ++++++++++++++++++++++++++++++------------------- include/fdt_support.h | 1 + lib_ppc/bootm.c | 28 +------------ 3 files changed, 70 insertions(+), 68 deletions(-)
Applied, thanks.
Please remind me that we need to do some big uint64_t => phys_addr_t cleanup one day.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes and weighs 30 tons, computers in the future may have only 1,000 vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949
Wolfgang Denk
AppliedPATCH 13/15 fdt: refactor initrd related code
In reply to Kumar GalaDear Kumar Gala,
Quoted 11 lines · In message <[email protected]> you…
Created a new
fdt_initrd()to deal with setting the initrd properties in the device tree and fixing up the mem reserve. We can use this both in the choosen node handling and lets us remove some duplicated code when we fixup the initrd info in bootm on PPC.Signed-off-by Kumar Gala <[email protected]>--- common/fdt_support.c | 109 ++++++++++++++++++++++++++++++------------------- include/fdt_support.h | 1 + lib_ppc/bootm.c | 28 +------------ 3 files changed, 70 insertions(+), 68 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "How to make a million dollars: First, get a million dollars." - Steve Martin
Wolfgang Denk
AppliedPATCH 12/15 fdt: refactor fdt resize code
In reply to Kumar GalaDear Kumar Gala,
Quoted 9 lines · In message <[email protected]> you…
Move the fdt resizing code out of ppc specific boot code and into common fdt support code.
Signed-off-by Kumar Gala <[email protected]>--- common/fdt_support.c | 39 +++++++++++++++++++++++++++++++++++++++ include/fdt_support.h | 1 + lib_ppc/bootm.c | 32 ++++---------------------------- 3 files changed, 44 insertions(+), 28 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de ATTENTION: Despite Any Other Listing of Product Contents Found Here- on, the Consumer is Advised That, in Actuality, This Product Consists Of 99.9999999999% Empty Space.
Wolfgang Denk
AppliedPATCH 11/15 bootm: refactor image detection and os load steps
In reply to Kumar GalaDear Kumar Gala,
Quoted 9 lines · In message <[email protected]> you…
Created a
bootm_start()that handles the parsing and detection of all the images that will be used by the bootm command (OS, ramdisk, fdt). As part of this we now tract all the relevant image offsets in thebootm_headers_tstruct. This will allow us to have all the needed state for future sub-commands and lets us reduce a bit of arch specific code on SPARC.Created a
bootm_load_os()that deals with decompression and loading the OS image.
Quoted 6 lines
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_bootm.c | 216 ++++++++++++++++++++++++++++++---------------------- include/image.h | 9 ++ lib_sparc/bootm.c | 19 +----- 3 files changed, 136 insertions(+), 108 deletions(-)
Frankly, I have no idea if this really works with all image types we have to deal with. But the easiest way to find out is to apply it and make people scream if it doesn't ;-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anything that is worth doing at all is worth doing well.
-- Philip Earl of ChesterfieldWolfgang Denk
AppliedPATCH 10/15 bootm: move lmb into the bootm_headers_t structure
In reply to Kumar GalaDear Kumar Gala,
Quoted 4 lines · In message <[email protected]> you…
To allow for persistent state between future bootm subcommands we need the lmb to exist in a global state. Moving it into the
bootm_headers_tallows us to do that.
Quoted 8 lines
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_bootm.c | 11 ++++------- include/image.h | 4 +++- lib_m68k/bootm.c | 2 +- lib_ppc/bootm.c | 2 +- lib_sparc/bootm.c | 2 +- 5 files changed, 10 insertions(+), 11 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de [Braddock:] Mr. Churchill, you are drunk. [Churchill:] And you madam, are ugly. But I shall be sober tomorrow.
Wolfgang Denk
AppliedPATCH 9/15 bootm: Set working fdt address as part of the bootm flow
In reply to Kumar GalaDear Kumar Gala,
Quoted 11 lines · In message <[email protected]> you…
Set the fdt working address so "fdt FOO" commands can be used as part of the bootm flow. Also set an the environment variable "fdtaddr" with the value.
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_bootm.c | 8 ++++++++ common/cmd_fdt.c | 14 +++++++++++++- common/image.c | 1 + include/fdt_support.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de All I ask is a chance to prove that money can't make me happy.
Wolfgang Denk
AppliedPATCH 8/15 bootm: refactor fdt locating and relocation code
In reply to Kumar GalaDear Kumar Gala,
Quoted 10 lines · In message <[email protected]> you…
Move the code that handles finding a device tree blob and relocating it (if needed) into common code so all arch's have access to it.
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_bootm.c | 10 + common/image.c | 502 ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/image.h | 13 ++ lib_ppc/bootm.c | 492 +-------------------------------------------------- 4 files changed, 533 insertions(+), 484 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Even if you aren't in doubt, consider the mental welfare of the per- son who has to maintain the code after you, and who will probably put parens in the wrong place. - Larry Wall in the perl man page
Wolfgang Denk
AppliedPATCH 7/15 bootm: refactor ramdisk locating code
In reply to Kumar GalaDear Kumar Gala,
Quoted 5 lines · In message <[email protected]> you…
Move determing if we have a ramdisk and where its located into the common code. Keep track of the ramdisk start and end in the
bootm_headers_timage struct.Signed-off-by Kumar Gala <[email protected]>
Quoted 11 lines
--- common/cmd_bootm.c | 38 ++++++++++++++++++++++++++++++++++++++ include/image.h | 2 ++ lib_arm/bootm.c | 10 ++-------- lib_avr32/bootm.c | 12 +++--------- lib_i386/bootm.c | 8 +------- lib_m68k/bootm.c | 12 +++--------- lib_mips/bootm.c | 12 +++--------- lib_ppc/bootm.c | 16 +++++----------- lib_sparc/bootm.c | 17 +++-------------- 9 files changed, 60 insertions(+), 67 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Presidency: The greased pig in the field game of American politics. - Ambrose Bierce
Wolfgang Denk
AppliedPATCH 6/15 bootm: refactor entry point code
In reply to Kumar GalaDear Kumar Gala,
Quoted 4 lines · In message <[email protected]> you…
Move entry point code out of each arch and into common code. Keep the entry point in the
bootm_headers_timages struct.Signed-off-by Kumar Gala <[email protected]>
Quoted 14 lines
--- common/cmd_bootm.c | 31 ++++++++++++++++++++++--------- include/image.h | 2 ++ lib_arm/bootm.c | 19 +------------------ lib_avr32/bootm.c | 19 +------------------ lib_blackfin/bootm.c | 19 +------------------ lib_m68k/bootm.c | 19 +------------------ lib_microblaze/bootm.c | 19 +------------------ lib_mips/bootm.c | 18 +----------------- lib_nios2/bootm.c | 20 +------------------- lib_ppc/bootm.c | 22 +++------------------- lib_sh/bootm.c | 19 +------------------ lib_sparc/bootm.c | 12 ++---------- 12 files changed, 37 insertions(+), 182 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man is the best computer we can put aboard a spacecraft ... and the
only one that can be mass produced with unskilled labor.
- Wernher von BraunPATCH 5/15 fdt: fdt addr w/o any args reports back the current working address
In reply to Kumar GalaHi Jerry,
Quoted 14 lines · In message <[email protected]> Kumar…
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)common/cmd_fdt.c +1
-0@@ -67,6 +67,14 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])/* * Set the address [and length] of the fdt. */ +if (argc ==2 ) {
common/cmd_fdt.c int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) · line 80
Quoted 10 lines
common/cmd_fdt.c +7
-0+if (!fdt_valid ()) { +return 1 ; + } +printf ("The address of the fdt is %p\n" , working_fdt); +return 0 ; + } + working_fdt = (struct fdt_header *)simple_strtoul (argv[2 ],NULL ,16 );if (!fdt_valid ()) {
This looks ok to me. Will you add this, or should I pull it directly?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A Puritan is someone who is deathly afraid that someone, somewhere, is having fun.
PATCH 5/15 fdt: fdt addr w/o any args reports back the current working address
Quoted 7 lines · Wolfgang Denk
Hi Jerry,
Quoted 4 lines · In message <[email protected]> Kumar…
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
[snip]
Quoted 6 lines
This looks ok to me. Will you add this, or should I pull it directly?
Best regards,
Wolfgang Denk
Please pull it directly.
Thanks,
gvb
Wolfgang Denk
AppliedPATCH 5/15 fdt: fdt addr w/o any args reports back the current working address
In reply to Kumar GalaDear Kumar Gala,
Quoted 4 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A star captain's most solemn oath is that he will give his life, even his entire crew, rather than violate the Prime Directive. -- Kirk, "The Omega Glory", stardate unknown
PATCH 4/15 fdt: added the ability to set initrd start/end via chosen command
In reply to Kumar GalaDear Kumar Gala,
Quoted 10 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 21 +++++++++++++++++---- 1 files changed, 17 insertions(+), 4 deletions(-)common/cmd_fdt.c +0
-0
common/cmd_fdt.c int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) · line 421
Quoted 8 lines
common/cmd_fdt.c +2
-3@@ -417,9 +417,21 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])ft_board_setup (working_fdt, gd->bd);#endif /* Create a chosen node */ - else if (argv[1][0] == 'c') - fdt_chosen(working_fdt, 0, 0, 1); - else { + else if (argv[1][0] == 'c') { +unsigned long initrd_start =0 , initrd_end =0 ;
I guess we should use phys_addr_t here.
common/cmd_fdt.c int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) · line 430
Quoted 8 lines
common/cmd_fdt.c +8
-0+if ((argc !=2 ) && (argc !=4 )) { +printf ("Usage:\n%s\n" , cmdtp->usage); +return 1 ; + } + +if (argc ==4 ) { + initrd_start =simple_strtoul (argv[2 ],NULL ,16 ); + initrd_end =simple_strtoul (argv[3 ],NULL ,16 );
Ah - do we have some "simple_strtouphys" yet? I think we don't. This might be a sleeping dog in a lot af places in the code, actually...
Hm... what do you think?
[Except from that it's fine with me.]
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A supercomputer is a machine that runs an endless loop in 2 seconds.
Wolfgang Denk
AppliedPATCH 4/15 fdt: added the ability to set initrd start/end via chosen command
In reply to Kumar GalaDear Kumar Gala,
Quoted 4 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>--- common/cmd_fdt.c | 21 +++++++++++++++++---- 1 files changed, 17 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Albert Einstein
PATCH 3/15 Add command to enable/disable interrupts
In reply to Kumar GalaDear Kumar Gala,
Quoted 6 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>--- common/Makefile | 1 + common/cmd_irq.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 common/cmd_irq.c
...
common/cmd_irq.c line 49
Quoted 5 lines
common/cmd_irq.c new file +5
-0+U_BOOT_CMD ( + interrupts,5 ,0 , do_interrupts, +"interrupts - enable or disable interrupts\n" , +"[on, off]\n" + " - enable or disable interrupts\n"
I suggest to also support this command without argument, in which case it would print the current setting.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The use of anthropomorphic terminology when dealing with computing systems is a symptom of professional immaturity. -- Edsger Dijkstra
PATCH 3/15 Add command to enable/disable interrupts
Quoted 12 lines · Wolfgang Denk
Dear Kumar Gala,
In message <1218806685-3615-3-git-send-email-
Quoted 7 lines · galak at kernel.crashing.org> you wrote:
Signed-off-by Kumar Gala <[email protected]>---
common/Makefile | 1 +common/cmd_irq.c| 50 ++++++++++++++++++++++++++++++++++++++++++++
++++++2 files changed, 51 insertions(+), 0 deletions(-)create mode 100644
common/cmd_irq.c...
Quoted 8 lines
common/cmd_irq.c line 49
Quoted 5 lines
common/cmd_irq.c new file +5
-0+U_BOOT_CMD ( + interrupts,5 ,0 , do_interrupts, +"interrupts - enable or disable interrupts\n" , +"[on, off]\n" + " - enable or disable interrupts\n"I suggest to also support this command without argument, in which case it would print the current setting.
The current arch interfaces don't have a "clean" way to do this right now.
I can hack it in via:
iflag = disable_interrupts()
if (iflag) {
enable_interrupts()
printf("interrupts are enabled\n");
} else {
printf("interrupts are disabled\n");
}If this isn't ok, I'd request you take this patch and I'll look at adding an get_irqflags() to all the arches and add support to print the interrupt state based on that.
- k
Wolfgang Denk
AppliedPATCH 3/15 Add command to enable/disable interrupts
In reply to Kumar GalaDear Kumar Gala,
Quoted 6 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>--- common/Makefile | 1 + common/cmd_irq.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 common/cmd_irq.c
Applied, thanks.
Let's keep in mind to enahnce this command for status inquiry later. Thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
[Doctors and Bartenders], We both get the same two kinds of customers
-- the living and the dying.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknownWolfgang Denk
AppliedPATCH 2/15 Clean up usage of icache_disable/dcache_disable
In reply to Kumar GalaDear Kumar Gala,
Quoted 9 lines · In message <[email protected]> you…
There is no point in disabling the icache on 7xx/74xx/86xx parts and not also flushing the icache. All callers of
invalidate_l1_instruction_cache()callicache_disable()right after. Make it soicache_disable()callsinvalidate_l1_instruction_cache()for us.Also,
dcache_disable()already callsdcache_flush()so there is no point in the explicit calls ofdcache_flush().Signed-off-by Kumar Gala <[email protected]>
Quoted 10 lines
--- board/Marvell/db64360/db64360.c | 5 ----- board/Marvell/db64460/db64460.c | 5 ----- board/esd/cpci750/cpci750.c | 4 ---- board/freescale/mpc7448hpc2/mpc7448hpc2.c | 2 -- board/prodrive/p3mx/p3mx.c | 2 -- common/cmd_bootm.c | 2 -- cpu/74xx_7xx/cache.S | 4 ++++ cpu/mpc86xx/cache.S | 4 ++++ 8 files changed, 8 insertions(+), 20 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Small is beautiful.
Wolfgang Denk
AppliedPATCH 1/15 Update linux bootm to support ePAPR client interface
In reply to Kumar GalaDear Kumar Gala,
Quoted 8 lines · In message <[email protected]> you…
the ePAPR spec has some subtle differences from the current device tree based boot interface to the powerpc linux kernel. The powerpc linux kernel currently ignores the differences that ePAPR specifies.
Signed-off-by Kumar Gala <[email protected]>--- lib_ppc/bootm.c | 33 +++++++++++++++++++++++---------- 1 files changed, 23 insertions(+), 10 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A princess should not be afraid -- not with a brave knight to protect her. -- McCoy, "Shore Leave", stardate 3025.3