Skip to contentSkip to conversation

RFC: add LANG=C in stubdom's Makefile

PATCH In review Akio Takebe 2 participants 2 messages Aug 28, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RFC: add LANG=C in stubdom's Makefile

Hi,

I got a compile error of stubdom.
My environment is LANG=ja_JP.UTF-8,
and "gcc -print-search-dirs" prints Japanese messase.

[e.g.]

# echo $LANG
ja_JP.UTF-8
#  gcc -print-search-dirs
インストール: /usr/lib/gcc/i386-redhat-linux/4.3.0/
プログラム: =/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/:/usr/libexec/gcc/i386-redhat-linux/4.3.0/:/usr/libexec/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/bin/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/bin/
ライブラリ: =/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/lib/i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../../i386-redhat-linux/lib/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../i386-redhat-linux/4.3.0/:/usr/lib/gcc/i386-redhat-linux/4.3.0/../../../:/lib/i386-redhat-linux/4.3.0/:/lib/:/usr/lib/i386-redhat-linux/4.3.0/:/usr/lib/

So shell command of stubdom's Makefile doesn't work. I made a patch for Japanese people. :)
How about it?

Best Regards,

Akio Takebe

stubdom/Makefile +1 -1
diff -r 6c50c7d089d9 stubdom/Makefile
@@ -53,7 +53,7 @@
 TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
 
 # Do not use host headers and libs
-GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
+GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
 TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
 TARGET_CPPFLAGS += -nostdinc
 TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix
stubdom/Makefile +1 -1
diff -r 6c50c7d089d9 stubdom/Makefile
@@ -53,7 +53,7 @@
 TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
 
 # Do not use host headers and libs
-GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
+GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
 TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
 TARGET_CPPFLAGS += -nostdinc
 TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 4 lines · Akio Takebe, le Thu 28 Aug 2008 17:14:20 +0900, a écrit :
# echo $LANG
ja_JP.UTF-8
#  gcc -print-search-dirs
インストール: /usr/lib/gcc/i386-redhat-linux/4.3.0/

Argl, so that part is localized actually... (it is not translated in the french locale).

stubdom/Makefile line 59

Quoted 12 lines

diff -r 6c50c7d089d9 stubdom/Makefile

stubdom/Makefile +1 -1
@@ -53,7 +53,7 @@
 TARGET_CFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,)
 
 # Do not use host headers and libs
-GCC_INSTALL = $(shell gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
+GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -e 's/install: \(.*\)/\1/p')
 TARGET_CPPFLAGS += -U __linux__ -U __FreeBSD__ -U __sun__
 TARGET_CPPFLAGS += -nostdinc
 TARGET_CPPFLAGS += -isystem $(CURDIR)/$(MINI_OS)/include/posix

Should be fine.

Samuel