Skip to contentSkip to conversation

x86: pgd_{c,d}tor() cleanup

PATCH Applied Jan Beulich 2 participants 2 messages Aug 29, 2008 – Sep 6, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: pgd_{c,d}tor() cleanup

Giving pgd_ctor() a properly typed parameter allows eliminating a local variable. Adjust pgd_dtor() to match.

---
 arch/x86/mm/pgtable.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/x86/mm/pgtable.c +2 -4
@@ -63,10 +63,8 @@ static inline void pgd_list_del(pgd_t *p
 #define UNSHARED_PTRS_PER_PGD				\
 	(SHARED_KERNEL_PMD ? KERNEL_PGD_BOUNDARY : PTRS_PER_PGD)
 
-static void pgd_ctor(void *p)
+static void pgd_ctor(pgd_t *pgd)
 {
-	pgd_t *pgd = p;
-
 	/* If the pgd points to a shared pagetable level (either the
 	   ptes in non-PAE, or shared PMD in PAE), then just copy the
 	   references from swapper_pg_dir. */
@@ -87,7 +85,7 @@ static void pgd_ctor(void *p)
 		pgd_list_add(pgd);
 }
 
-static void pgd_dtor(void *pgd)
+static void pgd_dtor(pgd_t *pgd)
 {
 	unsigned long flags; /* can be called from interrupt context */