Skip to contentSkip to conversation

config.mk: Move arch-specific condition to $(ARCH)_config.mk

PATCH New Shinya Kuribayashi 2 participants 4 messages Aug 30, 2008 – Sep 11, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config.mk: Move arch-specific condition to $(ARCH)_config.mk

---
 config.mk     |   16 ----------------
 ppc_config.mk |   14 ++++++++++++++
 2 files changed, 14 insertions(+), 16 deletions(-)
config.mk +0 -16
index 1dac29b..c225df1 100644
@@ -44,22 +44,6 @@ PLATFORM_RELFLAGS =
 PLATFORM_CPPFLAGS =
 PLATFORM_LDFLAGS =
 
-#
-# When cross-compiling on NetBSD, we have to define __PPC__ or else we
-# will pick up a va_list declaration that is incompatible with the
-# actual argument lists emitted by the compiler.
-#
-# [Tested on NetBSD/i386 1.5 + cross-powerpc-netbsd-1.3]
-
-ifeq ($(ARCH),ppc)
-ifeq ($(CROSS_COMPILE),powerpc-netbsd-)
-PLATFORM_CPPFLAGS+= -D__PPC__
-endif
-ifeq ($(CROSS_COMPILE),powerpc-openbsd-)
-PLATFORM_CPPFLAGS+= -D__PPC__
-endif
-endif
-
 ifeq ($(ARCH),arm)
 ifeq ($(CROSS_COMPILE),powerpc-netbsd-)
 PLATFORM_CPPFLAGS+= -D__ARM__
ppc_config.mk +14 -0
index 31993bd..c95b3b1 100644
@@ -23,3 +23,17 @@
 
 PLATFORM_CPPFLAGS += -DCONFIG_PPC -D__powerpc__
 PLATFORM_LDFLAGS  += -n
+
+#
+# When cross-compiling on NetBSD, we have to define __PPC__ or else we
+# will pick up a va_list declaration that is incompatible with the
+# actual argument lists emitted by the compiler.
+#
+# [Tested on NetBSD/i386 1.5 + cross-powerpc-netbsd-1.3]
+
+ifeq ($(CROSS_COMPILE),powerpc-netbsd-)
+PLATFORM_CPPFLAGS+= -D__PPC__
+endif
+ifeq ($(CROSS_COMPILE),powerpc-openbsd-)
+PLATFORM_CPPFLAGS+= -D__PPC__
+endif
#1 lore raw

PATCH 1/1 make: Remove redundant __ARM__ addition when cross-compiling on *BSD

__ARM__ is given by arm_config.mk automatically.

---
 config.mk |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)
config.mk +0 -9
index c225df1..5a9334c 100644
@@ -44,15 +44,6 @@ PLATFORM_RELFLAGS =
 PLATFORM_CPPFLAGS =
 PLATFORM_LDFLAGS =
 
-ifeq ($(ARCH),arm)
-ifeq ($(CROSS_COMPILE),powerpc-netbsd-)
-PLATFORM_CPPFLAGS+= -D__ARM__
-endif
-ifeq ($(CROSS_COMPILE),powerpc-openbsd-)
-PLATFORM_CPPFLAGS+= -D__ARM__
-endif
-endif
-
 #########################################################################
 
 CONFIG_SHELL	:= $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
#2 lore raw

PATCH 1/1 make: Remove redundant __ARM__ addition when cross-compiling on *BSD

Ping.

[ I should have let you know, Wolfgang. Sorry. ]

Quoted 32 lines · Shinya Kuribayashi

__ARM__ is given by arm_config.mk automatically.

---
 config.mk |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)
config.mk +0 -9
index c225df1..5a9334c 100644
@@ -44,15 +44,6 @@ PLATFORM_RELFLAGS =
 PLATFORM_CPPFLAGS =
 PLATFORM_LDFLAGS =
 
-ifeq ($(ARCH),arm)
-ifeq ($(CROSS_COMPILE),powerpc-netbsd-)
-PLATFORM_CPPFLAGS+= -D__ARM__
-endif
-ifeq ($(CROSS_COMPILE),powerpc-openbsd-)
-PLATFORM_CPPFLAGS+= -D__ARM__
-endif
-endif
-
 #########################################################################
 
 CONFIG_SHELL	:= $(shell if [ -x "$$BASH" ]; then echo $$BASH; \

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw

PATCH 1/1 config.mk: Move arch-specific condition to $(ARCH)_config.mk

In reply to Shinya Kuribayashi

Dear Shinya Kuribayashi,

Quoted 5 lines · In message <[email protected]> you wrote:
---
 config.mk     |   16 ----------------
 ppc_config.mk |   14 ++++++++++++++
 2 files changed, 14 insertions(+), 16 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The following statement is not true.  The previous statement is true.