Skip to contentSkip to conversation

hda: Distortion fix for dell_m6_core_init

PATCH In review Matthew Ranostay 2 participants 3 messages Aug 31, 2008 – Sep 1, 2008

lore
Share & tools
lore

Matthew Ranostay

author
#0 lore raw

PATCH 1/1 hda: Distortion fix for dell_m6_core_init

Added the EQ distortion fix to the dell_m6_core_init.

---

Signed-off-by Matthew Ranostay <[email protected]>
pci/hda/patch_sigmatel.c +3 -2
index 6ad6ef3..9968ee4 100644
@@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
 };
 
 static struct hda_verb dell_m6_core_init[] = {
-	/* set master volume and direct control */
-	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
+	/* set master volume to max value without distortion
+	 * and direct control */
+	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
 	/* setup audio connections */
 	{ 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
 	{ 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
#1 lore raw

At Sun, 31 Aug 2008 14:53:38 -0400,

Quoted 5 lines · Matthew Ranostay

Added the EQ distortion fix to the dell_m6_core_init.

---

Signed-off-by Matthew Ranostay <[email protected]>

Thanks. I'll include this as 2.6.27 fixes, too.

BTW, I found the volume-knob on 0x1f is set to 0xff with other models (e.g. intel boards). Don't you need to fix them as well?

Takashi

Quoted 17 lines
pci/hda/patch_sigmatel.c +3 -2
index 6ad6ef3..9968ee4 100644
@@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
 };
 
 static struct hda_verb dell_m6_core_init[] = {
-	/* set master volume and direct control */
-	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
+	/* set master volume to max value without distortion
+	 * and direct control */
+	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
 	/* setup audio connections */
 	{ 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
 	{ 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
author
#2 lore raw
Quoted 4 lines · Takashi Iwai

At Sun, 31 Aug 2008 14:53:38 -0400,

Quoted 2 lines · Matthew Ranostay

Added the EQ distortion fix to the dell_m6_core_init.

Quoted 8 lines
Quoted 2 lines

---

Signed-off-by Matthew Ranostay <[email protected]>

Thanks. I'll include this as 2.6.27 fixes, too.

BTW, I found the volume-knob on 0x1f is set to 0xff with other models (e.g. intel boards). Don't you need to fix them as well?

Nope, they don't have this issue.

Quoted 21 lines

Takashi

Quoted 17 lines
pci/hda/patch_sigmatel.c +3 -2
index 6ad6ef3..9968ee4 100644
@@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = {
 };
 
 static struct hda_verb dell_m6_core_init[] = {
-	/* set master volume and direct control */
-	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
+	/* set master volume to max value without distortion
+	 * and direct control */
+	{ 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec},
 	/* setup audio connections */
 	{ 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00},
 	{ 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},