Skip to contentSkip to conversation

The commented line in udev-test.pl to use valgrind needs

PATCH In review Alan Jenkins 2 participants 4 messages Aug 31, 2008 – Sep 3, 2008

lore
Share & tools
lore

Alan Jenkins

author
#0 lore raw

PATCH 1/1 The commented line in udev-test.pl to use valgrind needs

Also run with --quiet to show errors only.

Signed-off-by Alan Jenkins <[email protected]>
test/udev-test.pl +1 -1
index ad551dd..6c51399 100755
@@ -29,7 +29,7 @@ my $udev_rules	= "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";
 
 my @tests = (
 	{
#1 lore raw

Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing

Quoted 9 lines · Alan Jenkins

Also run with --quiet to show errors only.

Signed-off-by Alan Jenkins <[email protected]>
test/udev-test.pl +0 -0
index ad551dd..6c51399 100755

test/udev-test.pl my $udev_rules = "udev-test.rules"; · line 32

Quoted 5 lines
test/udev-test.pl +1 -1
@@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";

I've added a --valgrind option instead, so there is no longer the need to change the source file.

Thanks,
Kay

author
#2 lore raw
In reply to Alan Jenkins
Quoted 21 lines · Kay Sievers
Quoted 9 lines · Alan Jenkins

Also run with --quiet to show errors only.

Signed-off-by Alan Jenkins <[email protected]>
test/udev-test.pl +0 -0
index ad551dd..6c51399 100755

test/udev-test.pl my $udev_rules = "udev-test.rules"; · line 33

Quoted 6 lines
test/udev-test.pl +1 -1
@@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";

I've added a --valgrind option instead, so there is no longer the need to change the source file.

Quoted 3 lines

Thanks,
Kay

Ah, you forgot to remove this line though:

# uncomment following line to run udev with valgrind.

Alan

#3 lore raw

Re: [PATCH] The commented line in udev-test.pl to use valgrind needs fixing

In reply to Alan Jenkins
Quoted 22 lines · Alan Jenkins
Quoted 21 lines · Kay Sievers
Quoted 9 lines · Alan Jenkins

Also run with --quiet to show errors only.

Signed-off-by Alan Jenkins <[email protected]>
test/udev-test.pl +0 -0
index ad551dd..6c51399 100755

test/udev-test.pl my $udev_rules = "udev-test.rules"; · line 33

Quoted 6 lines
test/udev-test.pl +1 -1
@@ -29,7 +29,7 @@ my $udev_rules        = "udev-test.rules";
 
 # uncomment following line to run udev with valgrind.
 # Should make this a runtime option to the script someday...
-#my $udev_bin  = "valgrind --tool=memcheck --leak-check=yes   ../udev";
+#$udev_bin  = "valgrind --tool=memcheck --leak-check=yes --quiet $udev_bin";

I've added a --valgrind option instead, so there is no longer the need to change the source file.

Quoted 4 lines
Quoted 3 lines

Thanks,
Kay

Ah, you forgot to remove this line though:

Removed.

Thanks,
Kay