Skip to contentSkip to conversation

fs_enet: Using mii-bitbang as module

FIX Heiko Schocher 2 participants 2 messages Sep 4, 2008 Network drivers

lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

Hello Vitaly,

I tried to use the mii-bitbang driver (drivers/net/fs_enet/mii-bitbang.c) as a module and got the following error, when inserting it with insmod:

~ # insmod fs_enet
eth0: fs_enet: a6:07:11:7f:de:26
~ # insmod mii-bitbang
mii_bitbang: module license 'unspecified' taints kernel.
mii_bitbang: Unknown symbol of_address_to_resource
mii_bitbang: Unknown symbol of_irq_to_resource
insmod: cannot insert '/lib/modules/2.6.27-rc5-01144-g967b424-dirty/kernel/drivers/net/fs_enet/mii-bitbang.ko': Unknown symbol in module (-1): No such file or directory ~ #

Following patch solves this. Maybe you add the other MODULE_ macros too?

Signed-off-by Heiko Schocher <[email protected]>
---
 drivers/net/fs_enet/mii-bitbang.c                  |    2 +
 1 file changed, 2 insertions(+)
drivers/net/fs_enet/mii-bitbang.c +2 -0
index be4b72f..863ceed 100644
@@ -26,6 +26,8 @@
 
 #include "fs_enet.h"
 
+MODULE_LICENSE("GPL");
+
 struct bb_info {
 	struct mdiobb_ctrl ctrl;
 	__be32 __iomem *dir;
Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

В Thu, 04 Sep 2008 08:01:38 +0200
Heiko Schocher <[email protected]> пишет:

Quoted 16 lines

Hello Vitaly,

I tried to use the mii-bitbang driver (drivers/net/fs_enet/mii-bitbang.c) as a module and got the following error, when inserting it with insmod:

~ # insmod fs_enet
eth0: fs_enet: a6:07:11:7f:de:26
~ # insmod mii-bitbang
mii_bitbang: module license 'unspecified' taints kernel.
mii_bitbang: Unknown symbol of_address_to_resource
mii_bitbang: Unknown symbol of_irq_to_resource
insmod: cannot insert '/lib/modules/2.6.27-rc5-01144-g967b424-dirty/kernel/drivers/net/fs_enet/mii-bitbang.ko':
Unknown symbol in module (-1): No such file or directory ~ #

Quoted 2 lines

Following patch solves this. Maybe you add the other MODULE_ macros too?

Maybe _DESCRIPTION()... I'll combine my part with yours and will send it to netdev.

Thanks,
-Vitaly

Quoted 19 lines
Signed-off-by Heiko Schocher <[email protected]>
---
 drivers/net/fs_enet/mii-bitbang.c                  |    2 +
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/drivers/net/fs_enet/mii-bitbang.c index be4b72f..863ceed 100644

drivers/net/fs_enet/mii-bitbang.c +2 -0
@@ -26,6 +26,8 @@
 
 #include "fs_enet.h"
 
+MODULE_LICENSE("GPL");
+
 struct bb_info {
 	struct mdiobb_ctrl ctrl;
 	__be32 __iomem *dir;