Skip to contentSkip to conversation

HID: make compat functions static

DISCUSSION Jiri Slaby 1 participant 1 message Sep 4, 2008 HID

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

Hi,

does the hid-dummy module runtime-link after the change?

ANSI C standard says:
* In the set of translation units and libraries that constitutes an entire program, each declaration of a particular identifier with external linkage denotes the same object or function. Within one translation unit, each declaration of an identifier with _internal linkage_ denotes the same object or function. Each declaration of an identifier with no linkage denotes a unique entity.
* If the declaration of a file scope identifier for an object or a function contains the storage-class specifier _static_, the identifier has _internal linkage_.
* For an identifier declared with the storage-class specifier _extern_ in a scope in which a _prior declaration_ of that identifier is visible, if the prior declaration specifies _internal_ or external linkage, the linkage of the identifier at the later declaration _is the same as the linkage specified at the prior declaration_. If no prior declaration is visible, or if the prior declaration specifies no linkage, then the identifier has external linkage.

(Note that EXPORT_SYMBOL adds extern.)

I can't find any extension of gnu C to this which would permit that so I think and correct me if I'm wrong, the commit is incorrect? Even according to nm, the symbol is local, e.g.:
0000000000000120 t hid_compat_monterey

From: Harvey Harrison <[email protected]>
Date: Tue, 2 Sep 2008 16:05:43 +0000 (+0200)
Subject: HID: make compat functions static
X-Git-Url:
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fjikos%2Fhid.git;a=commitdiff_plain;h=f72f87666264c9d4880166bcc69cb5c4cf210449

HID: make compat functions static

Done to avoid sparse warnings about undeclared functions.

---

include/linux/hid.h +1 -1
index 15ee33e..164ce7f 100644
@@ -794,7 +794,7 @@ dbg_hid(const char *fmt, ...)
 
 #ifdef CONFIG_HID_COMPAT
 #define HID_COMPAT_LOAD_DRIVER(name)	\
-void hid_compat_##name(void) { }	\
+static void hid_compat_##name(void) { }	\
 EXPORT_SYMBOL(hid_compat_##name)
 #else
 #define HID_COMPAT_LOAD_DRIVER(name)