Skip to contentSkip to conversation

sata_mv add RocketRaid 1720 PCI ID to driver

PATCH New Mark Lord 2 participants 4 messages Sep 4, 2008 – Sep 8, 2008 libata

lore
Share & tools
lore

Mark Lord

author
#0 lore raw

PATCH 1/1 sata_mv add RocketRaid 1720 PCI ID to driver

Add PCI ID for RocketRAID 1720 to sata_mv.

---

This is for 2.6.27. Pretty harmless.

drivers/ata/sata_mv.c +0 -0
@@ -667,7 +667,8 @@
	{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
	{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
	{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
-	/* RocketRAID 1740/174x have different identifiers */
+	/* RocketRAID 1720/174x have different identifiers */
+	{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
	{ PCI_VDEVICE(TTI, 0x1740), chip_508x },
	{ PCI_VDEVICE(TTI, 0x1742), chip_508x },
drivers/ata/sata_mv.c renamed from drivers/ata/sata_mv.c.orig +2 -1
@@ -667,7 +667,8 @@
 	{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
 	{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
 	{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
-	/* RocketRAID 1740/174x have different identifiers */
+	/* RocketRAID 1720/174x have different identifiers */
+	{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
 	{ PCI_VDEVICE(TTI, 0x1740), chip_508x },
 	{ PCI_VDEVICE(TTI, 0x1742), chip_508x },
 
author
#1 lore raw

PATCH 1/1 sata_mv: add RocketRaid 1720 PCI ID to driver

Add PCI ID for RocketRAID 1720 to sata_mv.

---
Resending, with fixed whitespace and a colon on the subject line. :) This is for 2.6.27. Pretty harmless.

drivers/ata/sata_mv.c +0 -0
@@ -667,7 +667,8 @@
	{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
	{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
	{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
-	/* RocketRAID 1740/174x have different identifiers */
+	/* RocketRAID 1720/174x have different identifiers */
+	{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
	{ PCI_VDEVICE(TTI, 0x1740), chip_508x },
	{ PCI_VDEVICE(TTI, 0x1742), chip_508x },
author
#2 lore raw

Re: [PATCH] sata_mv: add RocketRaid 1720 PCI ID to driver

Quoted 12 lines · Mark Lord

Add PCI ID for RocketRAID 1720 to sata_mv.

---
Resending, with fixed whitespace and a colon on the subject line. :) This is for 2.6.27. Pretty harmless.

--- linux-2.6.27-rc4/drivers/ata/sata_mv.c 2008-08-29
21:35:45.000000000 +0200
+++ linux/drivers/ata/sata_mv.c 2008-08-29 21:36:38.000000000 +0200

Review line 674

Quoted 9 lines
(quoted diff) +2 -1
@@ -667,7 +667,8 @@
    { PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
    { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
    { PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
-    /* RocketRAID 1740/174x have different identifiers */
+    /* RocketRAID 1720/174x have different identifiers */
+    { PCI_VDEVICE(TTI, 0x1720), chip_6042 },
    { PCI_VDEVICE(TTI, 0x1740), chip_508x },
    { PCI_VDEVICE(TTI, 0x1742), chip_508x },
 

..

Jeff, this is a patch that failed to be picked up during the 2.6.26 cycle, so can we please get it into 2.6.27 now?

Even Linus says this kind of trivial driver stuff is okay during -rc:

Quoted 4 lines · Principal Penguin

- but as a special case, we relax that for totally new drivers (and that includes things like just adding a new PCI or USB ID's to old drivers), because (a) it can't really regress and (b) support for a specific piece of hardware can often be critical.

Thanks

Applied
#3 lore raw

Re: [PATCH] sata_mv: add RocketRaid 1720 PCI ID to driver

In reply to Mark Lord
Quoted 12 lines · Mark Lord

Add PCI ID for RocketRAID 1720 to sata_mv.

---
Resending, with fixed whitespace and a colon on the subject line. :) This is for 2.6.27. Pretty harmless.

--- linux-2.6.27-rc4/drivers/ata/sata_mv.c 2008-08-29
21:35:45.000000000 +0200
+++ linux/drivers/ata/sata_mv.c 2008-08-29 21:36:38.000000000 +0200

Review line 673

Quoted 8 lines
(quoted diff) +2 -1
@@ -667,7 +667,8 @@
    { PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
    { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
    { PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
-    /* RocketRAID 1740/174x have different identifiers */
+    /* RocketRAID 1720/174x have different identifiers */
+    { PCI_VDEVICE(TTI, 0x1720), chip_6042 },
    { PCI_VDEVICE(TTI, 0x1740), chip_508x },
    { PCI_VDEVICE(TTI, 0x1742), chip_508x },

applied