Crash bug in bluez-4.4

Bluez-devel Fabien Chevalier 2 participants 2 messages Sep 8, 2008 Bluetooth drivers

lore

Share & tools

lore

Fabien Chevalier

author

2008-09-08 19:44 UTC #0 lore raw

Hi All,

Just found a funny bug, steps to reproduce below:

1) make sure you have no headset whatsoever configured in bluez (fresh empty setup)

2) Configure your asoundrc with empty bluetooth parameters

pcm.bluetooth {
type bluetooth
}

ctl.bluetooth {
type bluetooth
}

3)Launch your favourite ALSA base player, configure "bluetooth" as output device

4) Hit play.

5) *BANG*
bluetoothd[17227]: Parsing /usr/local/stow/bluez-4.4/etc/bluetooth/audio.conf failed: No such file or directory
bluetoothd[17227]: Unix socket created: 13 bluetoothd[17227]: Telephony plugin initialized bluetoothd[17227]: HFP AG features: (none) bluetoothd[17227]: Accepted new client connection on unix socket (fd=10) bluetoothd[17227]: Audio API: received BT_GETCAPABILITIES_REQ Erreur de segmentation
palomino:/usr/local/stow#

Path attached fixes the bug... by removing three lines of code that seem to me not only a premature, but also bogus optimization :-(, that prevent us to trying to return the first element of an empty gslist.

However i'm not that familiar with that manager stuff and might be wrong, so please double check that ;-)

Cheers,

Fabien

manager.c renamed from manager.c.orig +0 -3

@@ -999,9 +999,6 @@
 {
 	GSList *l;
 
-	if (!bacmp(bda, BDADDR_ANY) && !interface && !connected)
-		return devices->data;
-
 	for (l = devices; l != NULL; l = l->next) {
 		struct audio_device *dev = l->data;

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Johan Hedberg

2008-09-08 19:59 UTC #1 lore raw

Hi Fabien,

Quoted 7 lines · Fabien Chevalier

Path attached fixes the bug... by removing three lines of code that seem to me not only a premature, but also bogus optimization :-(, that prevent us to trying to return the first element of an empty gslist.
However i'm not that familiar with that manager stuff and might be wrong, so please double check that ;-)

Good catch, and the patch looks good too. Another alternative would have been to change the return line to
return devices ? devices->data : NULL;
but you're right in that it's just an unnecessary optimization. The fix is now in the kernel.org git.

Johan